Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-26 Thread Stefan Fuhrmann
On Wed, Aug 26, 2015 at 1:31 PM, Ivan Zhakov wrote: > On 26 August 2015 at 11:18, Branko Čibej wrote: > > On 25.08.2015 23:08, Stefan Fuhrmann wrote: > >>> All right, so I figured that the difference is that apr_array_make does > >>> two allocations compared to one in this code. Still: relying o

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-26 Thread Ivan Zhakov
On 26 August 2015 at 11:18, Branko Čibej wrote: > On 25.08.2015 23:08, Stefan Fuhrmann wrote: >>> All right, so I figured that the difference is that apr_array_make does >>> two allocations compared to one in this code. Still: relying on >>> knowledge of APR implementation details is a really bad

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-26 Thread Evgeny Kotkov
Branko Čibej writes: > I still think this kind of performance hack belongs in APR. Users that > don't have a new-enough APR won't get the performance boost, but on the > other hand, the kind of bug that started this discussion will stay out > of our code. > > I think we've had our fair share of a

RE: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-26 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: woensdag 26 augustus 2015 10:19 > To: Subversion Development > Subject: Re: svn commit: r1694533 - > /subversion/trunk/subversion/libsvn_ra_svn/marshal.c > > On 25.08.2015 23:08, Stefan

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-26 Thread Branko Čibej
On 25.08.2015 23:08, Stefan Fuhrmann wrote: >> All right, so I figured that the difference is that apr_array_make does >> two allocations compared to one in this code. Still: relying on >> knowledge of APR implementation details is a really bad idea. > > The structure definition of apr_array_header

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-25 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Tue, Aug 25, 2015 at 22:08:05 +0100: > On Tue, Aug 25, 2015 at 3:23 PM, Branko Čibej wrote: > > > On 25.08.2015 14:10, Branko Čibej wrote: > > All right, so I figured that the difference is that apr_array_make does > > two allocations compared to one in this code. Still:

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-25 Thread Stefan Fuhrmann
On Tue, Aug 25, 2015 at 10:08 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > ./subversion/svnserve/svnserve -Tdr > /media/stefan/033c7ee9-9980-45a8-b9c6-f911dc2ac664/f7-test/ -M 1000 -c 0 > --client-speed 10 > stefan@macbook:~/develop/trunk$ time ./subversion/svn/svn diff > --sum

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-25 Thread Stefan Fuhrmann
./subversion/svnserve/svnserve -Tdr /media/stefan/033c7ee9-9980-45a8-b9c6-f911dc2ac664/f7-test/ -M 1000 -c 0 --client-speed 10 stefan@macbook:~/develop/trunk$ time ./subversion/svn/svn diff --summarize svn://localhost/ruby-f6-packed -r0:HEAD > /dev/null real0m2.150s user0m1.964s sys

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-25 Thread Branko Čibej
On 25.08.2015 14:10, Branko Čibej wrote: > On 06.08.2015 18:10, stef...@apache.org wrote: >> Author: stefan2 >> Date: Thu Aug 6 16:10:39 2015 >> New Revision: 1694533 >> >> URL: http://svn.apache.org/r1694533 >> Log: >> Fix an alignment problem on machines with 32 bit pointers but atomic 64 >> dat

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-25 Thread Branko Čibej
On 06.08.2015 18:10, stef...@apache.org wrote: > Author: stefan2 > Date: Thu Aug 6 16:10:39 2015 > New Revision: 1694533 > > URL: http://svn.apache.org/r1694533 > Log: > Fix an alignment problem on machines with 32 bit pointers but atomic 64 > data access that may not be misaligned. > > * subversi

Re: svn commit: r1694533 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

2015-08-06 Thread Rainer Jung
Am 06.08.2015 um 18:10 schrieb stef...@apache.org: Author: stefan2 Date: Thu Aug 6 16:10:39 2015 New Revision: 1694533 URL: http://svn.apache.org/r1694533 Log: Fix an alignment problem on machines with 32 bit pointers but atomic 64 data access that may not be misaligned. * subversion/libsvn_ra