Julian Foad wrote on 2018-06-15:
> Bert Huijben wrote on 2018-06-14:
> > On the testsuite we explicitly disable the sleeps via the environment
> > variable designed for this (except for a few specific tests). We
> > compensate for this problem in quite a few places by making sure that we
> > als
gt; > To: Philip Martin
> > Cc: dev@subversion.apache.org
> > Subject: Re: shelf-tests failure on macOS
> >
> > Philip Martin wrote on 2018-06-14:
> > > Philip Martin writes:
> > > > Julian Foad writes:
> > > >> The most unusual thing ab
age-
> From: Julian Foad [mailto:julianf...@apache.org]
> Sent: donderdag 14 juni 2018 19:35
> To: Philip Martin
> Cc: dev@subversion.apache.org
> Subject: Re: shelf-tests failure on macOS
>
> Philip Martin wrote on 2018-06-14:
> > Philip Martin writes:
> > &g
Philip Martin wrote on 2018-06-14:
> Philip Martin writes:
> > Julian Foad writes:
> >> The most unusual thing about these failing tests is the data they
> >> write. Strings of 5 or 6 low-value bytes, like:
> >>
> >> '\0\1\2\3\4\5'
> >> '\5\4\3\2\1\0'
> >
> > Those are the same size. Could it be
On 14.06.2018 18:09, Philip Martin wrote:
> Philip Martin writes:
>
>> Julian Foad writes:
>>
>>> The most unusual thing about these failing tests is the data they
>>> write. Strings of 5 or 6 low-value bytes, like:
>>>
>>> '\0\1\2\3\4\5'
>>> '\5\4\3\2\1\0'
>> Those are the same size. Could it b
Philip Martin writes:
> Julian Foad writes:
>
>> The most unusual thing about these failing tests is the data they
>> write. Strings of 5 or 6 low-value bytes, like:
>>
>> '\0\1\2\3\4\5'
>> '\5\4\3\2\1\0'
>
> Those are the same size. Could it be a filesystem timestamp resolution
> issue? The f
Julian Foad writes:
> The most unusual thing about these failing tests is the data they
> write. Strings of 5 or 6 low-value bytes, like:
>
> '\0\1\2\3\4\5'
> '\5\4\3\2\1\0'
Those are the same size. Could it be a filesystem timestamp resolution
issue? The file changes but the timestamp does no
Daniel Shahaf wrote on 2018-06-14:
> Julian Foad wrote on Thu, 14 Jun 2018 16:06 +0100:
> > Branko Čibej wrote on 2018-06-14:
> > > A sync (which forces a write to disk) should not be necessary in cases
> > > like this one, as long as we close the file in Python — that should
> > > ensure a write t
Julian Foad wrote on Thu, 14 Jun 2018 16:06 +0100:
> Branko Čibej wrote on 2018-06-14:
> > A sync (which forces a write to disk) should not be necessary in cases
> > like this one, as long as we close the file in Python — that should
> > ensure a write to the OS buffers. If this were the problem, S
Branko Čibej wrote on 2018-06-14:
> A sync (which forces a write to disk) should not be necessary in cases
> like this one, as long as we close the file in Python — that should
> ensure a write to the OS buffers. If this were the problem, Subversion
> wouldn't work on macOS at all.
>
> I still don
On 14.06.2018 16:50, Julian Foad wrote:
> Branko Čibej wrote:
>> The object lifetime and implicit close are very well defined indeed in
>> CPython, which we use. We don't use "modern Pythons on other virtual
>> machines."
>> If this were indeed the source of the problem, a number of
>> other tests
Branko Čibej wrote:
> The object lifetime and implicit close are very well defined indeed in
> CPython, which we use. We don't use "modern Pythons on other virtual
> machines."
> If this were indeed the source of the problem, a number of
> other tests would be failing randomly on that bot, and else
Branko Čibej wrote on Thu, 14 Jun 2018 04:04 +0200:
> ... on the other hand, making this suggested change won't hurt, as long
> as our required Python version for tests supports the 'with' statement,
> which I believe it does. In fact we already use the 'with' statement in
> our test suite.
Since
On 14.06.2018 04:04, Branko Čibej wrote:
> So, long story short ... changing all the open().write() statements to
> the 'with' form should at least remove one possible source of bugs.
We also use open().read() a lot, but that should not have timing
problems since it doesn't modify the file.
-- Br
On 13.06.2018 16:31, Julian Foad wrote:
> Branko Čibej wrote:
>> On 12.06.2018 13:00, Julian Foad wrote:
>>> Branko Čibej wrote:
https://ci.apache.org/builders/svn-x64-macosx-apr1.3-nothread/builds/3416/steps/Test%20ra_local%2Bfsfs/logs/faillog
>>> I should have a chance to debug this on
Branko Čibej wrote:
> On 12.06.2018 13:00, Julian Foad wrote:
>> Branko Čibej wrote:
>>> https://ci.apache.org/builders/svn-x64-macosx-apr1.3-nothread/builds/3416/steps/Test%20ra_local%2Bfsfs/logs/faillog
>>>
>> I should have a chance to debug this on a Mac today or tomorrow.
>
> The good news is
On 12.06.2018 13:00, Julian Foad wrote:
> Branko Čibej wrote:
>> https://ci.apache.org/builders/svn-x64-macosx-apr1.3-nothread/builds/3416/steps/Test%20ra_local%2Bfsfs/logs/faillog
>>
>> With the file contents now being printed in the test log, we can see how
>> the test is failing. What's worrying
Branko Čibej wrote:
> https://ci.apache.org/builders/svn-x64-macosx-apr1.3-nothread/builds/3416/steps/Test%20ra_local%2Bfsfs/logs/faillog
>
> With the file contents now being printed in the test log, we can see how
> the test is failing. What's worrying is that we don't see this failure
> either o
18 matches
Mail list logo
