RE: mod_dav_svn not XML-escaping hook error messages

> -Original Message- > From: Jon Foster [mailto:jon.fos...@cabot.co.uk] > Sent: vrijdag 18 december 2009 12:52 > To: Philip Martin; Ivan Zhakov > Cc: Julian Foad; dev@subversion.apache.org > Subject: RE: mod_dav_svn not XML-escaping hook error messages > > Hi,

RE: mod_dav_svn not XML-escaping hook error messages

Hi, I got the "svn: XML data was not well-formed" using Cygwin's standard SVN client: > svn, version 1.6.5 (r38866) >compiled Aug 26 2009, 13:50:17 > > Copyright (C) 2000-2009 CollabNet. > Subversion is open source software, see http://subversion.tigris.org/ > This product includes software

Re: mod_dav_svn not XML-escaping hook error messages

Ivan Zhakov writes: >> That's not the error Jon reported: he saw an "invalid XML" error. Why >> the difference? >> > Probably he is using serf instead of neon. No, serf reports success even though the server hasn't set the property. $ ../../../subversion/svn/svn --password rayjandom ps -r0 --re

Re: mod_dav_svn not XML-escaping hook error messages

Julian Foad writes: >> > > My test (the test patch that I posted a couple of messages back in this > thread), running trunk without any patch to fix the bug, is producing: > > EXPECTED STDERR: > svn: post-revprop-change hook failed (exit

Re: mod_dav_svn not XML-escaping hook error messages

On Fri, Dec 18, 2009 at 2:36 AM, Julian Foad wrote: >> > > My test (the test patch that I posted a couple of messages back in this > thread), running trunk without any patch to fix the bug, is producing: > > EXPECTED STDERR: > svn: post-re

Re: mod_dav_svn not XML-escaping hook error messages

> My test (the test patch that I posted a couple of messages back in this thread), running trunk without any patch to fix the bug, is producing: EXPECTED STDERR: svn: post-revprop-change hook failed (exit code 1) with output: post-revprop

Re: mod_dav_svn not XML-escaping hook error messages

Philip Martin wrote: > Julian Foad writes: > > > I wrote one myself. Attached. I confirmed the bug, but I am having > > trouble testing my test. It may be to do with the test suite not quite > > properly supporting a build in a separate directory. > > mod_dav_svn and the revprop hooks have a few

Re: mod_dav_svn not XML-escaping hook error messages

Julian Foad writes: > I wrote one myself. Attached. I confirmed the bug, but I am having > trouble testing my test. It may be to do with the test suite not quite > properly supporting a build in a separate directory. mod_dav_svn and the revprop hooks have a few problems: http://subversion.tigri

Re: mod_dav_svn not XML-escaping hook error messages

On Mon, 2009-12-14, I (Julian Foad) wrote: > Jon Foster wrote: > > It seems that mod_dav_svn doesn't escape special XML characters like > > "<" and ">" in the error messages from hook scripts. This causes > > corrupt XML to be sent across the wire. Here's a Wireshark capture > > of the response t

Re: mod_dav_svn not XML-escaping hook error messages

Jon Foster wrote: > I'd like to report a problem with mod_dav_svn and repository > hooks. I had a bug in my post-revprop-change script, but all I > saw was: > > > $ svn propedit --revprop -r 19 svn:log > > svn: DAV request failed; it's possible that the repository's > > pre-revprop-change hook ei