Re: log --search test failures on trunk and 1.8.x

2013-04-24 Thread Justin Erenkrantz
On Wed, Apr 24, 2013 at 1:34 AM, Branko Čibej wrote: > If you consider all this, the easiest approach by far might be to simply > add a Lucene index of all log messages to the server, then you can and > any number of bells and whistles including language-specific stemming. > I'd consider that a

Re: log --search test failures on trunk and 1.8.x

2013-04-23 Thread Branko Čibej
On 23.04.2013 14:51, Stefan Sperling wrote: > On Tue, Apr 23, 2013 at 02:27:08PM +0200, Branko Čibej wrote: >> You're missing the point. tolower() works on individual characters, not >> whole strings; so it in general /cannot/ do correct locale-specific > Do you really mean characters, or bytes? >

Re: log --search test failures on trunk and 1.8.x

2013-04-23 Thread Stefan Sperling
On Tue, Apr 23, 2013 at 02:27:08PM +0200, Branko Čibej wrote: > You're missing the point. tolower() works on individual characters, not > whole strings; so it in general /cannot/ do correct locale-specific Do you really mean characters, or bytes? It sounds like you mean bytes. tolower() works on i

Re: log --search test failures on trunk and 1.8.x

2013-04-23 Thread Branko Čibej
On 23.04.2013 08:53, Stefan Sperling wrote: > On Mon, Apr 22, 2013 at 01:13:43PM +0200, Branko Čibej wrote: >> On 22.04.2013 12:59, Bert Huijben wrote: >>> The assertion shows a design problem which we should handle for future >>> compatibility and you suggest just adding some bandages to patch/hi

Re: log --search test failures on trunk and 1.8.x

2013-04-22 Thread Stefan Sperling
On Mon, Apr 22, 2013 at 01:13:43PM +0200, Branko Čibej wrote: > On 22.04.2013 12:59, Bert Huijben wrote: > > The assertion shows a design problem which we should handle for future > > compatibility and you suggest just adding some bandages to patch/hide the > > test failure? > > > > The current c

Re: log --search test failures on trunk and 1.8.x

2013-04-22 Thread Branko Čibej
april 2013 00:08 >>>> To: Ivan Zhakov >>>> Cc: Branko Čibej; Bert Huijben; dev@subversion.apache.org >>>> Subject: Re: log --search test failures on trunk and 1.8.x >>>> >>>> On Sun, Apr 21, 2013 at 07:11:14PM +0400, Ivan Zhakov wrote: &

RE: log --search test failures on trunk and 1.8.x

2013-04-22 Thread Bert Huijben
> -Original Message- > From: 'Stefan Sperling' [mailto:s...@elego.de] > Sent: maandag 22 april 2013 11:46 > To: Bert Huijben > Cc: 'Ivan Zhakov'; 'Branko Čibej'; dev@subversion.apache.org > Subject: Re: log --search test failures on trunk a

Re: log --search test failures on trunk and 1.8.x

2013-04-22 Thread 'Stefan Sperling'
> Subject: Re: log --search test failures on trunk and 1.8.x > > > > On Sun, Apr 21, 2013 at 07:11:14PM +0400, Ivan Zhakov wrote: > > > So I propose the following plan: > > > 1. Make 'log --search" case-sensitive in trunk and 1.8.x. > > > 2. Merge

RE: log --search test failures on trunk and 1.8.x

2013-04-22 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: maandag 22 april 2013 00:08 > To: Ivan Zhakov > Cc: Branko Čibej; Bert Huijben; dev@subversion.apache.org > Subject: Re: log --search test failures on trunk and 1.8.x > > On Sun, Apr 21,

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Stefan Sperling
On Sun, Apr 21, 2013 at 07:11:14PM +0400, Ivan Zhakov wrote: > So I propose the following plan: > 1. Make 'log --search" case-sensitive in trunk and 1.8.x. > 2. Merge utf8proc stuff to trunk > 3. Implement svn_utf__casefold() using utf8proc > 4. Implement 'log --isearch' using No --isearch please.

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Mattias Engdegård
21 apr 2013 kl. 20.07 skrev Branko Čibej: Yes, the obvious ones are German (ß == SS) equivalence and turkic (i == İ) and (ı == I) equivalences (and that's aready three characters); but then in French, lowercase accented letters are equivalent to uppercase unaccented letters, whereas for exam

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Ivan Zhakov
On Sun, Apr 21, 2013 at 10:50 PM, Bert Huijben wrote: > Note that Unicode 3.2 (where these links point to) is over 10 years old. The > current version is 6.2... and things haven’t got easier with newer versions. > Good point. But it seems there is no big difference in this area. > A different rou

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Bert Huijben
Note that Unicode 3.2 (where these links point to) is over 10 years old. The current version is 6.2... and things haven’t got easier with newer versions. A different route would be to convert the characters from our utf-8 to the native platform encoding (using our existing apis for that) and th

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Ivan Zhakov
On Sun, Apr 21, 2013 at 10:07 PM, Branko Čibej wrote: > On 21.04.2013 17:11, Ivan Zhakov wrote: >> On Sun, Apr 21, 2013 at 4:48 PM, Branko Čibej wrote: >>> On 21.04.2013 14:05, Stefan Sperling wrote: On Sun, Apr 21, 2013 at 01:53:43PM +0200, Bert Huijben wrote: > I'd rather pull the case

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Branko Čibej
On 21.04.2013 17:11, Ivan Zhakov wrote: > On Sun, Apr 21, 2013 at 4:48 PM, Branko Čibej wrote: >> On 21.04.2013 14:05, Stefan Sperling wrote: >>> On Sun, Apr 21, 2013 at 01:53:43PM +0200, Bert Huijben wrote: I'd rather pull the case insensitive search part of this new in 1.8 search feat

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Branko Čibej
On 21.04.2013 15:37, Bert Huijben wrote: > >> -Original Message- >> From: Branko Čibej [mailto:br...@wandisco.com] >> Sent: zondag 21 april 2013 14:48 >> To: dev@subversion.apache.org >> Subject: Re: log --search test failures on trunk and 1.8.x >>

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Ivan Zhakov
On Sun, Apr 21, 2013 at 4:48 PM, Branko Čibej wrote: > On 21.04.2013 14:05, Stefan Sperling wrote: >> On Sun, Apr 21, 2013 at 01:53:43PM +0200, Bert Huijben wrote: >>> I'd rather pull the case insensitive search part of this new in 1.8 search >>> feature and do it right in 1.9. >> What's the issu

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Ivan Zhakov
On Sun, Apr 21, 2013 at 4:05 PM, Stefan Sperling wrote: > On Sun, Apr 21, 2013 at 01:53:43PM +0200, Bert Huijben wrote: >> I'd rather pull the case insensitive search part of this new in 1.8 search >> feature and do it right in 1.9. > > What's the issue with the current implementation apart from

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Justin Erenkrantz
On Sun, Apr 21, 2013 at 9:37 AM, Bert Huijben wrote: > Do we want case folding (or at least case variant compare) support in our > libraries for 1.8? > No. > Or is this 1.9+ scope? > Yes. =) My $.02. -- justin

RE: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: zondag 21 april 2013 14:48 > To: dev@subversion.apache.org > Subject: Re: log --search test failures on trunk and 1.8.x > > On 21.04.2013 14:05, Stefan Sperling wrote: > > On Sun,

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Branko Čibej
On 21.04.2013 14:05, Stefan Sperling wrote: > On Sun, Apr 21, 2013 at 01:53:43PM +0200, Bert Huijben wrote: >> I'd rather pull the case insensitive search part of this new in 1.8 search >> feature and do it right in 1.9. > What's the issue with the current implementation apart from the > test fail

RE: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: zondag 21 april 2013 14:05 > To: Bert Huijben > Cc: 'Branko Čibej'; dev@subversion.apache.org > Subject: Re: log --search test failures on trunk and 1.8.x > > On Sun, Apr

Re: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Stefan Sperling
On Sun, Apr 21, 2013 at 01:53:43PM +0200, Bert Huijben wrote: > I'd rather pull the case insensitive search part of this new in 1.8 search > feature and do it right in 1.9. What's the issue with the current implementation apart from the test failures on Windows? The behaviour of 'svn log --searc

RE: log --search test failures on trunk and 1.8.x

2013-04-21 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: zaterdag 20 april 2013 18:40 > To: dev@subversion.apache.org > Subject: Re: log --search test failures on trunk and 1.8.x > > On 20.04.2013 18:30, Ivan Zhakov wrote: > > On Sat, Ap

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Branko Čibej
On 20.04.2013 18:30, Ivan Zhakov wrote: > On Sat, Apr 20, 2013 at 8:04 PM, Ivan Zhakov wrote: >> On Sat, Apr 20, 2013 at 7:54 PM, Branko Čibej wrote: >>> On 20.04.2013 17:42, Stefan Sperling wrote: On Sat, Apr 20, 2013 at 07:26:06PM +0400, Ivan Zhakov wrote: > On Sat, Apr 20, 2013 at 2:2

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Ivan Zhakov
On Sat, Apr 20, 2013 at 8:04 PM, Ivan Zhakov wrote: > On Sat, Apr 20, 2013 at 7:54 PM, Branko Čibej wrote: >> On 20.04.2013 17:42, Stefan Sperling wrote: >>> On Sat, Apr 20, 2013 at 07:26:06PM +0400, Ivan Zhakov wrote: On Sat, Apr 20, 2013 at 2:27 PM, Stefan Sperling wrote: > How is low

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Ivan Zhakov
On Sat, Apr 20, 2013 at 7:54 PM, Branko Čibej wrote: > On 20.04.2013 17:42, Stefan Sperling wrote: >> On Sat, Apr 20, 2013 at 07:26:06PM +0400, Ivan Zhakov wrote: >>> On Sat, Apr 20, 2013 at 2:27 PM, Stefan Sperling wrote: How is lower-casing a multi-byte UTF-8 character going to help?

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Branko Čibej
On 20.04.2013 17:42, Stefan Sperling wrote: > On Sat, Apr 20, 2013 at 07:26:06PM +0400, Ivan Zhakov wrote: >> On Sat, Apr 20, 2013 at 2:27 PM, Stefan Sperling wrote: >>> How is lower-casing a multi-byte UTF-8 character going to help? >>> Won't the lower-case equivalent still be a multibyte charact

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Stefan Sperling
On Sat, Apr 20, 2013 at 07:26:06PM +0400, Ivan Zhakov wrote: > On Sat, Apr 20, 2013 at 2:27 PM, Stefan Sperling wrote: > > How is lower-casing a multi-byte UTF-8 character going to help? > > Won't the lower-case equivalent still be a multibyte character > > and trigger the overflow check in Visual

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Ivan Zhakov
On Sat, Apr 20, 2013 at 2:27 PM, Stefan Sperling wrote: > On Tue, Apr 16, 2013 at 02:15:17PM +0400, Ivan Zhakov wrote: >> Hi, >> >> I got following failures when running Debug build with VC 2010: >> FAIL: log_tests.py 40: test 'svn log -g --search' >> FAIL: log_tests.py 39: 'svn log --search' >>

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Stefan Sperling
On Sat, Apr 20, 2013 at 12:54:45PM +0200, Mattias Engdegård wrote: > 20 apr 2013 kl. 12.27 skrev Stefan Sperling: > > >>W: f:\dd\vctools\crt_bld\self_x86\crt\src\isctype.c(68) : Assertion > >>failed: (unsigned)(c + 1) <= 256 > >>]]] > > > >Seems like a bogus check to me. Is there a notion of debug

RE: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@apache.org] > Sent: zaterdag 20 april 2013 12:28 > To: Ivan Zhakov > Cc: Subversion Development > Subject: Re: log --search test failures on trunk and 1.8.x > > On Tue, Apr 16, 2013 at 02:15:17PM +0400, I

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Mattias Engdegård
20 apr 2013 kl. 12.27 skrev Stefan Sperling: W: f:\dd\vctools\crt_bld\self_x86\crt\src\isctype.c(68) : Assertion failed: (unsigned)(c + 1) <= 256 ]]] Seems like a bogus check to me. Is there a notion of debug vs. release builds in Visual Studio, and if so, does this happen in release mode buil

Re: log --search test failures on trunk and 1.8.x

2013-04-20 Thread Stefan Sperling
On Tue, Apr 16, 2013 at 02:15:17PM +0400, Ivan Zhakov wrote: > Hi, > > I got following failures when running Debug build with VC 2010: > FAIL: log_tests.py 40: test 'svn log -g --search' > FAIL: log_tests.py 39: 'svn log --search' > > They fail because of assertion in VC runtime: > [[[ > W: f:\