Re: fsfs: Segfault when rep line lists the all-zeroes checksum

2016-09-10 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Sat, Sep 10, 2016 at 20:50:28 +0200: > On 08.09.2016 18:51, Daniel Shahaf wrote: > >Stefan Fuhrmann wrote on Thu, Sep 08, 2016 at 17:51:47 +0200: > >>It appears that it might be very hard to get such data into the > >>repository because we use the same parser function in e.

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

2016-09-10 Thread Stefan Fuhrmann
On 08.09.2016 18:51, Daniel Shahaf wrote: Stefan Fuhrmann wrote on Thu, Sep 08, 2016 at 17:51:47 +0200: It appears that it might be very hard to get such data into the repository because we use the same parser function in e.g. the network layer and the editor drivers. Not sure we all for MD5s et

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

2016-09-08 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Sep 08, 2016 at 17:51:47 +0200: > It appears that it might be very hard to get such data into the > repository because we use the same parser function in e.g. the > network layer and the editor drivers. Not sure we all for MD5s etc. > to be missing in all relevant plac

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

2016-09-08 Thread Stefan Fuhrmann
On 29.08.2016 18:57, Daniel Shahaf wrote: When the "props:" line in a noderev lists an all-zeroes checksum, FSFS segfaults: [[[ % cat repro.sh #!/bin/sh rm -rf r wc svnadmin create r svn co -q file://`pwd`/r wc svn ps -q k v wc svn ci -qmm wc echo "First dump:" svnadmin dump -q r >/dev/null perl

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

2016-08-30 Thread 'Daniel Shahaf'
Bert Huijben wrote on Tue, Aug 30, 2016 at 12:42:14 +0200: > > > > -Original Message- > > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > > Sent: dinsdag 30 augustus 2016 03:06 > > To: Stefan Fuhrmann > > Cc: dev@subversion.apache.org > >

RE: fsfs: Segfault when rep line lists the all-zeroes checksum

2016-08-30 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > Sent: dinsdag 30 augustus 2016 03:06 > To: Stefan Fuhrmann > Cc: dev@subversion.apache.org > Subject: Re: fsfs: Segfault when rep line lists the all-zeroes checksum > > Stefan Fuhrm

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

2016-08-29 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Mon, Aug 29, 2016 at 22:10:07 +0200: > On 29.08.2016 18:57, Daniel Shahaf wrote: > >Line 801 sets CHECKSUM to NULL (as promised by svn_checksum_parse_hex()'s > >docstring), line 803 dereferences it unconditionally. > I vaguely remember that we use(d) all-0 checksums > as a

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

2016-08-29 Thread Stefan Fuhrmann
On 29.08.2016 18:57, Daniel Shahaf wrote: When the "props:" line in a noderev lists an all-zeroes checksum, FSFS segfaults: [[[ % cat repro.sh #!/bin/sh rm -rf r wc svnadmin create r svn co -q file://`pwd`/r wc svn ps -q k v wc svn ci -qmm wc echo "First dump:" svnadmin dump -q r >/dev/null perl