Re: Revprop packing implemented

2012-07-10 Thread Stefan Fuhrmann
On Tue, Jul 10, 2012 at 3:31 PM, Markus Schaber wrote: > Hi, Stefan, > > Von: Stefan Fuhrmann [mailto:stefan.fuhrm...@wandisco.com] > >> What's the performance penalty for modifying a packed rev props? From > what you've said, it sounds like packing works by fitting as many rev props > into a 64k

Re: Revprop packing implemented

2012-07-10 Thread Stefan Fuhrmann
On Tue, Jul 10, 2012 at 8:09 AM, Trent Nelson wrote: > Hi Stefan, > > > > This week I had one of my "how hard can it be?" moments > > and finally implemented revprop packing > > Lots of tools, like svnsync, store metadata in r0 rev props. Could this > rev be excluded from packing? > It is exclu

Re: Revprop packing implemented

2012-07-09 Thread Trent Nelson
Hi Stefan, > This week I had one of my "how hard can it be?" moments > and finally implemented revprop packing Lots of tools, like svnsync, store metadata in r0 rev props. Could this rev be excluded from packing? What's the performance penalty for modifying a packed rev props? From what you'v

Re: Revprop packing implemented

2012-07-09 Thread Stefan Fuhrmann
On Mon, Jul 9, 2012 at 11:40 AM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > On Mon, Jul 9, 2012 at 9:19 AM, Philip Martin < > philip.mar...@wandisco.com>wrote: > > > >> Stefan Fuhrmann writes: > >> > >> > This week I had one of my "how hard can it be?" moments > >> > and finally implem

Re: Revprop packing implemented

2012-07-09 Thread Philip Martin
Stefan Fuhrmann writes: > On Mon, Jul 9, 2012 at 9:19 AM, Philip Martin > wrote: > >> Stefan Fuhrmann writes: >> >> > This week I had one of my "how hard can it be?" moments >> > and finally implemented revprop packing (did that mainly >> > offline). It passes all tests and seems to work pretty

Re: Revprop packing implemented

2012-07-09 Thread Stefan Fuhrmann
On Mon, Jul 9, 2012 at 9:19 AM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > This week I had one of my "how hard can it be?" moments > > and finally implemented revprop packing (did that mainly > > offline). It passes all tests and seems to work pretty well. > > There are buildbot failure

Re: Revprop packing implemented

2012-07-09 Thread Philip Martin
Stefan Fuhrmann writes: > This week I had one of my "how hard can it be?" moments > and finally implemented revprop packing (did that mainly > offline). It passes all tests and seems to work pretty well. There are buildbot failures, I don't know if they are caused by the packing code. valgrind

RE: Revprop packing implemented

2012-07-08 Thread Bert Huijben
Hi Stefan, Why do you use a default of 64k for a revprop pack? Isn't something like 1MB a more sensible default? I would guess that for the 1000 revisions we usually pack that would fit in a single pack, while with 64K you only can get a few tens/hundreds revisions in a pack,

Re: Revprop packing implemented

2012-07-07 Thread Hyrum K Wright
On Fri, Jul 6, 2012 at 3:32 AM, Stefan Fuhrmann wrote: > Hi devs, > > This week I had one of my "how hard can it be?" moments > and finally implemented revprop packing (did that mainly > offline). It passes all tests and seems to work pretty well. > > It's design deviates from the existing revprop

Re: Revprop packing implemented

2012-07-06 Thread Blair Zajac
On 7/6/12 6:27 AM, C. Michael Pilato wrote: On 07/06/2012 04:32 AM, Stefan Fuhrmann wrote: Hi devs, This week I had one of my "how hard can it be?" moments and finally implemented revprop packing (did that mainly offline). It passes all tests and seems to work pretty well. Cool! [...] Sinc

Re: Revprop packing implemented

2012-07-06 Thread C. Michael Pilato
On 07/06/2012 04:32 AM, Stefan Fuhrmann wrote: > Hi devs, > > This week I had one of my "how hard can it be?" moments > and finally implemented revprop packing (did that mainly > offline). It passes all tests and seems to work pretty well. Cool! [...] > Since the new code will not be used unles