Re: Queries about rep cache: get_shared_rep()

2015-05-29 Thread Stefan Fuhrmann
On Wed, May 27, 2015 at 6:35 PM, Julian Foad wrote: > Stefan Fuhrmann wrote: >> Alright. I gave it a bit more thought now. >> >> Whenever we encounter this mismatch, something pretty >> bad likely happened to the repo - such as a failed restore >> attempt. In turn, we can expect those situations t

Re: Queries about rep cache: get_shared_rep()

2015-05-27 Thread Julian Foad
Stefan Fuhrmann wrote: > Alright. I gave it a bit more thought now. > > Whenever we encounter this mismatch, something pretty > bad likely happened to the repo - such as a failed restore > attempt. In turn, we can expect those situations to be > very rare - which means we can afford some disruption

Re: Queries about rep cache: get_shared_rep()

2015-05-27 Thread Stefan Fuhrmann
On Wed, May 27, 2015 at 1:11 PM, Julian Foad wrote: > Stefan Fuhrmann wrote: > > Julian Foad wrote: > >> @@ -2262,14 +2264,20 @@ get_shared_rep(representation_t **old_re > >> > >>/* A simple guard against general rep-cache induced corruption. */ > >>if ((*old_rep)->expanded_size != rep->e

Re: Queries about rep cache: get_shared_rep()

2015-05-27 Thread Julian Foad
Stefan Fuhrmann wrote: > Julian Foad wrote: >> + /* ### Would it be faster (and so better) to just try reading it, >> + and handle ENOENT, instead of first checking for presence? */ >>SVN_ERR(svn_io_check_path(file_name, &kind, scratch_pool)); >>if (kind == svn_node

Re: Queries about rep cache: get_shared_rep()

2015-05-27 Thread Stefan Fuhrmann
On Tue, May 26, 2015 at 11:15 PM, Julian Foad wrote: > Index: subversion/libsvn_fs_fs/transaction.c > === > --- subversion/libsvn_fs_fs/transaction.c(revision 1681856) > +++ subversion/libsvn_fs_fs/transaction.c(working copy)

Re: Queries about rep cache: get_shared_rep()

2015-05-27 Thread Julian Foad
Hi Bert. Bert Huijben wrote: > On Windows opening the file is sensitive to outside interactions and may > trigger a retry loop. [...] A filestat is +- a constant time operation that > doesn't have these problems. OK... > So this really depends on how common all cases are. If not existing or > po

RE: Queries about rep cache: get_shared_rep()

2015-05-26 Thread Bert Huijben
On Windows opening the file is sensitive to outside interactions and may trigger a retry loop. E.g. A virusscanber that scans every file before opening by hooking the OS. A filestat is +- a constant time operation that doesn't have these problems. So this really depends on how common all cases