Neels J Hofmeyr wrote:
> Matthew Bentham wrote:
>> On 18/02/2010 11:08, Matthew Bentham wrote:
>>> On 17/02/2010 18:40, Greg Stein wrote:
On Wed, Feb 17, 2010 at 12:22, Matthew Bentham
wrote:
> ...
> Revised patch attached fixes the unit test (and hopefully the
> indentation
Matthew Bentham wrote:
> On 18/02/2010 11:08, Matthew Bentham wrote:
>> On 17/02/2010 18:40, Greg Stein wrote:
>>> On Wed, Feb 17, 2010 at 12:22, Matthew Bentham
>>> wrote:
...
Revised patch attached fixes the unit test (and hopefully the
indentation,
if I've understood the st
On 18/02/2010 11:08, Matthew Bentham wrote:
On 17/02/2010 18:40, Greg Stein wrote:
On Wed, Feb 17, 2010 at 12:22, Matthew Bentham wrote:
...
Revised patch attached fixes the unit test (and hopefully the indentation,
if I've understood the style correctly), but I have no real instinct as to
wh
> -Original Message-
> From: Stefan Sperling [mailto:s...@elego.de]
> Sent: woensdag 17 februari 2010 19:30
> To: Matthew Bentham
> Cc: dev@subversion.apache.org
> Subject: Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from
> libsvn_client
>
> On Wed,
On 17/02/2010 18:40, Greg Stein wrote:
On Wed, Feb 17, 2010 at 12:22, Matthew Bentham wrote:
...
Revised patch attached fixes the unit test (and hopefully the indentation,
if I've understood the style correctly), but I have no real instinct as to
whether I should be modifying a libsvn_wc routin
On Wed, Feb 17, 2010 at 12:22, Matthew Bentham wrote:
>...
> Revised patch attached fixes the unit test (and hopefully the indentation,
> if I've understood the style correctly), but I have no real instinct as to
> whether I should be modifying a libsvn_wc routine in this way. Should I be
> able
On Wed, Feb 17, 2010 at 06:18:56PM +, Matthew Bentham wrote:
> Index: subversion/libsvn_wc/node.c
> ===
> --- subversion/libsvn_wc/node.c (revision 909397)
> +++ subversion/libsvn_wc/node.c (working copy)
> @@ -310,6 +3
On 17/02/2010 17:53, s...@stsp.name wrote:
To save a (probably negligible) bit of memory,
you could create an iterpool here...
I think you should use svn_dirent_is_child() rather than svn_uri_is_child()
here. The URI functions are for URLs, not local absolute paths.
[1] Which would mean that th
On Wed, Feb 17, 2010 at 05:22:13PM +, Matthew Bentham wrote:
> Index: subversion/libsvn_client/commit_util.c
> ===
> --- subversion/libsvn_client/commit_util.c(revision 909397)
> +++ subversion/libsvn_client/commit_util.c(w
On 15/02/2010 15:02, Philip Martin wrote:
Indentation is a bit off. I'll fix and commit when the regression tests
finish.
lock_tests.py 13 is failing:
I think the problem is that svn_wc__node_get_url doesn't work for
deleted nodes, it certainly has no code to scan the working tree for
deletio
> -Original Message-
> From: Matthew Bentham [mailto:mj...@artvps.com]
> Sent: dinsdag 16 februari 2010 12:03
> To: Philip Martin
> Cc: dev@subversion.apache.org
> Subject: Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from
> libsvn_client
>
> Philip Mart
Philip Martin wrote:
lock_tests.py 13 is failing:
Darn, I thought I had fixed that problem :-) But I now realise I was
confused between "lock_tests.py" and "locks-test.exe" (the latter
doesn't even test libsvn_client). A complete 'make check' is impossible
for me on cygwin, it takes about 4h
Philip Martin writes:
> Matthew Bentham writes:
>
>> wc-ng: work towards eliminating svn_wc_entry_t
>>
>> * subversion/libsvn_client/commit_util.c
>>(add_lock_token): Replace a use of svn_wc__maybe_get_entry with
>> use of svn_wc__node_get_*
>>
>> Patch by: Matthew Bentham
>> ]]]
>> Ind
Matthew Bentham writes:
> wc-ng: work towards eliminating svn_wc_entry_t
>
> * subversion/libsvn_client/commit_util.c
>(add_lock_token): Replace a use of svn_wc__maybe_get_entry with
> use of svn_wc__node_get_*
>
> Patch by: Matthew Bentham
> ]]]
> Index: subversion/libsvn_client/commit_
Greg Stein wrote:
For log messages, we also like to provide attribution, so at the end
of the above message you would have:
Patch by: Matthew Bentham
btw I think this is not properly explained by
http://subversion.apache.org/docs/community-guide/conventions.html#log-messages
or
http://subv
Matthew Bentham writes:
> How do you guys generally run an
> individual test or test program? It's implied in the documentation
> that the test programs support it, but does 'make check' have any
> options?
On Linux, if you build in the source directory
$ cd subversion/tests/cmdline
$ ./lock_t
Hyrum K. Wright wrote:
On Feb 12, 2010, at 8:10 AM, Greg Stein wrote:
On Fri, Feb 12, 2010 at 10:39, Matthew Bentham wrote:
Index: subversion/libsvn_client/commit_util.c
===
--- subversion/libsvn_client/commit_util.c (revisi
On Feb 12, 2010, at 8:10 AM, Greg Stein wrote:
> On Fri, Feb 12, 2010 at 10:39, Matthew Bentham wrote:
>> I understand from thread "WC-NG: How can we help with 1.7-readiness?" that
>> this sort of thing is helpful. I am a massive newbie, please forgive me if
>> I do something obviously wrong.
>
On Fri, Feb 12, 2010 at 10:39, Matthew Bentham wrote:
> I understand from thread "WC-NG: How can we help with 1.7-readiness?" that
> this sort of thing is helpful. I am a massive newbie, please forgive me if
> I do something obviously wrong.
Can't learn without trying! Thanks for jumping in :-)
19 matches
Mail list logo
