Re: [PATCH] Change error reporting for xlate problems

2013-07-14 Thread Daniel Shahaf
On Sun, Jul 14, 2013 at 04:55:16PM +, Daniel Shahaf wrote: > On Sun, Jul 14, 2013 at 02:06:02AM -0400, Justin Erenkrantz wrote: > > It's probably better to just check APR_HAS_XLATE and return an error in > > svnsync if that's 0...and let the string pass through unmodified - which is > > probabl

Re: [PATCH] Change error reporting for xlate problems

2013-07-14 Thread Daniel Shahaf
On Sun, Jul 14, 2013 at 02:06:02AM -0400, Justin Erenkrantz wrote: > On Sat, Jul 13, 2013 at 8:39 PM, Daniel Shahaf wrote: > > > It appears as soon as svn_utf_cstring_to_utf8() is called --- which is > > normally during argv parsing. The error happens even if the argv > > arguments are all ASCII

Re: [PATCH] Change error reporting for xlate problems

2013-07-14 Thread Stefan Sperling
On Sun, Jul 14, 2013 at 12:38:52PM +0200, Bert Huijben wrote: > > From: Stefan Sperling [mailto:s...@elego.de] > > Requiring iconv for svnsync is a good idea, we need it for the > > --source-prop-encoding option of 'svnsync sync'. > > Why do we need this for 'svnsync' in general? > > I would gues

RE: [PATCH] Change error reporting for xlate problems

2013-07-14 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: zondag 14 juli 2013 11:39 > To: Justin Erenkrantz > Cc: Daniel Shahaf; Subversion Development > Subject: Re: [PATCH] Change error reporting for xlate problems > > On Sun, Jul 14, 2013 at

Re: [PATCH] Change error reporting for xlate problems

2013-07-14 Thread Stefan Sperling
On Sun, Jul 14, 2013 at 02:06:02AM -0400, Justin Erenkrantz wrote: > On Sat, Jul 13, 2013 at 8:39 PM, Daniel Shahaf wrote: > > > It appears as soon as svn_utf_cstring_to_utf8() is called --- which is > > normally during argv parsing. The error happens even if the argv > > arguments are all ASCII

Re: [PATCH] Change error reporting for xlate problems

2013-07-13 Thread Justin Erenkrantz
On Sat, Jul 13, 2013 at 8:39 PM, Daniel Shahaf wrote: > It appears as soon as svn_utf_cstring_to_utf8() is called --- which is > normally during argv parsing. The error happens even if the argv > arguments are all ASCII, which effectively adds a new dependency on > apr_xlate_* even for people wh