Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2019-02-21 Thread Sergey Raevskiy
Great! I have tried to make a patch to fix #4672, but it didn't work right away. Going to look again later. On Mon, Feb 18, 2019 at 1:39 PM Julian Foad wrote: > > Thank you, Sergey! Committed and proposed for backport. > > A similar (but not the same) problem exists with copies in "svnrdump dum

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2019-02-18 Thread Julian Foad
Thank you, Sergey! Committed and proposed for backport. A similar (but not the same) problem exists with copies in "svnrdump dump": https://issues.apache.org/jira/browse/SVN-4672 "Fix svnrdump to handle subtree references" Would you be interested in investigating that one too? It would be good i

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2019-02-12 Thread Sergey Raevskiy
Hello! After some investigation I realized that PATH passed by repos layer to AUTHZ_FUNC is not guaranted to be canonical. In fact, when path is under copied directory (as in #4760) it does not contain leading slash. This causes ary_prefix_match() function to ignore those paths, since it require

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2019-02-08 Thread Julian Foad
Sergey Raevskiy wrote: > > Ping! Sergey or anyone, are you able to investigate this? > > Hello! > > Sorry for the late reply. I'm plannig to investigate this in short time. That's good to hear! Thank you. If you need any help, please ask here or in the #svn-dev IRC channel. I'm sure we'll be h

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2019-02-08 Thread Sergey Raevskiy
> Ping! Sergey or anyone, are you able to investigate this? Hello! Sorry for the late reply. I'm plannig to investigate this in short time. On Mon, Jan 28, 2019 at 8:09 PM Julian Foad wrote: > > Ping! Sergey or anyone, are you able to investigate this? > > > Julian Foad wrote on 2018-11-30: > >

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2019-01-28 Thread Julian Foad
Ping! Sergey or anyone, are you able to investigate this? Julian Foad wrote on 2018-11-30: > Hello Sergey! > > Your patch was filed as issue #4729 > https://issues.apache.org/jira/browse/SVN-4729 > and released in Subversion 1.10 > > https://subversion.apache.org/docs/release-notes/1.10

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2018-11-30 Thread Julian Foad
Hello Sergey! Your patch was filed as issue #4729 https://issues.apache.org/jira/browse/SVN-4729 and released in Subversion 1.10 https://subversion.apache.org/docs/release-notes/1.10.html#dump-include-exclude A user has reported a problem with this feature. https://issues.apache.org/

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-13 Thread Branko Čibej
On 13.10.2017 11:36, Julian Foad wrote: > We should update the JavaHL bindings for 'dump' accordingly. > > Here is a patch that begins that process. It is not finished: as noted > in the log message, at least I haven't implemented CreateJ:FSPath and > the callback should (probably) be moved into it

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-13 Thread Julian Foad
We should update the JavaHL bindings for 'dump' accordingly. Here is a patch that begins that process. It is not finished: as noted in the log message, at least I haven't implemented CreateJ:FSPath and the callback should (probably) be moved into its own file, and I have presumably made some m

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-13 Thread Julian Foad
Should we now add all the other options from svndumpfilter? --drop-empty-revs: Remove revisions emptied by filtering. --drop-all-empty-revs: Remove all empty revisions found in dumpstream except revision 0. --renumber-revs : Renumber revisi

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-13 Thread Julian Foad
maxin wrote: Thanks for the prompt response! I just compiled r1812050 and tested with my own repo, however, somehow the svndumpfilter command cannot remove the 'empty' revisions from the filtered dump file Please report a small test case that demonstrates the problem, with the exact comman

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-12 Thread maxin
Hi Julian, Thanks for the prompt response! I just compiled r1812050 and tested with my own repo, however, somehow the svndumpfilter command cannot remove the 'empty' revisions from the filtered dump file Maxin -- Sent from: http://subversion.1072662.n5.nabble.com/Subversion-Dev-f4725.html

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-12 Thread Julian Foad
Julian Foad wrote: Good follow-ups would be:   * update the help text to say: this functionality is equivalent to using authz exclusions, and unlike svndumpfilter, using these options does not break copies   * update the help text for "--pattern" to match svndumpfilter (I added an explanatio

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-12 Thread Julian Foad
Julian Foad wrote: Sergey Raevskiy wrote: I've attached a patch that adds '--include/--exclude' options to 'svnadmin dump'. These options work similarly to 'svndumpfilter include/exclude' but provide proper handling of 'copy from' paths. This is really important. I'm going to make some time t

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-12 Thread Julian Foad
Sergey Raevskiy wrote: I've attached a patch that adds '--include/--exclude' options to 'svnadmin dump'. These options work similarly to 'svndumpfilter include/exclude' but provide proper handling of 'copy from' paths. This is really important. I'm going to make some time to review it. - Julia

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2017-10-10 Thread maxin
I am wondering if there has been any progress on this. I just ran into the same problem. -- Sent from: http://subversion.1072662.n5.nabble.com/Subversion-Dev-f4725.html

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2016-10-28 Thread Julian Foad
On 12/10/16, Sergey Raevskiy wrote: I've attached a patch that adds '--include/--exclude' options to 'svnadmin dump'. These options work similarly to 'svndumpfilter include/exclude' but provide proper handling of 'copy from' paths. Thank you! As I'm sure you're aware, this feature has been want

Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2016-10-12 Thread Sergey Raevskiy
Hi Bert, thanks for your reply. The problem that I've described is not about revision numbers, it's about copied nodes. Suppose we have an repository 'repo' containing nodes '/A' and '/B', where '/B' (or some path under '/B') was create by copying of '/A' (or some path under '/A'). Now, if we ru

RE: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'

2016-10-12 Thread Bert Huijben
> -Original Message- > From: Sergey Raevskiy [mailto:sergey.raevs...@visualsvn.com] > Sent: woensdag 12 oktober 2016 12:44 > To: Subversion Development > Subject: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump' > > Hi! > > I've attached a patch that adds '--include/-