Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-12-31 Thread Daniel Gruno
On 12/31/24 02:31, Greg Stein wrote: My recommendation would be to patch the asfpy package to understand the svnpubsub protocol (basically: \0 instead of \n). The asfpy.pubsub package is what Infra uses for all of its clients to listen to the official ASF pubsub service. It's fully async. As

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-12-30 Thread Greg Stein
My recommendation would be to patch the asfpy package to understand the svnpubsub protocol (basically: \0 instead of \n). The asfpy.pubsub package is what Infra uses for all of its clients to listen to the official ASF pubsub service. It's fully async. Check out the pubsub.py module in https://git

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-12-22 Thread Daniel Sahlberg
Thank you very much for the review! I'll answer inline below. Den tis 3 dec. 2024 kl 22:31 skrev Jun Omae : > Hi, > > On 2024/11/29 6:47, Daniel Sahlberg wrote: > [snip] > > > > The next step will be to rewrite for asyncio, but I'd like to have a > functional client as a baseline. > > > > Chee

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-12-18 Thread Daniel Gruno
pypubsub uses a slightly different protocol than svnpubsub, so you shouldn't really be testing against it (unless you want to support both protocols, in which case that'd be awesome - https://infra.apache.org/pypubsub.html can help you there). The svnpubsub service we have is still located at s

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-12-03 Thread Jun Omae
Hi, On 2024/11/29 6:47, Daniel Sahlberg wrote: > I took some time today to try to figure out how it all connects. I made a > minimal client which I believe should be correct: > [[[ > def cc(o): > print("commit " + repr(o)) > > def ec(url, type, o): > print("event on " + repr(url) + ": " + re

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2024-11-28 Thread Daniel Sahlberg
On 2023/07/03 09:37:01 Yasuhito FUTATSUKI wrote: > Hi, > > On 2023/07/03 3:17, James McCoy wrote: > > Hi all, > > > > Python 3.6 deprecated the asyncore and asynchat modules in favor of the > > asyncio module. Per [PEP 594], that means that the modules > > will be removed in Python 3.12, thus br

Re: Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2023-07-03 Thread Yasuhito FUTATSUKI
Hi, On 2023/07/03 3:17, James McCoy wrote: Hi all, Python 3.6 deprecated the asyncore and asynchat modules in favor of the asyncio module. Per [PEP 594], that means that the modules will be removed in Python 3.12, thus breaking svnpubsub/client.py. Is there someone familiar enough with these

Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2023-07-02 Thread James McCoy
Hi all, Python 3.6 deprecated the asyncore and asynchat modules in favor of the asyncio module. Per [PEP 594], that means that the modules will be removed in Python 3.12, thus breaking svnpubsub/client.py. Is there someone familiar enough with these Python modules to work on updating svnpubsub?