Re: Problems running testsuite on Windows with Python 3

2020-05-12 Thread Yasuhito FUTATSUKI
On 2020/05/09 6:43, Johan Corveleyn wrote: > On Fri, May 8, 2020 at 2:49 PM Jun Omae wrote: >> >> Hi, >> >> On 2020/05/07 16:17, Johan Corveleyn wrote: >>> There is still the issue of PYTHONLEGACYWINDOWSSTDIO that is very much >>> blocking for anyone running the testsuite on Windows with Python 3.

Re: Problems running testsuite on Windows with Python 3

2020-05-08 Thread Johan Corveleyn
On Fri, May 8, 2020 at 2:49 PM Jun Omae wrote: > > Hi, > > On 2020/05/07 16:17, Johan Corveleyn wrote: > > There is still the issue of PYTHONLEGACYWINDOWSSTDIO that is very much > > blocking for anyone running the testsuite on Windows with Python 3. > > Worst case, we might have to simply document

Re: Problems running testsuite on Windows with Python 3

2020-05-08 Thread Jun Omae
Hi, On 2020/05/07 16:17, Johan Corveleyn wrote: There is still the issue of PYTHONLEGACYWINDOWSSTDIO that is very much blocking for anyone running the testsuite on Windows with Python 3. Worst case, we might have to simply document it, and perhaps emit a warning if it's not set? Or can we simply

Re: Problems running testsuite on Windows with Python 3

2020-05-07 Thread Daniel Shahaf
Johan Corveleyn wrote on Thu, 07 May 2020 09:17 +0200: > We should probably also propose all of your latest fixes for backport > in /branches/1.14.x/STATUS, so they can be included in 1.14.1 (and > interested people can already see that the "known testsuite issues on > Windows" are being addressed)

Re: Problems running testsuite on Windows with Python 3

2020-05-07 Thread Yasuhito FUTATSUKI
On 2020/05/07 16:17, Johan Corveleyn wrote: > On Wed, May 6, 2020 at 10:36 AM Yasuhito FUTATSUKI > wrote: >> >> On 2020/05/04 4:49, Johan Corveleyn wrote: >>> On Sun, May 3, 2020 at 6:23 PM Yasuhito FUTATSUKI >>> wrote: On 2020/05/03 10:02, Johan Corveleyn wrote: > On Fri, May 1,

Re: Problems running testsuite on Windows with Python 3

2020-05-07 Thread Johan Corveleyn
On Wed, May 6, 2020 at 10:36 AM Yasuhito FUTATSUKI wrote: > > On 2020/05/04 4:49, Johan Corveleyn wrote: > > On Sun, May 3, 2020 at 6:23 PM Yasuhito FUTATSUKI > > wrote: > >> > >> On 2020/05/03 10:02, Johan Corveleyn wrote: > >>> On Fri, May 1, 2020 at 7:46 PM Yasuhito FUTATSUKI > >>> wrote: >

Re: Problems running testsuite on Windows with Python 3

2020-05-06 Thread Yasuhito FUTATSUKI
On 2020/05/04 4:49, Johan Corveleyn wrote: > On Sun, May 3, 2020 at 6:23 PM Yasuhito FUTATSUKI wrote: >> >> On 2020/05/03 10:02, Johan Corveleyn wrote: >>> On Fri, May 1, 2020 at 7:46 PM Yasuhito FUTATSUKI >>> wrote: On 2020/04/23 2:05, Yasuhito FUTATSUKI wrote: It seems followin

Re: Problems running testsuite on Windows with Python 3

2020-05-03 Thread Johan Corveleyn
On Sun, May 3, 2020 at 6:23 PM Yasuhito FUTATSUKI wrote: > > On 2020/05/03 10:02, Johan Corveleyn wrote: > > On Fri, May 1, 2020 at 7:46 PM Yasuhito FUTATSUKI > > wrote: > >> > >> On 2020/04/23 2:05, Yasuhito FUTATSUKI wrote: > >>> On 2020/04/22 23:04, Johan Corveleyn wrote: > On Wed, Apr 2

Re: Problems running testsuite on Windows with Python 3

2020-05-03 Thread Yasuhito FUTATSUKI
On 2020/05/03 10:02, Johan Corveleyn wrote: > On Fri, May 1, 2020 at 7:46 PM Yasuhito FUTATSUKI wrote: >> >> On 2020/04/23 2:05, Yasuhito FUTATSUKI wrote: >>> On 2020/04/22 23:04, Johan Corveleyn wrote: On Wed, Apr 22, 2020 at 3:50 PM Yasuhito FUTATSUKI wrote: >>> > ... and what is

Re: [PATCH] fix svnrdump_tests.py on Windows with Python 3 (Re: Problems running testsuite on Windows with Python 3)

2020-05-03 Thread Yasuhito FUTATSUKI
On 2020/05/03 10:04, Johan Corveleyn wrote: > On Sat, May 2, 2020 at 7:37 PM Yasuhito FUTATSUKI wrote: >> >> On 2020/04/19 3:26, Johan Corveleyn wrote: >> >>> This is the list of tests that still fail (66): >> >>> FAIL: svnrdump_tests.py 1: dump: standard sbox repos >> ... >>> FAIL: svnrdump_t

Re: [PATCH] fix svnrdump_tests.py on Windows with Python 3 (Re: Problems running testsuite on Windows with Python 3)

2020-05-02 Thread Johan Corveleyn
On Sat, May 2, 2020 at 7:37 PM Yasuhito FUTATSUKI wrote: > > On 2020/04/19 3:26, Johan Corveleyn wrote: > > > This is the list of tests that still fail (66): > > > FAIL: svnrdump_tests.py 1: dump: standard sbox repos > ... > > FAIL: svnrdump_tests.py 57: load: invalid svn:date revprop in r1 >

Re: Problems running testsuite on Windows with Python 3

2020-05-02 Thread Johan Corveleyn
On Fri, May 1, 2020 at 7:46 PM Yasuhito FUTATSUKI wrote: > > On 2020/04/23 2:05, Yasuhito FUTATSUKI wrote: > > On 2020/04/22 23:04, Johan Corveleyn wrote: > >> On Wed, Apr 22, 2020 at 3:50 PM Yasuhito FUTATSUKI > >> wrote: > > > >>> ... and what is worse, at least > >>> > FAIL: merge_tests

[PATCH] fix svnrdump_tests.py on Windows with Python 3 (Re: Problems running testsuite on Windows with Python 3)

2020-05-02 Thread Yasuhito FUTATSUKI
On 2020/04/19 3:26, Johan Corveleyn wrote: > This is the list of tests that still fail (66): > FAIL: svnrdump_tests.py 1: dump: standard sbox repos ... > FAIL: svnrdump_tests.py 57: load: invalid svn:date revprop in r1 These failures in svnrdump_tests.py seems to be caused in EOL character

Re: Problems running testsuite on Windows with Python 3

2020-05-01 Thread Yasuhito FUTATSUKI
On 2020/04/23 2:05, Yasuhito FUTATSUKI wrote: > On 2020/04/22 23:04, Johan Corveleyn wrote: >> On Wed, Apr 22, 2020 at 3:50 PM Yasuhito FUTATSUKI >> wrote: > >>> ... and what is worse, at least >>> FAIL: merge_tests.py 34: conflict markers should match the file's eol style >>> >>> t

Re: Problems running testsuite on Windows with Python 3

2020-04-22 Thread Yasuhito FUTATSUKI
On 2020/04/23 5:53, Johan Corveleyn wrote: > On Tue, Apr 21, 2020 at 5:14 PM Yasuhito FUTATSUKI > wrote: > >> On 2020/04/21 4:03, Johan Corveleyn wrote: >>> On Mon, Apr 20, 2020 at 2:16 PM Yasuhito FUTATSUKI >> >> >> So I wrote a patch for testing (not for commit. it is need to brush up >>

Re: Problems running testsuite on Windows with Python 3

2020-04-22 Thread Johan Corveleyn
On Tue, Apr 21, 2020 at 5:14 PM Yasuhito FUTATSUKI wrote: > On 2020/04/21 4:03, Johan Corveleyn wrote: > > On Mon, Apr 20, 2020 at 2:16 PM Yasuhito FUTATSUKI > > > > >> So I wrote a patch for testing (not for commit. it is need to brush up > >> even if it can work). > >> > >> At least it should

Re: Problems running testsuite on Windows with Python 3

2020-04-22 Thread Yasuhito FUTATSUKI
On 2020/04/22 23:04, Johan Corveleyn wrote: > On Wed, Apr 22, 2020 at 3:50 PM Yasuhito FUTATSUKI > wrote: >> ... and what is worse, at least >> >>> FAIL: merge_tests.py 34: conflict markers should match the file's eol style >> >> this one seems to be broken even with Python 2.7, on Windows. >>

Re: Problems running testsuite on Windows with Python 3

2020-04-22 Thread Johan Corveleyn
On Wed, Apr 22, 2020 at 3:50 PM Yasuhito FUTATSUKI wrote: > > On 2020/04/22 22:18, Nathan Hartman wrote: > > > I'd like to add something along these lines to the Release Notes, > > under "Known Issues in the Release." > > > > Please check for accuracy: > > > > (I haven't tested this myself -- have

Re: Problems running testsuite on Windows with Python 3

2020-04-22 Thread Yasuhito FUTATSUKI
On 2020/04/22 22:18, Nathan Hartman wrote: > I'd like to add something along these lines to the Release Notes, > under "Known Issues in the Release." > > Please check for accuracy: > > (I haven't tested this myself -- haven't reached this point yet in my > Windows setup!) > > [[[ > > When usi

Re: Problems running testsuite on Windows with Python 3

2020-04-22 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 22 Apr 2020 13:18 +00:00: > Please check for accuracy: > > (I haven't tested this myself -- haven't reached this point yet in my > Windows setup!) > I don't have a Windows build either, but a few suggested edits: > [[[ > > When using Python 3.6 or higher on Windows

Re: Problems running testsuite on Windows with Python 3

2020-04-22 Thread Nathan Hartman
Earlier, in the thread "schedule for 1.14.0 release"... On Wed, Apr 22, 2020 at 8:15 AM Johan Corveleyn wrote: > In fact, there is very little pressure on getting this in 1.14.0 GA, > because (1) it only affects testsuite-runners on Windows, of which > there are extremely few :-), and (2) the wor

Re: Problems running testsuite on Windows with Python 3

2020-04-21 Thread Nathan Hartman
On Tue, Apr 21, 2020 at 11:14 AM Yasuhito FUTATSUKI wrote: > > Perfect! Works well on Windows, with Py 2.7, 3.7 and 3.8.2, with or without > > the envvar defined. > > Thanks! > > Thank you! > > Then I update the patch to prepare to commit. However I don't have > confidence function name, variable

Re: Problems running testsuite on Windows with Python 3

2020-04-21 Thread Yasuhito FUTATSUKI
On 2020/04/21 4:03, Johan Corveleyn wrote: > On Mon, Apr 20, 2020 at 2:16 PM Yasuhito FUTATSUKI >> So I wrote a patch for testing (not for commit. it is need to brush up >> even if it can work). >> >> At least it should work (no regression) on Python 2.7, Python 3 with >> and without PYTHONLEGA

Re: Problems running testsuite on Windows with Python 3

2020-04-20 Thread Johan Corveleyn
On Mon, Apr 20, 2020 at 2:16 PM Yasuhito FUTATSUKI wrote: > On 2020/04/20 9:13, Branko Čibej wrote: > > On 19.04.2020 23:58, Yasuhito FUTATSUKI wrote: > > > > >> On 2020/04/19 22:53, Branko Čibej wrote: > >>> On 19.04.2020 14:47, Johan Corveleyn wrote: > Would you also have an idea on how t

Re: Problems running testsuite on Windows with Python 3

2020-04-20 Thread Branko Čibej
On 20.04.2020 14:13, Yasuhito FUTATSUKI wrote: > On 2020/04/20 9:13, Branko Čibej wrote: >> On 19.04.2020 23:58, Yasuhito FUTATSUKI wrote: > > >>> On 2020/04/19 22:53, Branko Čibej wrote: On 19.04.2020 14:47, Johan Corveleyn wrote: > Would you also have an idea on how to fix the PYTHONLEG

Re: Problems running testsuite on Windows with Python 3

2020-04-20 Thread Yasuhito FUTATSUKI
On 2020/04/20 9:13, Branko Čibej wrote: > On 19.04.2020 23:58, Yasuhito FUTATSUKI wrote: >> On 2020/04/19 22:53, Branko Čibej wrote: >>> On 19.04.2020 14:47, Johan Corveleyn wrote: Would you also have an idea on how to fix the PYTHONLEGACYWINDOWSSTDIO issue? I mean: would it ever

Re: Problems running testsuite on Windows with Python 3

2020-04-19 Thread Branko Čibej
On 19.04.2020 23:58, Yasuhito FUTATSUKI wrote: > I've commited the patch for blame_tests.py in 1876734. Thank you. > > On 2020/04/19 22:53, Branko Čibej wrote: >> On 19.04.2020 14:47, Johan Corveleyn wrote: >>> Would you also have an idea on how to fix the PYTHONLEGACYWINDOWSSTDIO >>> issue? >>> I

Re: Problems running testsuite on Windows with Python 3

2020-04-19 Thread Yasuhito FUTATSUKI
I've commited the patch for blame_tests.py in 1876734. Thank you. On 2020/04/19 22:53, Branko Čibej wrote: > On 19.04.2020 14:47, Johan Corveleyn wrote: >> Would you also have an idea on how to fix the PYTHONLEGACYWINDOWSSTDIO issue? >> I mean: would it ever be possible to run the testsuite witho

Re: Problems running testsuite on Windows with Python 3

2020-04-19 Thread Branko Čibej
On 19.04.2020 14:47, Johan Corveleyn wrote: > On Sun, Apr 19, 2020 at 10:49 AM Yasuhito FUTATSUKI > wrote: >> On 2020/04/19 3:26, Johan Corveleyn wrote: >>> On Fri, Apr 17, 2020 at 11:21 PM Yasuhito FUTATSUKI >>> wrote: On 2020/04/17 5:53, Johan Corveleyn wrote: > Running the test

Re: Problems running testsuite on Windows with Python 3

2020-04-19 Thread Johan Corveleyn
On Sun, Apr 19, 2020 at 10:49 AM Yasuhito FUTATSUKI wrote: > > On 2020/04/19 3:26, Johan Corveleyn wrote: > > On Fri, Apr 17, 2020 at 11:21 PM Yasuhito FUTATSUKI > > wrote: > >> > >> On 2020/04/17 5:53, Johan Corveleyn wrote: > >> > >>> Running the testsuite with Py 3.8.2 with PYTHONLEGACYWINDOW

Re: Problems running testsuite on Windows with Python 3

2020-04-19 Thread Yasuhito FUTATSUKI
On 2020/04/19 3:26, Johan Corveleyn wrote: > On Fri, Apr 17, 2020 at 11:21 PM Yasuhito FUTATSUKI > wrote: >> >> On 2020/04/17 5:53, Johan Corveleyn wrote: >> >>> Running the testsuite with Py 3.8.2 with PYTHONLEGACYWINDOWSSTDIO >>> defined in the environment allows it to complete. It results in 6

Re: Problems running testsuite on Windows with Python 3

2020-04-17 Thread Yasuhito FUTATSUKI
On 2020/04/17 5:53, Johan Corveleyn wrote: > Running the testsuite with Py 3.8.2 with PYTHONLEGACYWINDOWSSTDIO > defined in the environment allows it to complete. It results in 68 > FAILS (for ra_local x fsfs). See attached fails.log. I hope a part of the problems may fixed by attached patch, ho