Re: Pristines-on-demand: authz denied during textbase sync (#4888)

Julian Foad wrote on Wed, Apr 06, 2022 at 13:07:43 +0100: > > Filed as issue #4888, https://subversion.apache.org/issue/4888 > > I have just been looking back over this issue. Clearly there is more to > it than a quick fix. Summary, based on reviewing the email thread: > > - FAIL: authz_tests.py

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

On 06 Apr 2022, Julian Foad wrote: Evgeny Kotkov wrote: - revert the patch I applied, as it's papering over the problem in an incomplete way and so possibly causes more confusion than it fixes. - leave this issue open and come back to it later; it's an edge case not part of common work flow

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

Evgeny Kotkov wrote: >> - revert the patch I applied, as it's papering over the problem in an >> incomplete way and so possibly causes more confusion than it fixes. >> >> - leave this issue open and come back to it later; it's an edge case not >> part of common work flows. > > +1. Thanks! Revert

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

Julian Foad writes: > I suggest: > > - revert the patch I applied, as it's papering over the problem in an > incomplete way and so possibly causes more confusion than it fixes. > > - leave this issue open and come back to it later; it's an edge case not > part of common work flows. +1. Regards

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

> Filed as issue #4888, https://subversion.apache.org/issue/4888 I have just been looking back over this issue. Clearly there is more to it than a quick fix. Summary, based on reviewing the email thread: - FAIL: authz_tests.py 31 remove_access_after_commit - Patched in

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

Filed as issue #4888, https://subversion.apache.org/issue/4888 I will come back to it soonish.

Re: Pristines-on-demand: authz denied during textbase sync

Daniel Shahaf wrote on Sat, Feb 19, 2022 at 13:35:22 +: > Julian Foad wrote on Fri, Feb 18, 2022 at 17:00:02 +: > > I committed the proposed fix in r1898184: > > [[[ > > On the 'pristines-on-demand-on-mwf' branch: fix authz_tests.py 31. > > > > This test runs an 'update' after read access

Re: Pristines-on-demand: authz denied during textbase sync

Julian Foad wrote on Sat, Feb 19, 2022 at 14:00:46 +: > Thanks, Daniel. I'll take a look at this some time in the next few days > unless someone beats me to it. > > Daniel Shahaf wrote: > > [...] What race condition is that? The change to authz happened before the > >sync, not between the sy

Re: Pristines-on-demand: authz denied during textbase sync

Thanks, Daniel. I'll take a look at this some time in the next few days unless someone beats me to it. Daniel Shahaf wrote: > [...] What race condition is that? The change to authz happened before the >sync, not between the sync and the main operation. Yes, it's not directly related to this; it

Re: Pristines-on-demand: authz denied during textbase sync

Daniel Shahaf wrote on Sat, Feb 19, 2022 at 13:35:22 +: > This seems to have regressed the failure mode of «svn cat iota@BASE» > when iota is locally-modified and has no read access. > > To reproduce: > Here's a patch too: [[[ Index: subversion/tests/cmdline/authz_tests.py =

Re: Pristines-on-demand: authz denied during textbase sync

Julian Foad wrote on Thu, Feb 17, 2022 at 22:20:17 +: > Proposed fix: in "text base sync" phase, ignore auth error while > fetching any text base; continue with trying to fetch the rest. > > That works in terms of the test case passing. > > Can anyone think of issues with this approach, not l

Re: Pristines-on-demand: authz denied during textbase sync

I committed the proposed fix in r1898184: [[[ On the 'pristines-on-demand-on-mwf' branch: fix authz_tests.py 31. This test runs an 'update' after read access permission has been removed from a repository path. The text base sync code errored out when it tried to download this text base. We fix it

Pristines-on-demand: authz denied during textbase sync

I am going through the tests that are changed or disabled (WIP or XFAIL) on the branch. Here is one. authz_tests.py 31 remove_access_after_commit(): "remove a subdir with authz file" Fails in pristine-on-demand mode in this scenario: - checkout - commit changes to files under dirs (B,D) - change