Re: Possibly missing pointer dereference in parse-diff.c

2023-01-09 Thread Nathan Hartman
On Mon, Jan 9, 2023 at 9:06 AM Stefan Sperling wrote: > Thank you Johannes, this has been committed. Your fix is indeed correct. Also nominated for backport to 1.14.x. Thanks! Nathan

Re: Possibly missing pointer dereference in parse-diff.c

2023-01-09 Thread Stefan Sperling
On Mon, Jan 09, 2023 at 11:19:48AM +0100, Johannes von Rotz wrote: > Hello > > I was trying to compile subversion with the HP ANSI C compiler on HP-UX > yesterday, which complained about the if-statement in question requiring a > scalar value or something. Unfortunately, I'm unable to recite the s

Re: Possibly missing pointer dereference in parse-diff.c

2023-01-09 Thread Johannes von Rotz
Daniel Sahlberg wrote: One question to Johannes, we have a system of crediting the original author in the log message, see [1]. Do you want to use your full name/e-mail or any masking? Hi Daniel Feel free to use my full name and e-mail if the patch is relevant. Cheers, J.

Re: Possibly missing pointer dereference in parse-diff.c

2023-01-09 Thread Daniel Sahlberg
Den mån 9 jan. 2023 kl 11:20 skrev Johannes von Rotz : > Hello > > I was trying to compile subversion with the HP ANSI C compiler on HP-UX > yesterday, which complained about the if-statement in question requiring > a scalar value or something. Unfortunately, I'm unable to recite the > specific er

Possibly missing pointer dereference in parse-diff.c

2023-01-09 Thread Johannes von Rotz
Hello I was trying to compile subversion with the HP ANSI C compiler on HP-UX yesterday, which complained about the if-statement in question requiring a scalar value or something. Unfortunately, I'm unable to recite the specific error message, since I'm currently at work (Ahem...) It seems t