Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-17 Thread Ivan Zhakov
On 17 May 2015 at 17:41, Stefan Fuhrmann wrote: > On Thu, May 14, 2015 at 2:37 PM, Branko Čibej wrote: >> >> On 13.05.2015 19:04, Ivan Zhakov wrote: >> > [adjusting subject to make it valid vote thread] >> > >> > On 13 May 2015 at 19:23, Stefan Fuhrmann >> > wrote: >> >> Hi there, >> >> >> >> Iv

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-17 Thread Stefan Fuhrmann
On Sat, May 16, 2015 at 7:45 PM, Ivan Zhakov wrote: > On 16 May 2015 at 07:48, Stefan Fuhrmann > wrote: > > On Fri, May 15, 2015 at 7:25 PM, Philip Martin < > philip.mar...@wandisco.com> > > wrote: > >> Another issue: find_entry() now calls drop_entry() in more cases and can > >> now call it whe

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-17 Thread Stefan Fuhrmann
On Thu, May 14, 2015 at 2:37 PM, Branko Čibej wrote: > On 13.05.2015 19:04, Ivan Zhakov wrote: > > [adjusting subject to make it valid vote thread] > > > > On 13 May 2015 at 19:23, Stefan Fuhrmann > wrote: > >> Hi there, > >> > >> Ivan has reviewed my recent membuffer cache > >> key handling cha

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-16 Thread Ivan Zhakov
On 16 May 2015 at 07:48, Stefan Fuhrmann wrote: > On Fri, May 15, 2015 at 7:25 PM, Philip Martin > wrote: >> >> Philip Martin writes: >> >> > Philip Martin writes: >> > >> >> Prompted by the warnings I think there are some issues to fix. For >> >> APR_HASH_KEY_STRING keys there is no protectio

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Stefan Fuhrmann
On Fri, May 15, 2015 at 7:25 PM, Philip Martin wrote: > Philip Martin writes: > > > Philip Martin writes: > > > >> Prompted by the warnings I think there are some issues to fix. For > >> APR_HASH_KEY_STRING keys there is no protection against abnormally long > >> keys. combined_long_key() wil

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Philip Martin
Philip Martin writes: > Prompted by the warnings I think there are some issues to fix. For > APR_HASH_KEY_STRING keys there is no protection against abnormally long > keys. combined_long_key() will allocate strlen() memory even if it is > many GB. The item will not get cached if key+data lengt

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Philip Martin
Philip Martin writes: > Philip Martin writes: > >> Prompted by the warnings I think there are some issues to fix. For >> APR_HASH_KEY_STRING keys there is no protection against abnormally long >> keys. combined_long_key() will allocate strlen() memory even if it is >> many GB. The item will n

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Philip Martin
Philip Martin writes: > Prompted by the warnings I think there are some issues to fix. For > APR_HASH_KEY_STRING keys there is no protection against abnormally long > keys. combined_long_key() will allocate strlen() memory even if it is > many GB. The item will not get cached if key+data lengt

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Ivan Zhakov
On 14 May 2015 at 15:37, Branko Čibej wrote: > On 13.05.2015 19:04, Ivan Zhakov wrote: >> [adjusting subject to make it valid vote thread] >> >> On 13 May 2015 at 19:23, Stefan Fuhrmann >> wrote: >>> Hi there, >>> >>> Ivan has reviewed my recent membuffer cache >>> key handling changes, correcte

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-15 Thread Philip Martin
Branko Čibej writes: > -0 because: > > $ make > .../subversion/libsvn_subr/cache-membuffer.c:2626:59: warning: implicit > conversion loses integer > precision: 'unsigned long' to 'apr_uint32_t' (aka 'unsigned int') > [-Wshorten-64-to-32] > cache->combined_key.entry_key.key_len = aligned

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-14 Thread Branko Čibej
On 13.05.2015 19:04, Ivan Zhakov wrote: > [adjusting subject to make it valid vote thread] > > On 13 May 2015 at 19:23, Stefan Fuhrmann wrote: >> Hi there, >> >> Ivan has reviewed my recent membuffer cache >> key handling changes, corrected and backported >> them on the 1.9-cache-improvements bran

RE: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-13 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: woensdag 13 mei 2015 19:04 > To: Stefan Fuhrmann > Cc: Subversion Development > Subject: [VOTE] Merging 1.9-cache-improvements to /trunk > > [adjusting subject to make it valid vote thr

Re: [VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-13 Thread Stefan Fuhrmann
On Wed, May 13, 2015 at 7:04 PM, Ivan Zhakov wrote: > [adjusting subject to make it valid vote thread] > > On 13 May 2015 at 19:23, Stefan Fuhrmann > wrote: > > Hi there, > > > > Ivan has reviewed my recent membuffer cache > > key handling changes, corrected and backported > > them on the 1.9-ca

[VOTE] Merging 1.9-cache-improvements to /trunk

2015-05-13 Thread Ivan Zhakov
[adjusting subject to make it valid vote thread] On 13 May 2015 at 19:23, Stefan Fuhrmann wrote: > Hi there, > > Ivan has reviewed my recent membuffer cache > key handling changes, corrected and backported > them on the 1.9-cache-improvements branch. > > I reviewed it and I'm +1 on merging it to

Merging 1.9-cache-improvements to /trunk

2015-05-13 Thread Stefan Fuhrmann
Hi there, Ivan has reviewed my recent membuffer cache key handling changes, corrected and backported them on the 1.9-cache-improvements branch. I reviewed it and I'm +1 on merging it to /trunk - hoping we may even get it into 1.9. Since this touches a sensitive part of the server code, I'd like t