Re: Make 'svn patch' keep permissions of patched files

2022-02-22 Thread Daniel Shahaf
Ruediger Pluem wrote on Mon, 21 Feb 2022 12:23 +00:00: > On 2/21/22 11:54 AM, Daniel Shahaf wrote: >> Ruediger Pluem wrote on Mon, Feb 21, 2022 at 08:49:08 +0100: >> Even if we don't consense on what the behaviour should be, we could at >> least add a test that expects the current behaviour, in ord

Re: Make 'svn patch' keep permissions of patched files

2022-02-21 Thread Ruediger Pluem
On 2/21/22 11:54 AM, Daniel Shahaf wrote: > Ruediger Pluem wrote on Mon, Feb 21, 2022 at 08:49:08 +0100: >> On 2/19/22 5:07 PM, Daniel Shahaf wrote: >>> I can't reproduce this. Using unpatched trunk: >> >> I checked again and I was able to reproduce it with 1.10. >> With 1.13 though it shows th

Re: Make 'svn patch' keep permissions of patched files

2022-02-21 Thread Daniel Shahaf
Ruediger Pluem wrote on Mon, Feb 21, 2022 at 08:49:08 +0100: > On 2/19/22 5:07 PM, Daniel Shahaf wrote: > > I can't reproduce this. Using unpatched trunk: > > I checked again and I was able to reproduce it with 1.10. > With 1.13 though it shows the behavior you describe for trunk below. ⋮ > > How

Re: Make 'svn patch' keep permissions of patched files

2022-02-20 Thread Ruediger Pluem
On 2/19/22 5:07 PM, Daniel Shahaf wrote: > Stefan Sperling wrote on Thu, Feb 10, 2022 at 09:29:12 +0100: >> On Thu, Feb 10, 2022 at 12:10:08AM -0600, Karl Fogel wrote: >>> On 09 Feb 2022, Ruediger Pluem wrote: When rebuilding my own Subversion build I stumbled across the following patc

Re: Make 'svn patch' keep permissions of patched files

2022-02-19 Thread Daniel Shahaf
Stefan Sperling wrote on Thu, Feb 10, 2022 at 09:29:12 +0100: > On Thu, Feb 10, 2022 at 12:10:08AM -0600, Karl Fogel wrote: > > On 09 Feb 2022, Ruediger Pluem wrote: > > > When rebuilding my own Subversion build I stumbled across the following > > > patch that I add to my build: > > > > > > Index:

Re: Make 'svn patch' keep permissions of patched files

2022-02-10 Thread Karl Fogel
On 10 Feb 2022, Stefan Sperling wrote: On Thu, Feb 10, 2022 at 12:10:08AM -0600, Karl Fogel wrote: I'm curious: what is the case that causes the patched target file to have different permissions than it had before the patch? (Or am I misunderstanding what you're saying?) Possibly related to

Re: Make 'svn patch' keep permissions of patched files

2022-02-10 Thread Stefan Sperling
On Thu, Feb 10, 2022 at 12:10:08AM -0600, Karl Fogel wrote: > On 09 Feb 2022, Ruediger Pluem wrote: > > When rebuilding my own Subversion build I stumbled across the following > > patch that I add to my build: > > > > Index: subversion/libsvn_client/patch.c > >

Re: Make 'svn patch' keep permissions of patched files

2022-02-09 Thread Karl Fogel
On 09 Feb 2022, Ruediger Pluem wrote: When rebuilding my own Subversion build I stumbled across the following patch that I add to my build: Index: subversion/libsvn_client/patch.c === --- subversion/libsvn_client/patch.c(revisi

Make 'svn patch' keep permissions of patched files

2022-02-09 Thread Ruediger Pluem
When rebuilding my own Subversion build I stumbled across the following patch that I add to my build: Index: subversion/libsvn_client/patch.c === --- subversion/libsvn_client/patch.c(revision 1897905) +++ subversion/libsvn_client