Re: Log-addressing branch ready for review

2013-12-02 Thread Julian Foad
Stefan Fuhrmann wrote: > On Wed, Nov 27, 2013 at 6:55 PM, Julian Foad wrote: >> Stefan Fuhrmann wrote: >>> As of r1516665, work on this branch has been completed. >>> Please review. See the BRANCH-README for the list of >>> major changes. >> >> First I am looking for an overall descrip

Re: Log-addressing branch ready for review

2013-12-02 Thread Stefan Fuhrmann
On Wed, Nov 27, 2013 at 6:55 PM, Julian Foad wrote: > Stefan Fuhrmann wrote: > > As of r1516665, work on this branch has been completed. > > Please review. See the BRANCH-README for the list of > > major changes. > > I have not reviewed, but looked at how to review it. > > First I am l

Re: Log-addressing branch ready for review

2013-11-30 Thread Stefan Fuhrmann
On Sat, Nov 30, 2013 at 2:23 PM, Daniel Shahaf wrote: > Daniel Shahaf wrote on Sat, Nov 30, 2013 at 15:19:56 +0200: > > Stefan Fuhrmann wrote on Sat, Nov 30, 2013 at 08:48:30 +0100: > > > Again, you are missing the point. You are saying that there > > > are lots of possible configurations and vari

Re: Log-addressing branch ready for review

2013-11-30 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Sat, Nov 30, 2013 at 15:10:00 +0100: > Now, we are at a point were internal review is certainly > welcome and will probably find more issues but the real > test is using it in the real world, e.g. as part of an alpha > release. +1

Re: Log-addressing branch ready for review

2013-11-30 Thread Stefan Fuhrmann
On Sat, Nov 30, 2013 at 2:19 PM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Sat, Nov 30, 2013 at 08:48:30 +0100: > > Again, you are missing the point. You are saying that there > > are lots of possible configurations and various combinations. > > I'm saying that we *are* actually able to test

Re: Log-addressing branch ready for review

2013-11-30 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Nov 30, 2013 at 15:19:56 +0200: > So, no, running "make check" under more configurations (despite still > being an improvement) won't make me more confident that FSFS7 is in > release-shape. It simply doesn't test enough code paths. [ I was not trying to imply that FSF

Re: Log-addressing branch ready for review

2013-11-30 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Nov 30, 2013 at 15:19:56 +0200: > So, no, running "make check" under more configurations (despite still > being an improvement) won't make me more confident that FSFS7 is in > release-shape. It simply doesn't test enough code paths. [ I was not trying to imply that FSF

Re: Log-addressing branch ready for review

2013-11-30 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Nov 30, 2013 at 15:19:56 +0200: > Stefan Fuhrmann wrote on Sat, Nov 30, 2013 at 08:48:30 +0100: > > Again, you are missing the point. You are saying that there > > are lots of possible configurations and various combinations. > > I'm saying that we *are* actually able to

Re: Log-addressing branch ready for review

2013-11-30 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Sat, Nov 30, 2013 at 08:48:30 +0100: > Again, you are missing the point. You are saying that there > are lots of possible configurations and various combinations. > I'm saying that we *are* actually able to test many variants. > One simply needs to update their overall test

Re: Log-addressing branch ready for review

2013-11-29 Thread Stefan Fuhrmann
On Fri, Nov 29, 2013 at 5:29 PM, Ivan Zhakov wrote: > On 28 November 2013 10:22, Stefan Fuhrmann > wrote: > [...] > > >> > > >> > Thanks a lot, Philip! > >> > I plan on merging the branch later this week (Friday-ish). > >> > > >> Well, I still think that log-addressing branch should *NOT* be mer

Re: Log-addressing branch ready for review

2013-11-29 Thread Ivan Zhakov
On 28 November 2013 10:22, Stefan Fuhrmann wrote: [...] >> > >> > Thanks a lot, Philip! >> > I plan on merging the branch later this week (Friday-ish). >> > >> Well, I still think that log-addressing branch should *NOT* be merged >> and all FS _performance_ and format changes should be implemente

Re: Log-addressing branch ready for review

2013-11-27 Thread Stefan Fuhrmann
On Wed, Nov 27, 2013 at 12:19 PM, Ivan Zhakov wrote: > On 25 November 2013 17:44, Stefan Fuhrmann > wrote: > > On Mon, Nov 25, 2013 at 1:29 PM, Philip Martin > > > wrote: > >> > >> Stefan Fuhrmann writes: > >> > >> > On Tue, Sep 24, 2013 at 6:51 PM, Ivan Zhakov > wrote: > >> > > >> >> On 23 A

Re: Log-addressing branch ready for review

2013-11-27 Thread Julian Foad
Stefan Fuhrmann wrote: > As of r1516665, work on this branch has been completed. > Please review. See the BRANCH-README for the list of > major changes. I have not reviewed, but looked at how to review it. First I am looking for an overall description of the changes. The BRANCH-README

Re: Log-addressing branch ready for review

2013-11-27 Thread Stefan Fuhrmann
On Wed, Nov 27, 2013 at 12:19 PM, Ivan Zhakov wrote: > On 25 November 2013 17:44, Stefan Fuhrmann > wrote: > > On Mon, Nov 25, 2013 at 1:29 PM, Philip Martin > > > wrote: > >> > >> Stefan Fuhrmann writes: > >> > >> > On Tue, Sep 24, 2013 at 6:51 PM, Ivan Zhakov > wrote: > >> > > >> >> On 23 A

Re: Log-addressing branch ready for review

2013-11-27 Thread Ivan Zhakov
On 25 November 2013 17:44, Stefan Fuhrmann wrote: > On Mon, Nov 25, 2013 at 1:29 PM, Philip Martin > wrote: >> >> Stefan Fuhrmann writes: >> >> > On Tue, Sep 24, 2013 at 6:51 PM, Ivan Zhakov wrote: >> > >> >> On 23 August 2013 03:21, Stefan Fuhrmann >> >> wrote: >> >> > Hi all, >> >> > >> >> >

Re: Log-addressing branch ready for review

2013-11-25 Thread Stefan Fuhrmann
On Mon, Nov 25, 2013 at 1:29 PM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > On Tue, Sep 24, 2013 at 6:51 PM, Ivan Zhakov wrote: > > > >> On 23 August 2013 03:21, Stefan Fuhrmann > >> wrote: > >> > Hi all, > >> > > >> > As of r1516665, work on this branch has been completed. > >> > Ple

Re: Log-addressing branch ready for review

2013-11-25 Thread Philip Martin
Stefan Fuhrmann writes: > On Tue, Sep 24, 2013 at 6:51 PM, Ivan Zhakov wrote: > >> On 23 August 2013 03:21, Stefan Fuhrmann >> wrote: >> > Hi all, >> > >> > As of r1516665, work on this branch has been completed. >> > Please review. See the BRANCH-README for the list of >> > major changes. >> >

Re: Log-addressing branch ready for review

2013-09-24 Thread Stefan Fuhrmann
On Tue, Sep 24, 2013 at 6:51 PM, Ivan Zhakov wrote: > On 23 August 2013 03:21, Stefan Fuhrmann > wrote: > > Hi all, > > > > As of r1516665, work on this branch has been completed. > > Please review. See the BRANCH-README for the list of > > major changes. > > > > If there are no objections, I wi

Re: Log-addressing branch ready for review

2013-09-24 Thread Ivan Zhakov
On 23 August 2013 03:21, Stefan Fuhrmann wrote: > Hi all, > > As of r1516665, work on this branch has been completed. > Please review. See the BRANCH-README for the list of > major changes. > > If there are no objections, I will merge the code in the week > of Sep 23th. > Hi Stefan, I have looked

Log-addressing branch ready for review

2013-08-22 Thread Stefan Fuhrmann
Hi all, As of r1516665, work on this branch has been completed. Please review. See the BRANCH-README for the list of major changes. If there are no objections, I will merge the code in the week of Sep 23th. -- Stefan^2.