RE: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2013-03-07 Thread Gavin Baumanis
Ping. This submission has received no new comments. Gavin. > -Original Message- > From: Daniel Shahaf [mailto:danie...@elego.de] > Sent: Tuesday, 8 January 2013 15:49 > To: vijay > Cc: Philip Martin; Subversion Development > Subject: Re: [PATCH] Improve

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2013-01-08 Thread Daniel Shahaf
vijay wrote on Tue, Jan 08, 2013 at 15:30:46 +0530: > On Thursday 20 December 2012 07:52 PM, vijay wrote: >>> >>> I note that 'svnadmin create r; svnrdump dump file://$PWD/r/foo' does >>> not error --- maybe your patch fixes that too? >> >> The attached patch fixes this issue. This patch is differe

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2013-01-08 Thread vijay
On Thursday 20 December 2012 07:52 PM, vijay wrote: I note that 'svnadmin create r; svnrdump dump file://$PWD/r/foo' does not error --- maybe your patch fixes that too? The attached patch fixes this issue. This patch is different from the previous versions. We have to error out immediately if

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2012-12-20 Thread vijay
On Wednesday 19 December 2012 07:27 PM, Daniel Shahaf wrote: +@SkipUnless(svntest.main.is_ra_type_dav) +def dump_url_not_in_head(sbox) : Spurious whitespace. + "dump: URL deleted in HEAD should return error" + sbox.build(create_wc = False) + + E_url = sbox.repo_url + '/A/B/E' + # Delete

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2012-12-19 Thread Daniel Shahaf
> +@SkipUnless(svntest.main.is_ra_type_dav) > +def dump_url_not_in_head(sbox) : Spurious whitespace. > + "dump: URL deleted in HEAD should return error" > + sbox.build(create_wc = False) > + > + E_url = sbox.repo_url + '/A/B/E' > > + # Delete directory 'E'from repository. > + svntest

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2012-12-19 Thread Philip Martin
vijay writes: > Index: subversion/tests/cmdline/svnrdump_tests.py > === > --- subversion/tests/cmdline/svnrdump_tests.py(revision 1423268) > +++ subversion/tests/cmdline/svnrdump_tests.py(working copy) > @@ -765,8 +76

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2012-12-18 Thread vijay
On Monday 17 December 2012 09:34 PM, Philip Martin wrote: vijay writes: The function svn_ra_serf__replay_range() doesn't return any error while running 'svnrdump dump -rN:M '[Issue #4100]. It behaves as if the dump completed successfully. * subversion/libsvn_ra_serf/replay.c (svn_ra_serf__

Re: Improve error handling in svn_ra_serf__replay_range()

2012-12-17 Thread Philip Martin
vijay writes: > The function svn_ra_serf__replay_range() doesn't return any error > while running 'svnrdump dump -rN:M '[Issue #4100]. > It behaves as if the dump completed successfully. > > * subversion/libsvn_ra_serf/replay.c > (svn_ra_serf__replay_range): Handle the errors from server's re

Improve error handling in svn_ra_serf__replay_range()

2012-12-17 Thread vijay
Hi, I was looking at the issue #4100: "svnrdump dump -rN:M ' fails" [1]. [[[ $ URL=http://svn.apache.org/repos/asf/subversion/trunk/contrib/server-side/mod_setlocale $ svnrdump dump $URL -r1232154 > /dev/null * Dumped revision 1232154. $ svnrdump dump $URL -r1232155 > /dev/null * Dumped rev