Re: Ev2 symlinks

2013-07-01 Thread Greg Stein
On Mon, Jul 1, 2013 at 8:48 AM, Daniel Shahaf wrote: > Greg Stein wrote on Fri, Jun 28, 2013 at 02:49:01 -0400: >> On Fri, Jun 28, 2013 at 1:59 AM, Daniel Shahaf wrote: >... >> > Okay. Suppose Ev2 is released in 1.9 and svn:special=blockdev in 1.10. >> > An app is built against libsvn_fs-1.9 and

Re: Ev2 symlinks

2013-07-01 Thread Daniel Shahaf
Greg Stein wrote on Fri, Jun 28, 2013 at 02:49:01 -0400: > On Fri, Jun 28, 2013 at 1:59 AM, Daniel Shahaf wrote: > > Greg Stein wrote on Fri, Jun 28, 2013 at 01:25:42 -0400: > >> On Fri, Jun 28, 2013 at 1:19 AM, Daniel Shahaf wrote: > >> >... > >> > So, to be explicit: calling add_symlink() when

Re: Ev2 symlinks

2013-06-28 Thread Philip Martin
Daniel Shahaf writes: > (pop quiz: who ran 'make check' with 1.7 client and 1.8 server, or 1.8 > client and 1.7 server, during the soak?). I did it shortly before the soak, I raised issue 4348 :) -- Philip Martin | Subversion Committer WANdisco | Non-Stop Data www.wandisco.com

Re: Ev2 symlinks

2013-06-27 Thread Greg Stein
On Fri, Jun 28, 2013 at 1:59 AM, Daniel Shahaf wrote: > Greg Stein wrote on Fri, Jun 28, 2013 at 01:25:42 -0400: >> On Fri, Jun 28, 2013 at 1:19 AM, Daniel Shahaf wrote: >> >... >> > So, to be explicit: calling add_symlink() when driving the FS commit >> > editor is a bug; >> >> Of course not. Th

Re: Ev2 symlinks

2013-06-27 Thread Daniel Shahaf
Greg Stein wrote on Fri, Jun 28, 2013 at 01:25:42 -0400: > On Fri, Jun 28, 2013 at 1:19 AM, Daniel Shahaf wrote: > >... > > So, to be explicit: calling add_symlink() when driving the FS commit > > editor is a bug; > > Of course not. The FS commit editor knows how to represent a symlink > within t

Re: Ev2 symlinks

2013-06-27 Thread Branko Čibej
On 28.06.2013 07:19, Daniel Shahaf wrote: > So, to be explicit: calling add_symlink() when driving the FS commit > editor is a bug; calling add_file(svn:special='*', contents="link foo") > when driving the wc-ng update editor is also a bug. > > I suppose we could have a wrapper editor that converts

Re: Ev2 symlinks

2013-06-27 Thread Greg Stein
On Fri, Jun 28, 2013 at 1:19 AM, Daniel Shahaf wrote: >... > So, to be explicit: calling add_symlink() when driving the FS commit > editor is a bug; Of course not. The FS commit editor knows how to represent a symlink within the FS. (however the FS design changes over time) > calling add_file(sv

Re: Ev2 symlinks

2013-06-27 Thread Daniel Shahaf
Greg Stein wrote on Fri, Jun 28, 2013 at 01:04:26 -0400: > On Fri, Jun 28, 2013 at 12:52 AM, Daniel Shahaf wrote: > >... > > In second thought, this just moves the problem: the wc layer would want to > > call > > add_symlink() during a commit. > > > > But I'd like to avoid the ambiguity still: ei

Re: Ev2 symlinks

2013-06-27 Thread Greg Stein
On Fri, Jun 28, 2013 at 12:52 AM, Daniel Shahaf wrote: >... > In second thought, this just moves the problem: the wc layer would want to > call > add_symlink() during a commit. > > But I'd like to avoid the ambiguity still: either add_symlink() or > add_file(svn:special=yes), not both; either add

Re: Ev2 symlinks

2013-06-27 Thread Daniel Shahaf
On Fri, Jun 28, 2013 at 07:20:34AM +0300, Daniel Shahaf wrote: > Greg Stein wrote on Thu, Jun 27, 2013 at 22:25:48 -0400: > > On Thu, Jun 27, 2013 at 8:40 PM, Daniel Shahaf wrote: > > > Greg Stein wrote on Thu, Jun 27, 2013 at 20:33:39 -0400: > > >> On Thu, Jun 27, 2013 at 8:01 PM, Daniel Shahaf

Re: Ev2 symlinks

2013-06-27 Thread Daniel Shahaf
Greg Stein wrote on Thu, Jun 27, 2013 at 22:25:48 -0400: > On Thu, Jun 27, 2013 at 8:40 PM, Daniel Shahaf wrote: > > Greg Stein wrote on Thu, Jun 27, 2013 at 20:33:39 -0400: > >> On Thu, Jun 27, 2013 at 8:01 PM, Daniel Shahaf wrote: > >> > Branko Čibej wrote on Thu, Jun 27, 2013 at 21:32:31 +0200

Re: Ev2 symlinks

2013-06-27 Thread Greg Stein
On Thu, Jun 27, 2013 at 8:40 PM, Daniel Shahaf wrote: > Greg Stein wrote on Thu, Jun 27, 2013 at 20:33:39 -0400: >> On Thu, Jun 27, 2013 at 8:01 PM, Daniel Shahaf wrote: >> > Branko Čibej wrote on Thu, Jun 27, 2013 at 21:32:31 +0200: >> >> On 27.06.2013 21:16, Greg Stein wrote: >> >> > On IRC, Br

Re: Ev2 symlinks

2013-06-27 Thread Daniel Shahaf
Greg Stein wrote on Thu, Jun 27, 2013 at 20:33:39 -0400: > On Thu, Jun 27, 2013 at 8:01 PM, Daniel Shahaf wrote: > > Branko Čibej wrote on Thu, Jun 27, 2013 at 21:32:31 +0200: > >> On 27.06.2013 21:16, Greg Stein wrote: > >> > On IRC, Branko noted: > >> > on the subject of ev2 api, i'm wonderi

Re: Ev2 symlinks

2013-06-27 Thread Greg Stein
On Thu, Jun 27, 2013 at 8:01 PM, Daniel Shahaf wrote: > Branko Čibej wrote on Thu, Jun 27, 2013 at 21:32:31 +0200: >> On 27.06.2013 21:16, Greg Stein wrote: >> > On IRC, Branko noted: >> > on the subject of ev2 api, i'm wondering if add_symlink and >> > alter_symlink should really be there. it

Re: Ev2 symlinks

2013-06-27 Thread Daniel Shahaf
Branko Čibej wrote on Thu, Jun 27, 2013 at 21:32:31 +0200: > On 27.06.2013 21:16, Greg Stein wrote: > > On IRC, Branko noted: > > on the subject of ev2 api, i'm wondering if add_symlink and > > alter_symlink should really be there. it looks like special-casing on > > one type of special node >

Re: Ev2 symlinks

2013-06-27 Thread Branko Čibej
On 27.06.2013 21:16, Greg Stein wrote: > On IRC, Branko noted: > on the subject of ev2 api, i'm wondering if add_symlink and > alter_symlink should really be there. it looks like special-casing on > one type of special node > > > There is *only* one type of special node. There are no plans for

Ev2 symlinks

2013-06-27 Thread Greg Stein
On IRC, Branko noted: on the subject of ev2 api, i'm wondering if add_symlink and alter_symlink should really be there. it looks like special-casing on one type of special node There is *only* one type of special node. There are no plans for any other type of special node. The current design