Re: Crazy idea: changes in WC should share an API with changes in repository

2018-12-03 Thread Julian Foad
Julian Foad wrote on 2018-11-09: > > Implementation of the "WC delta editor" is in progress. > > Currently factoring out our "copy dir from repos to WC" implementation Some more notes on progress. The way we handle "copy" into the WC is a beast. Untangling this is by far the most complex part

Re: Crazy idea: changes in WC should share an API with changes in repository

2018-11-12 Thread Julian Foad
Greg Stein wrote: >> Is this such a crazy idea? > > Not at all. This is what Ev2 was supposed to do. Part of my work > around that was to start shifting code from the old delta-editor to > Ev2. We have shims already available to support that work. I'd suggest > looking at Ev2 rather than creating

Re: Crazy idea: changes in WC should share an API with changes in repository

2018-11-11 Thread Greg Stein
On Fri, Nov 9, 2018 at 4:56 AM Julian Foad wrote: >... > Is this such a crazy idea? > Not at all. This is what Ev2 was supposed to do. Part of my work around that was to start shifting code from the old delta-editor to Ev2. We have shims already available to support that work. I'd suggest lookin

Re: Crazy idea: changes in WC should share an API with changes in repository

2018-11-09 Thread Daniel Shahaf
Julian Foad wrote on Fri, 09 Nov 2018 10:56 +: > It is really quite important for the feasibility of writing higher level > code such as shelving, that WC modifications can be read and written by > a common, abstract, interface. That is, an interface definition which > enables a 'copy' funct

Re: Crazy idea: changes in WC should share an API with changes in repository

2018-11-09 Thread Julian Foad
Julian Foad wrote: > The "WC replay delta" is simple and about ready to commit. r1846252. > Implementation of the "WC delta editor" is in progress. Currently factoring out our "copy dir from repos to WC" implementation from these two places: libsvn_client/copy.c : repos_to_wc_copy_single() li

Re: Crazy idea: changes in WC should share an API with changes in repository

2018-11-09 Thread Julian Foad
Branko Čibej wrote: > The WC-NG with its multiple op-depths behaves like a > limited-history repository. Your picture does lack the op-depth part, > though; there are N layers between BASE and WORKING, unlike in the > filesystem, where we always work against a single (base) revision. I don't think

Re: Crazy idea: changes in WC should share an API with changes in repository

2018-11-09 Thread Branko Čibej
On 09.11.2018 11:56, Julian Foad wrote: > Is this such a crazy idea? Not at all. The WC-NG with its multiple op-depths behaves like a limited-history repository. Your picture does lack the op-depth part, though; there are N layers between BASE and WORKING, unlike in the filesystem, where we always

Crazy idea: changes in WC should share an API with changes in repository

2018-11-09 Thread Julian Foad
The WC's main job is to compose a new revision. While the WC also supports merge conflict resolution, a mixed-revision base state, commit of selected parts, and many other additional features, the fundamental purpose of the WC is to help the user prepare, review and commit a set of changes whic