Re: Common header(s) for C and C++ API

2019-01-04 Thread Daniel Shahaf
Paul Hammant wrote on Fri, 04 Jan 2019 11:01 +: > ^ Any chance of example code being checked in too? Short > how-to-embed-subversion for C++ and C, I mean. There are some examples of using the C API in tools/. There are also minimal examples in subversion/tests/cmdline/*.c .

Re: Common header(s) for C and C++ API

2019-01-04 Thread Paul Hammant
My bad - I assumed the contents of #1850344 were all new, but of course the tests pre-existed that commit.

Re: Common header(s) for C and C++ API

2019-01-04 Thread Branko Čibej
On 04.01.2019 12:01, Paul Hammant wrote: > http://svn.apache.org/viewvc?view=revision&revision=1850344 > > ^ Any chance of example code being checked in too? Short > how-to-embed-subversion for C++ and C, I mean. Others elsewhere could > go on to do examples for Rust, Python, Java > (https://githu

Re: Common header(s) for C and C++ API

2019-01-04 Thread Paul Hammant
http://svn.apache.org/viewvc?view=revision&revision=1850344 ^ Any chance of example code being checked in too? Short how-to-embed-subversion for C++ and C, I mean. Others elsewhere could go on to do examples for Rust, Python, Java (https://github.com/bytedeco/javacpp), etc.

Re: Common header(s) for C and C++ API

2019-01-04 Thread Branko Čibej
On 31.12.2018 00:07, Branko Čibej wrote: > Summary: I propose to create one or possibly several new public header > files that will be used by both the C and C++ public APIs. r1850344 is the result. Thanks again for the suggestions, I think this is much cleaner than what I started with. -- Brane

Re: Common header(s) for C and C++ API

2019-01-02 Thread Branko Čibej
On 01.01.2019 02:08, James McCoy wrote: > On Mon, Dec 31, 2018 at 12:07:23AM +0100, Branko Čibej wrote: >> Summary: I propose to create one or possibly several new public header >> files that will be used by both the C and C++ public APIs. >> >> >> I would like to completely hide the dependency on

Re: Common header(s) for C and C++ API

2019-01-01 Thread Branko Čibej
On Mon, 31 Dec 2018, 15:43 Julian Foad I guess I'm missing something. Why not just move the existing C > declarations verbatim to an APR-free header (from svn_types.h to > svn_types_impl.h, for instance), and in C++ use them directly like this > (proposed lines marked '>'): > >/** > * @bri

Re: Common header(s) for C and C++ API

2018-12-31 Thread James McCoy
On Mon, Dec 31, 2018 at 12:07:23AM +0100, Branko Čibej wrote: > Summary: I propose to create one or possibly several new public header > files that will be used by both the C and C++ public APIs. > > > I would like to completely hide the dependency on APR from the public > parts of the C++ API. I

Re: Common header(s) for C and C++ API

2018-12-31 Thread Julian Foad
I guess I'm missing something. Why not just move the existing C declarations verbatim to an APR-free header (from svn_types.h to svn_types_impl.h, for instance), and in C++ use them directly like this (proposed lines marked '>'): /** * @brief Revision number type. */ - enum class num

Re: Common header(s) for C and C++ API

2018-12-31 Thread Branko Čibej
On 31.12.2018 04:57, Troy Curtis Jr wrote: > On Sun, Dec 30, 2018 at 6:07 PM Branko Čibej wrote: > >> Summary: I propose to create one or possibly several new public header >> files that will be used by both the C and C++ public APIs. >> >> >> I would like to completely hide the dependency on APR

Re: Common header(s) for C and C++ API

2018-12-30 Thread Troy Curtis Jr
On Sun, Dec 30, 2018 at 6:07 PM Branko Čibej wrote: > Summary: I propose to create one or possibly several new public header > files that will be used by both the C and C++ public APIs. > > > I would like to completely hide the dependency on APR from the public > parts of the C++ API. In order to

Common header(s) for C and C++ API

2018-12-30 Thread Branko Čibej
Summary: I propose to create one or possibly several new public header files that will be used by both the C and C++ public APIs. I would like to completely hide the dependency on APR from the public parts of the C++ API. In order to do that, public C++ headers must not include the C headers dire