Re: Combine and rename WC APIs that check WC root and switched

2012-12-05 Thread Julian Foad
Bert Huijben wrote: > Julian Foad wrote: >>   1) svn_wc_check_root(*is_wcroot,*is_switched,*kind,...) >>   3) svn_wc__db_is_switched(*is_wcroot,*is_switched,*kind,...) >> >>  Would it work to call (1) and (3) 'svn_wc...check_root_and_switched'? >> >>  It's a bit long but more accurate. > > I don

Re: Combine and rename WC APIs that check WC root and switched

2012-12-05 Thread Branko Čibej
On 05.12.2012 13:28, Bert Huijben wrote: > PS. If we want to crash the compilers and break the 80 character > linewidth we can also rename svn_wc__db_read_read info to show all its > arguments in its name ;-) You'd certainly not crash compilers that way. After all, C++ name mangling is exactly th

RE: Combine and rename WC APIs that check WC root and switched

2012-12-05 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: woensdag 5 december 2012 02:45 > To: Bert Huijben > Cc: Subversion Development > Subject: Re: Combine and rename WC APIs that check WC root and switched > > I (Julian Foad) wr

Re: Combine and rename WC APIs that check WC root and switched

2012-12-04 Thread Julian Foad
I (Julian Foad) wrote: > Bert Huijben wrote: >> 1 is new and should be the new public api (feel free to change >> it to a better name and make 3 match it). 2 is the internal api >> from before the introduction of 1 and 3. >>   >> 4 is the old ill-defined public api and 5 the better defined >>

Re: Combine and rename WC APIs that check WC root and switched

2012-12-04 Thread Julian Foad
Bert Huijben wrote: > 1 is new and should be the new public api (feel free to change > it to a better name and make 3 match it). 2 is the internal api > from before the introduction of 1 and 3. >  > 4 is the old ill-defined public api and 5 the better defined > variant. I would make these new func

RE: Combine and rename WC APIs that check WC root and switched

2012-12-04 Thread Bert Huijben
usually a hashtable lookup) Bert Sent from Windows Mail *From:* Bert Huijben *Sent:* December 4, 2012 11:28 PM *To:* Subversion Development ,Julian Foad < julianf...@btopenworld.com> *Subject:* RE: Combine and rename WC APIs that check WC root and switched 1 is new and should be the new publ

RE: Combine and rename WC APIs that check WC root and switched

2012-12-04 Thread Bert Huijben
PM *To:* Subversion Development *Subject:* Re: Combine and rename WC APIs that check WC root and switched I (Julian Foad) wrote: > These six APIs all overlap in functionality: > > 1) svn_wc_check_root(*is_wcroot,*is_switched,*kind,...) > 2 uses in 2 files > > 2) svn

Re: Combine and rename WC APIs that check WC root and switched

2012-12-04 Thread Julian Foad
I (Julian Foad) wrote: > These six APIs all overlap in functionality: > > 1) svn_wc_check_root(*is_wcroot,*is_switched,*kind,...) >     2 uses in 2 files > > 2) svn_wc__check_wc_root(*wc_root,*kind,*switched,...) >     5 uses in 4 files > > 3) svn_wc__db_is_switched(*is_wcroot,*is_switched,*kin

Combine and rename WC APIs that check WC root and switched

2012-12-04 Thread Julian Foad
These six APIs all overlap in functionality: 1) svn_wc_check_root(*is_wcroot,*is_switched,*kind,...)     2 uses in 2 files 2) svn_wc__check_wc_root(*wc_root,*kind,*switched,...)     5 uses in 4 files 3) svn_wc__db_is_switched(*is_wcroot,*is_switched,*kind,...)     5 uses in 4 files 4) svn_wc_is