Re: Code doesn't seem ... right

2011-01-28 Thread C. Michael Pilato
On 01/27/2011 10:05 AM, Justin Erenkrantz wrote: > On Wed, Jan 26, 2011 at 10:28 AM, C. Michael Pilato > wrote: >> I'm not sure how to move forward. Should we require that SVNMasterURI >> values point to something other than the server root? > > It was never intended to be at the server root -

Re: Code doesn't seem ... right

2011-01-27 Thread Justin Erenkrantz
On Wed, Jan 26, 2011 at 10:28 AM, C. Michael Pilato wrote: > I'm not sure how to move forward.  Should we require that SVNMasterURI > values point to something other than the server root? It was never intended to be at the server root - doing a proxy of / is always an odd proposition. -- justin

Re: Code doesn't seem ... right

2011-01-26 Thread C. Michael Pilato
On 01/26/2011 12:38 PM, C. Michael Pilato wrote: > On 01/24/2011 08:52 PM, Justin Erenkrantz wrote: >> On Mon, Jan 24, 2011 at 2:22 PM, C. Michael Pilato >> wrote: >>> [Using dev@ as a public TODO list to avoid pushing stack on a task.] >>> >>> In mod_dav_svn/mirror.c:dav_svn__location_body_filte

Re: Code doesn't seem ... right

2011-01-26 Thread C. Michael Pilato
On 01/24/2011 08:52 PM, Justin Erenkrantz wrote: > On Mon, Jan 24, 2011 at 2:22 PM, C. Michael Pilato > wrote: >> [Using dev@ as a public TODO list to avoid pushing stack on a task.] >> >> In mod_dav_svn/mirror.c:dav_svn__location_body_filter() and >> dav_svn__location_in_filter() are code blocks

Re: Code doesn't seem ... right

2011-01-24 Thread Justin Erenkrantz
On Mon, Jan 24, 2011 at 2:22 PM, C. Michael Pilato wrote: > [Using dev@ as a public TODO list to avoid pushing stack on a task.] > > In mod_dav_svn/mirror.c:dav_svn__location_body_filter() and > dav_svn__location_in_filter() are code blocks like this: > >    if (uri.path) >        canonicalized_ur

Re: Code doesn't seem ... right

2011-01-24 Thread Danny Trebbien
On Mon, Jan 24, 2011 at 2:22 PM, C. Michael Pilato wrote: > [Using dev@ as a public TODO list to avoid pushing stack on a task.] > > In mod_dav_svn/mirror.c:dav_svn__location_body_filter() and > dav_svn__location_in_filter() are code blocks like this: > >    if (uri.path) >        canonicalized_ur

Code doesn't seem ... right

2011-01-24 Thread C. Michael Pilato
[Using dev@ as a public TODO list to avoid pushing stack on a task.] In mod_dav_svn/mirror.c:dav_svn__location_body_filter() and dav_svn__location_in_filter() are code blocks like this: if (uri.path) canonicalized_uri = svn_urlpath__canonicalize(uri.path, r->pool); else ca