Re: Cannot get info for a file that was inside of file-replaced directory

2019-11-26 Thread Nathan Hartman
On Tue, Nov 26, 2019 at 12:21 PM Nathan Hartman wrote: > On Mon, Nov 25, 2019 at 12:03 PM Julian Foad wrote: > > Yes, (2): it already checks for two error codes: > > > >((err->apr_err == SVN_ERR_CLIENT_UNRELATED_RESOURCES) || > > (err->apr_err == SVN_ERR_FS_NOT_FOUND))) > > > > we

Re: Cannot get info for a file that was inside of file-replaced directory

2019-11-26 Thread Nathan Hartman
On Mon, Nov 25, 2019 at 12:03 PM Julian Foad wrote: > > TL;DR: Fixed and nominated for backport. Thank you!! More below... > > (2) Alternately, perhaps svn_client_info4() should remain as-is and > > instead same_resource_in_head() should change: Maybe under certain > > conditions that

Re: Cannot get info for a file that was inside of file-replaced directory

2019-11-25 Thread Julian Foad
TL;DR: Fixed and nominated for backport. I see it was a change I made that broke this case. Filed as: http://subversion.apache.org/issue/4837 Test added: http://svn.apache.org/r1870393 More below... Nathan Hartman wrote: [...] (1) This line in svn_client_info4(): SVN_ERR(same_resource_i

Re: Cannot get info for a file that was inside of file-replaced directory

2019-11-24 Thread Nathan Hartman
On Fri, Nov 22, 2019 at 2:00 PM Daniel Shahaf wrote: > Let's continue the discussion on dev@. [Moved from users@] I didn't (much) get into the code yet except for a quick skim through svn_client_info4(). If my understanding is correct, the change in r1823327 has to do solely with reporting abou

Re: Cannot get info for a file that was inside of file-replaced directory

2019-11-22 Thread Daniel Shahaf
Let's continue the discussion on dev@. [Moved from users@] Ivan, would you like to write a regression test for this? See subversion/tests/cmdline/info_tests.py. Cheers, Daniel P.S. Nathan, are you aware of this syntax? — «svn log --diff -x-wp -c r1823327» Nathan Hartman wrote on Fri, Nov 22