Re: SVN-4832 Authz perf regression 1.9 -> 1.10

2022-06-16 Thread Branko Čibej
On 15.06.2022 02:33, Branko Čibej wrote: On 08.06.2022 15:49, Julian Foad wrote: I did some profiling for SVN-4832 "Authz perf regression 1.9 -> 1.10" <https://subversion.apache.org/issue/4832>. I updated the issue with my findings, including a sample of the debug timings o

Re: SVN-4832 Authz perf regression 1.9 -> 1.10

2022-06-14 Thread Branko Čibej
On 08.06.2022 15:49, Julian Foad wrote: I did some profiling for SVN-4832 "Authz perf regression 1.9 -> 1.10" <https://subversion.apache.org/issue/4832>. I updated the issue with my findings, including a sample of the debug timings output from my debug code. TL;DR: if an aut

SVN-4832 Authz perf regression 1.9 -> 1.10

2022-06-08 Thread Julian Foad
I did some profiling for SVN-4832 "Authz perf regression 1.9 -> 1.10" <https://subversion.apache.org/issue/4832>. I updated the issue with my findings, including a sample of the debug timings output from my debug code. TL;DR: if an authz file specifies a large number of ACLs

Re: SVN-4832: Authz perf regression 1.9 -> 1.10

2020-02-04 Thread Julian Foad
/jira/browse/SVN-4832   "Authz perf regression 1.9 -> 1.10"

Re: SVN-4832: Authz perf regression 1.9 -> 1.10

2019-09-25 Thread Julian Foad
Sam, Thank you for your help in identifying and resolving this problem. As this is a significant issue in an LTS release, I have filed it in the issue tracker: https://issues.apache.org/jira/browse/SVN-4832 "Authz perf regression 1.9 -> 1.10" and updated the email subject t

Re: Authz perf regression 1.9 -> 1.10

2019-09-12 Thread Sam Toliman
Many thanks for feedback! It was rather a quick example to confirm the possibility to optimize this function in my case.

Re: Authz perf regression 1.9 -> 1.10

2019-09-12 Thread Branko Čibej
On 12.09.2019 13:30, Sam Toliman wrote: > >> (~3500k in my case) > > You have more than 3 million groups? > Misprinted. There are ~3500 groups in my case. > > > The best thing you can do is prepare a patch, with tests, that > > implements your suggestions. Considering of course that correctness is

Re: Authz perf regression 1.9 -> 1.10

2019-09-12 Thread Sam Toliman
>> (~3500k in my case) > You have more than 3 million groups? Misprinted. There are ~3500 groups in my case. > The best thing you can do is prepare a patch, with tests, that > implements your suggestions. Considering of course that correctness is > more important than performance. :) I will try to

Re: Authz perf regression 1.9 -> 1.10

2019-09-12 Thread Branko Čibej
On 12.09.2019 10:44, Sam Toliman wrote: > > How do you propose that the parser should know, in advance, which parts > > of the authz and groups files it can discard unless it parses all of > them? > > By this point >

Re: Authz perf regression 1.9 -> 1.10

2019-09-12 Thread Sam Toliman
> How do you propose that the parser should know, in advance, which parts > of the authz and groups files it can discard unless it parses all of them? By this point b->client_info

Re: Authz perf regression 1.9 -> 1.10

2019-09-11 Thread Branko Čibej
On 11.09.2019 18:34, Sam Toliman wrote: > > Greetings, > > TLDR since 1.10 subversion loading acl file ~15x times slower, which > leads in performance regression in tunnel mode used with svn+ssh scheme. > > https://subversion.apache.org/docs/release-notes/1.10#authzperf says > that performance was

Authz perf regression 1.9 -> 1.10

2019-09-11 Thread Sam Toliman
Greetings, TLDR since 1.10 subversion loading acl file ~15x times slower, which leads in performance regression in tunnel mode used with svn+ssh scheme. https://subversion.apache.org/docs/release-notes/1.10#authzperf says that performance was improved, but we have discovered regression using larg