Re: API review - svn_info2_t

2011-06-08 Thread Julian Foad
Hyrum K Wright wrote: > Are public consumers intended to read the information from > svn_wc__info2_t? If so, making it Subversion-private hardly seems > appropriate No, public consumers read svn_client_info2_t which is returned by svn_client_info3. The private struct is used for communicatin

Re: API review - svn_info2_t

2011-06-08 Thread Hyrum K Wright
Are public consumers intended to read the information from svn_wc__info2_t? If so, making it Subversion-private hardly seems appropriate -Hyrum On Wed, Jun 8, 2011 at 10:09 AM, Julian Foad wrote: > Thanks for the additional background, Hyrum. > > r1133417 moves and renames the struct to bec

Re: API review - svn_info2_t

2011-06-08 Thread Julian Foad
Thanks for the additional background, Hyrum. r1133417 moves and renames the struct to become both svn_wc__info2_t and svn_client_info2_t. It's certainly a kind of duplication but it's also the most straightforward solution, I think. I added a 'dup' function for the public one; doing that is what

Re: API review - svn_info2_t

2011-06-07 Thread Hyrum K Wright
Oh, and if it hasn't already grown one yet, svn_info2_t needs a constructor. svn_wc_info_t doesn't, since it's always created by libsvn_wc. -Hyrum On Tue, Jun 7, 2011 at 2:12 PM, Hyrum K Wright wrote: > As the original author of svn_info2_t, I'll share some thoughts which > might be of use. > >

Re: API review - svn_info2_t

2011-06-07 Thread Hyrum K Wright
As the original author of svn_info2_t, I'll share some thoughts which might be of use. The struct was originally defined as svn_info_t in svn_client.h, but with wc-ng, it needed a face lift. At the same time, I recognized the fact that info can be obtained via a URL, which returned a subset of th

Re: API review - svn_info2_t

2011-06-07 Thread Julian Foad
My current plan comes in two variants. Minimal solution: move the whole type to libsvn_wc, putting it in the svn_wc_ name space. A bit ugly in terms of how the svn_client_info3() API would look, returning a svn_wc data type from a svn_client function, but that's by no means unusual for us. Bette

API review - svn_info2_t

2011-06-07 Thread Julian Foad
Two things about the new svn_info2_t structure. svn_info2_t contains the following fields, which I'll group into four sections: repos node coordinates: repos_root_URL repos_UUID rev URL repos node basic info: kind size last_changed_rev last_changed_date la