Re: [vote] pin-externals branch to trunk

2015-02-24 Thread Julian Foad
Stefan Sperling wrote: > Julian Foad wrote: >>  Anything holding us back from merging this branch to trunk? [...] > > It has already been merged in r1659395. Oh, good. Sorry, I didn't notice that. - Julian

Re: [vote] pin-externals branch to trunk

2015-02-24 Thread Branko Čibej
On 24.02.2015 18:45, Julian Foad wrote: > Hi Stefan. > > Julian Foad wrote on 10 February 2015 >> Stefan Sperling wrote: > [...] >>> Are there any more objections to merging the branch to trunk? >> I don't have any objection to merging this to trunk. Comments from a partial >> review follow. [..

Re: [vote] pin-externals branch to trunk

2015-02-24 Thread Stefan Sperling
On Tue, Feb 24, 2015 at 05:45:14PM +, Julian Foad wrote: > Hi Stefan. > > Julian Foad wrote on 10 February 2015 > > Stefan Sperling wrote: > [...] > >>  Are there any more objections to merging the branch to trunk? > > > > I don't have any objection to merging this to trunk. Comments from a

Re: [vote] pin-externals branch to trunk

2015-02-24 Thread Julian Foad
Hi Stefan. Julian Foad wrote on 10 February 2015 > Stefan Sperling wrote: [...] >>  Are there any more objections to merging the branch to trunk? > > I don't have any objection to merging this to trunk. Comments from a partial > review follow. [...] Anything holding us back from merging this br

Re: [vote] pin-externals branch to trunk

2015-02-10 Thread Branko Čibej
On 10.02.2015 19:34, Julian Foad wrote: > Stefan Sperling wrote: >> Julian Foad wrote: >>> [...] should preserve the exact textual form of the {DATE} spec. I'm not >>> sure if it currently does. >> That has been fixed in r1655872. The date string is preserved now. > Not in that commit, but it does

Re: [vote] pin-externals branch to trunk

2015-02-10 Thread Julian Foad
Stefan Sperling wrote: > Julian Foad wrote: >> [...] should preserve the exact textual form of the {DATE} spec. I'm not >> sure if it currently does. > > That has been fixed in r1655872. The date string is preserved now. Not in that commit, but it does look like it's been fixed in a later commit

Re: [vote] pin-externals branch to trunk

2015-02-10 Thread Stefan Sperling
On Tue, Feb 10, 2015 at 06:06:25PM +, Julian Foad wrote: > I don't have any objection to merging this to trunk. Comments from a partial > review follow. > > I'd like to repeat my request for a written description of what "pinning" > means. Specifically, the condition for an external definiti

Re: [vote] pin-externals branch to trunk

2015-02-10 Thread Julian Foad
Stefan Sperling wrote: >     svn diff https://svn.apache.org/repos/asf/subversion/trunk@r1658686 \ >     https://svn.apache.org/repos/asf/subversion/branches/pin-externals > > Some bugs have been fixed and the regression test has been made > more fine-grained so tests can be run individually. > Pl

Re: [vote] pin-externals branch to trunk

2015-02-10 Thread Branko Čibej
On 10.02.2015 16:48, Stefan Sperling wrote: > On Tue, Feb 10, 2015 at 03:45:34PM +0100, Branko Čibej wrote: >> Looks OK, apart from the minor detail that all 10 pin-externals tests in >> externals_tests.py are failing now. > Thanks for the heads up. This was due to the last sync with trunk which >

Re: [vote] pin-externals branch to trunk

2015-02-10 Thread Stefan Sperling
On Tue, Feb 10, 2015 at 03:45:34PM +0100, Branko Čibej wrote: > Looks OK, apart from the minor detail that all 10 pin-externals tests in > externals_tests.py are failing now. Thanks for the heads up. This was due to the last sync with trunk which brought in changes from r1658410. I did a compile t

Re: [vote] pin-externals branch to trunk

2015-02-10 Thread Branko Čibej
On 10.02.2015 13:54, Stefan Sperling wrote: > On Wed, Jan 28, 2015 at 10:54:34AM +0100, Stefan Sperling wrote: >> I'd like to start a vote about merging the pin-externals branch to trunk. >> >> This command shows the changes to be merged: >> svn diff https://svn.apache.org/repos/asf/subversion/

Re: [vote] pin-externals branch to trunk

2015-02-10 Thread Stefan Sperling
On Wed, Jan 28, 2015 at 10:54:34AM +0100, Stefan Sperling wrote: > I'd like to start a vote about merging the pin-externals branch to trunk. > > This command shows the changes to be merged: > svn diff https://svn.apache.org/repos/asf/subversion/trunk@1655241 \ > https://svn.apache.org/re

Re: [vote] pin-externals branch to trunk

2015-02-04 Thread Stefan Kueng
On 04.02.2015 19:08, Stefan Sperling wrote: On Wed, Feb 04, 2015 at 06:42:08PM +0100, Stefan Kueng wrote: Maybe one more improvement: Add a new API to fetch the list of externals which would be pegged if NULL is passed to the svn_client_copy7 API. Suggested name: svn_client_get_externals_for_

Re: [vote] pin-externals branch to trunk

2015-02-04 Thread Stefan Sperling
On Wed, Feb 04, 2015 at 06:42:08PM +0100, Stefan Kueng wrote: > Maybe one more improvement: > Add a new API to fetch the list of externals which would be pegged if NULL > is passed to the svn_client_copy7 API. > > Suggested name: svn_client_get_externals_for_copy() > which returns the hash of all

Re: [vote] pin-externals branch to trunk

2015-02-04 Thread Stefan Kueng
On 04.02.2015 16:07, Stefan Sperling wrote: On Fri, Jan 30, 2015 at 06:14:02PM +0100, Stefan Kueng wrote: But can you maybe implement my other request about using an array of externals to tag so the user can chose which externals to tag and which ones to just leave as-is? Does this API do th

Re: [vote] pin-externals branch to trunk

2015-02-04 Thread Stefan Sperling
On Fri, Jan 30, 2015 at 06:14:02PM +0100, Stefan Kueng wrote: > But can you maybe implement my other request about using an array of > externals to tag so the user can chose which externals to tag and which ones > to just leave as-is? Does this API do the job? http://svn.apache.org/r1657267

Re: [vote] pin-externals branch to trunk

2015-02-03 Thread Julian Foad
Stefan Sperling wrote: > On Tue, Feb 03, 2015 at 12:25:01PM +, Julian Foad wrote: >>  This proposed log message seems to contain the documentation of the >> feature. Can we put the documentation somewhere more widely accessible? >> >>  - in the book? >>  - in the issue tracker [3]? >> >>  or

Re: [vote] pin-externals branch to trunk

2015-02-03 Thread Stefan Sperling
On Tue, Feb 03, 2015 at 12:25:01PM +, Julian Foad wrote: > Stefan Sperling wrote: > > Below is a full log message for the entire changeset. > > This proposed log message seems to contain the documentation of the feature. > Can we put the documentation somewhere more widely accessible? > > -

Re: [vote] pin-externals branch to trunk

2015-02-03 Thread Julian Foad
Stefan Sperling wrote: > Below is a full log message for the entire changeset. This proposed log message seems to contain the documentation of the feature. Can we put the documentation somewhere more widely accessible? - in the book? - in the issue tracker [3]? or at least document it here in e

RE: [vote] pin-externals branch to trunk

2015-01-31 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: zaterdag 31 januari 2015 12:59 > To: dev@subversion.apache.org > Subject: Re: [vote] pin-externals branch to trunk > > On 31.01.2015 11:09, Bert Huijben wrote: > > I’ll look

Re: [vote] pin-externals branch to trunk

2015-01-31 Thread Branko Čibej
On 31.01.2015 11:09, Bert Huijben wrote: > I’ll look into reducing the number of sessions after merging. I don’t > think this should really hold back the merging of the branch. (1.8 > does the same thing in many cases, while we still call that the > released/supported version) Yes, that's what I m

Re: [vote] pin-externals branch to trunk

2015-01-31 Thread Bert Huijben
I’ll look into reducing the number of sessions after merging. I don’t think this should really hold back the merging of the branch. (1.8 does the same thing in many cases, while we still call that the released/supported version) I’m pretty sure we can reduce the number of sessions before 1.9.0

Re: [vote] pin-externals branch to trunk

2015-01-31 Thread Branko Čibej
On 28.01.2015 10:54, Stefan Sperling wrote: > I'd like to start a vote about merging the pin-externals branch to trunk. I think this is ready to be merged to trunk, but there are two outstanding issues that really need to be addressed before we release: * When the source of the copy is the repo

Re: [vote] pin-externals branch to trunk

2015-01-31 Thread Branko Čibej
On 30.01.2015 18:14, Stefan Kueng wrote: > > > On 30.01.2015 01:10, Stefan Sperling wrote: >> On Fri, Jan 30, 2015 at 12:43:47AM +0100, Johan Corveleyn wrote: >>> From the peanut gallery: I'm with Stefan Küng on this. I think >>> "intra-repository externals" are used *a lot*, especially in >>> com

Re: [vote] pin-externals branch to trunk

2015-01-30 Thread Stefan Kueng
On 30.01.2015 01:10, Stefan Sperling wrote: On Fri, Jan 30, 2015 at 12:43:47AM +0100, Johan Corveleyn wrote: From the peanut gallery: I'm with Stefan Küng on this. I think "intra-repository externals" are used *a lot*, especially in companies. I'm not a big fan of this way of working myself,

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Johan Corveleyn
On Fri, Jan 30, 2015 at 1:10 AM, Stefan Sperling wrote: > On Fri, Jan 30, 2015 at 12:43:47AM +0100, Johan Corveleyn wrote: >> From the peanut gallery: I'm with Stefan Küng on this. I think >> "intra-repository externals" are used *a lot*, especially in >> companies. I'm not a big fan of this way o

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Sperling
On Fri, Jan 30, 2015 at 12:43:47AM +0100, Johan Corveleyn wrote: > From the peanut gallery: I'm with Stefan Küng on this. I think > "intra-repository externals" are used *a lot*, especially in > companies. I'm not a big fan of this way of working myself, but I can > certainly see it happening (just

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Johan Corveleyn
On Thu, Jan 29, 2015 at 11:15 PM, Stefan Sperling wrote: > On Thu, Jan 29, 2015 at 11:01:32PM +0100, Stefan Kueng wrote: >> >On Thu, Jan 29, 2015 at 07:26:01PM +0100, Stefan Kueng wrote: ... >> >Well, I'd rather avoid having to make commits to multiple repositories. >> >If this feature only works

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Sperling
On Thu, Jan 29, 2015 at 11:01:32PM +0100, Stefan Kueng wrote: > >On Thu, Jan 29, 2015 at 07:26:01PM +0100, Stefan Kueng wrote: > >What happens if one or more recursive externals definitions end up looping > >back to an external that's already been traversed? > > The same that happens if you try to

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Sperling
On Thu, Jan 29, 2015 at 12:39:13PM +0100, Stefan Sperling wrote: > On Wed, Jan 28, 2015 at 03:41:32PM +0100, Stefan Sperling wrote: > > Both concerns should be addressed as of r1655324. Thanks! > > Outstanding bugs I'm aware of: > > - WC->WC copies should not contact the repository. > > - RE

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Kueng
On 29.01.2015 22:45, Stefan Sperling wrote: On Thu, Jan 29, 2015 at 07:26:01PM +0100, Stefan Kueng wrote: TortoiseSVN has such a feature. Of course, it doesn't work in an ideal way. Here's what I do in TSVN: The branch/tag dialog (the one that's shown for an 'svn copy') scans the working copy

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Sperling
On Thu, Jan 29, 2015 at 07:26:01PM +0100, Stefan Kueng wrote: > TortoiseSVN has such a feature. Of course, it doesn't work in an ideal way. > Here's what I do in TSVN: > > The branch/tag dialog (the one that's shown for an 'svn copy') scans the > working copy for all external properties, and it do

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Kueng
On 29.01.2015 12:33, Stefan Sperling wrote: On Thu, Jan 29, 2015 at 12:14:27PM +0100, Tom Ghyselinck wrote: Hi everybody, I am following this feature with a lot of interest! One question pops up: 1. Suppose I have a branch "B" with external references to "E" 2. "E" has an external reference

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Tom Ghyselinck
Hi Stefan, Thank you for your notes! On do, 2015-01-29 at 14:08 +0100, Stefan Sperling wrote: > On Thu, Jan 29, 2015 at 01:40:14PM +0100, Tom Ghyselinck wrote: > > Hi Stefan, > > > > Thank you for you quick reply! > > > > Indeed, I was pointing to some kind of "recursive pinning". > > > > Let

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Sperling
On Thu, Jan 29, 2015 at 01:40:14PM +0100, Tom Ghyselinck wrote: > Hi Stefan, > > Thank you for you quick reply! > > Indeed, I was pointing to some kind of "recursive pinning". > > Let me explain a little bit why this would be a great feature > for our company: > > - We have some older projects

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Tom Ghyselinck
Hi Stefan, Thank you for you quick reply! Indeed, I was pointing to some kind of "recursive pinning". Let me explain a little bit why this would be a great feature for our company: - We have some older projects which use this kind of dependencies extensively. - Some of our newer projects still

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Sperling
On Wed, Jan 28, 2015 at 03:41:32PM +0100, Stefan Sperling wrote: > Both concerns should be addressed as of r1655324. Thanks! Outstanding bugs I'm aware of: - WC->WC copies should not contact the repository. - REPOS->WC copies check externals out before pinning so they end up having the w

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Stefan Sperling
On Thu, Jan 29, 2015 at 12:14:27PM +0100, Tom Ghyselinck wrote: > Hi everybody, > > I am following this feature with a lot of interest! > > One question pops up: > 1. Suppose I have a branch "B" with external references to "E" > 2. "E" has an external reference to "F" > > When I copy "B" to "C"

Re: [vote] pin-externals branch to trunk

2015-01-29 Thread Tom Ghyselinck
Hi everybody, I am following this feature with a lot of interest! One question pops up: 1. Suppose I have a branch "B" with external references to "E" 2. "E" has an external reference to "F" When I copy "B" to "C" with --pin-externals, then 1. The external reference "E" will be pinned to e.g. "E

Re: [vote] pin-externals branch to trunk

2015-01-28 Thread Stefan Sperling
On Wed, Jan 28, 2015 at 11:39:18AM +0100, Bert Huijben wrote: > > > > -Original Message- > > From: Branko Čibej [mailto:br...@wandisco.com] > > Sent: woensdag 28 januari 2015 11:11 > > To: dev@subversion.apache.org > > Subject: Re: [vote] pin-e

RE: [vote] pin-externals branch to trunk

2015-01-28 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: woensdag 28 januari 2015 11:11 > To: dev@subversion.apache.org > Subject: Re: [vote] pin-externals branch to trunk > > On 28.01.2015 10:54, Stefan Sperling wrote: > > There is a k

Re: [vote] pin-externals branch to trunk

2015-01-28 Thread Branko Čibej
On 28.01.2015 10:54, Stefan Sperling wrote: > There is a known problem where relative URLs in the externals definition > may become absolute when pinned. This happens if the URL of an external > resolves to a different path at its last-changed revision. For instance, > an external definition at r60

[vote] pin-externals branch to trunk

2015-01-28 Thread Stefan Sperling
I'd like to start a vote about merging the pin-externals branch to trunk. This command shows the changes to be merged: svn diff https://svn.apache.org/repos/asf/subversion/trunk@1655241 \ https://svn.apache.org/repos/asf/subversion/branches/pin-externals Below is a full log message fo