Re: [WIP] 'svn patch' should remove empty dirs

2010-02-23 Thread Neels J Hofmeyr
Daniel Näslund wrote: > On Mon, Feb 22, 2010 at 12:44:06PM +0100, Neels J Hofmeyr wrote: >> Re is_dir_empty() comment: When I last created function comments starting >> with "Helper for..." I was told that that's not really the desired way to >> go. We should rather have descriptive names / concise

Re: [WIP] 'svn patch' should remove empty dirs

2010-02-23 Thread Julian Foad
Daniel Näslund wrote: > > > Just a quick. > > > [ ] Yes, using APR forces you to a lot of boilerplate. > > > > You mean a lot of opaque APIs? With a (very) quick glance, I don't see any > > unusual use of APR. > > Ok. But could someone atleast tell me where to find a linked list in APR? APR does

Re: [WIP] 'svn patch' should remove empty dirs

2010-02-22 Thread Daniel Näslund
On Mon, Feb 22, 2010 at 12:44:06PM +0100, Neels J Hofmeyr wrote: > Hi Daniel, > > let me comment as far as my knowledge goes. (probably more general remarks) > > Daniel Näslund wrote: > > Hi Stefan! > > > > This patch is growing and growing and I'm worried that I'm heading off > > in the wrong d

Re: [WIP] 'svn patch' should remove empty dirs

2010-02-22 Thread Daniel Näslund
On Mon, Feb 22, 2010 at 08:44:47AM +0100, Stefan Sperling wrote: > On Sun, Feb 21, 2010 at 11:02:27PM +0100, Daniel Näslund wrote: [..] > > + unidiff_patch = [ > > +"Index: psi\n", > > + > > "===\n", > > +"--- A/D/H/psi\

Re: [WIP] 'svn patch' should remove empty dirs

2010-02-22 Thread Julian Foad
Neels J Hofmeyr wrote: > Re is_dir_empty() comment: When I last created function comments starting > with "Helper for..." I was told that that's not really the desired way to > go. We should rather have descriptive names / concise docs, and we should > design functions to be re-used for a particula

Re: [WIP] 'svn patch' should remove empty dirs

2010-02-22 Thread Neels J Hofmeyr
Hi Daniel, let me comment as far as my knowledge goes. (probably more general remarks) Daniel Näslund wrote: > Hi Stefan! > > This patch is growing and growing and I'm worried that I'm heading off > in the wrong direction. Perhaps you can skim through the patch and tell > me if this is the right

Re: [WIP] 'svn patch' should remove empty dirs

2010-02-21 Thread Stefan Sperling
On Sun, Feb 21, 2010 at 11:02:27PM +0100, Daniel Näslund wrote: > Hi Stefan! > > This patch is growing and growing and I'm worried that I'm heading off > in the wrong direction. Perhaps you can skim through the patch and tell > me if this is the right approach. You've said so earlier but all these

[WIP] 'svn patch' should remove empty dirs

2010-02-21 Thread Daniel Näslund
Hi Stefan! This patch is growing and growing and I'm worried that I'm heading off in the wrong direction. Perhaps you can skim through the patch and tell me if this is the right approach. You've said so earlier but all these lines of code makes me nervous. I like small fixes, and this is starting