Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-04-07 Thread Ivan Zhakov
On 7 April 2014 20:38, Stefan Fuhrmann wrote: > On Sun, Apr 6, 2014 at 5:36 PM, Ivan Zhakov wrote: >> >> On 6 April 2014 18:31, Stefan Fuhrmann >> wrote: >> > On Wed, Apr 2, 2014 at 12:13 PM, Ivan Zhakov wrote: >> >> >> >> On 31 January 2014 14:57, Ivan Zhakov wrote: >> >> > On 31 January 2014

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-04-07 Thread Stefan Fuhrmann
On Sun, Apr 6, 2014 at 5:36 PM, Ivan Zhakov wrote: > On 6 April 2014 18:31, Stefan Fuhrmann > wrote: > > On Wed, Apr 2, 2014 at 12:13 PM, Ivan Zhakov wrote: > >> > >> On 31 January 2014 14:57, Ivan Zhakov wrote: > >> > On 31 January 2014 05:50, Evgeny Kotkov > >> > wrote: > >> >>> This only a

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-04-06 Thread Ivan Zhakov
On 6 April 2014 18:31, Stefan Fuhrmann wrote: > On Wed, Apr 2, 2014 at 12:13 PM, Ivan Zhakov wrote: >> >> On 31 January 2014 14:57, Ivan Zhakov wrote: >> > On 31 January 2014 05:50, Evgeny Kotkov >> > wrote: >> >>> This only affects non-sharded repositories with rev-local IDs, >> >>> i.e. those

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-04-06 Thread Stefan Fuhrmann
On Wed, Apr 2, 2014 at 12:13 PM, Ivan Zhakov wrote: > On 31 January 2014 14:57, Ivan Zhakov wrote: > > On 31 January 2014 05:50, Evgeny Kotkov > wrote: > >>> This only affects non-sharded repositories with rev-local IDs, > >>> i.e. those in SVN 1.4 format. For those, it is writing 3 files > >>>

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-04-02 Thread Ivan Zhakov
On 31 January 2014 14:57, Ivan Zhakov wrote: > On 31 January 2014 05:50, Evgeny Kotkov wrote: >>> This only affects non-sharded repositories with rev-local IDs, >>> i.e. those in SVN 1.4 format. For those, it is writing 3 files >>> instead of 2 per rev now. >> >> I assume you are talking about r1

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-31 Thread Ivan Zhakov
On 31 January 2014 14:57, Ivan Zhakov wrote: > On 31 January 2014 05:50, Evgeny Kotkov wrote: >>> This only affects non-sharded repositories with rev-local IDs, >>> i.e. those in SVN 1.4 format. For those, it is writing 3 files >>> instead of 2 per rev now. >> >> I assume you are talking about r1

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-31 Thread Ivan Zhakov
On 31 January 2014 05:50, Evgeny Kotkov wrote: >> This only affects non-sharded repositories with rev-local IDs, >> i.e. those in SVN 1.4 format. For those, it is writing 3 files >> instead of 2 per rev now. > > I assume you are talking about r1560723 [1]. If I read the code correctly... > [[[ >

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-30 Thread Evgeny Kotkov
> This only affects non-sharded repositories with rev-local IDs, > i.e. those in SVN 1.4 format. For those, it is writing 3 files > instead of 2 per rev now. I assume you are talking about r1560723 [1]. If I read the code correctly... [[[ if ( (!max_files_per_dir || rev % max_files_per_di

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-28 Thread Stefan Fuhrmann
On Mon, Jan 27, 2014 at 10:25 AM, Ivan Zhakov wrote: > Hi Stefan, > > > On 27 January 2014 11:21, Stefan Fuhrmann > wrote: > > On Thu, Jan 23, 2014 at 11:00 AM, Evgeny Kotkov > > wrote: > >> > >> (wants to update the db/current file, but doesn't know the next > ids) > >> > >> svn_fs_

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-27 Thread Ivan Zhakov
Hi Stefan, On 27 January 2014 11:21, Stefan Fuhrmann wrote: > On Thu, Jan 23, 2014 at 11:00 AM, Evgeny Kotkov > wrote: >> >> (wants to update the db/current file, but doesn't know the next ids) >> >> svn_fs_fs__find_max_ids() >> svn_fs_fs__rev_get_root() >> svn_fs_f

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-26 Thread Stefan Fuhrmann
On Thu, Jan 23, 2014 at 11:00 AM, Evgeny Kotkov wrote: > Hi, > > I've noticed that svnadmin recover and hotcopy commands are broken for old > repositories around trunk@1560210. The problem can be reproduced by > creating > a new --compatible-version=1.3 / 1.2 / 1.1 FSFS repository, doing somethi

Re: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-23 Thread Stefan Fuhrmann
On Thu, Jan 23, 2014 at 11:00 AM, Evgeny Kotkov wrote: > Hi, > > I've noticed that svnadmin recover and hotcopy commands are broken for old > repositories around trunk@1560210. The problem can be reproduced by > creating > a new --compatible-version=1.3 / 1.2 / 1.1 FSFS repository, doing somethi

RE: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-23 Thread Bert Huijben
> -Original Message- > From: Evgeny Kotkov [mailto:evgeny.kot...@visualsvn.com] > Sent: donderdag 23 januari 2014 11:00 > To: dev@subversion.apache.org > Subject: [RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS > repositories > If this might help

[RFC/PATCH] svnadmin: recover/hotcopy erroring out for old FSFS repositories

2014-01-23 Thread Evgeny Kotkov
Hi, I've noticed that svnadmin recover and hotcopy commands are broken for old repositories around trunk@1560210. The problem can be reproduced by creating a new --compatible-version=1.3 / 1.2 / 1.1 FSFS repository, doing something simple with it (say, running svn mkdir or svn checkout / add file