Re: [Patch] fix for compilation error, when compiled with "-pedantic" option

2011-10-27 Thread Daniel Shahaf
[ additional clarification following an off-list reply: ] Daniel Shahaf wrote on Thu, Oct 27, 2011 at 10:21:18 +0200: > It's not a coding style issue, it's a syntax issue. C89 doesn't allow > that trailing comma. ... and our policy is to be C89-compatible.

Re: [Patch] fix for compilation error, when compiled with "-pedantic" option

2011-10-27 Thread Daniel Shahaf
CC += Peter Applied and nominated for backport towards 1.7.2, thanks. Prabhu Gnana Sundar wrote on Thu, Oct 27, 2011 at 12:50:18 +0530: > Hi all, > > When compiling the Subversion 1.7 code with the GCC(4.2.1) with > compiler option "-pedantic", compilation fails > with an error " comma at the en

Re: AW: [Patch] fix for compilation error, when compiled with "-pedantic" option

2011-10-27 Thread Julian Foad
Markus Schaber wrote: > Von: Prabhu Gnana Sundar [mailto:prabh...@collab.net] > > Not sure if the trailing commas at the end of enumerator lists are typos, > > though fixing quite a few of them in the patch attached. I have also > > attached the log message with this mail. > > Please share your vie

Re: [Patch] fix for compilation error, when compiled with "-pedantic" option

2011-10-27 Thread Daniel Shahaf
Markus Schaber wrote on Thu, Oct 27, 2011 at 07:26:47 +: > Hi, > > Von: Prabhu Gnana Sundar [mailto:prabh...@collab.net] > > Not sure if the trailing commas at the end of enumerator lists are typos, > > though fixing quite a few of them in the patch attached. I have also > > attached the log m

AW: [Patch] fix for compilation error, when compiled with "-pedantic" option

2011-10-27 Thread Markus Schaber
Hi, Von: Prabhu Gnana Sundar [mailto:prabh...@collab.net] > Not sure if the trailing commas at the end of enumerator lists are typos, > though fixing quite a few of them in the patch attached. I have also > attached the log message with this mail. > Please share your views. I'm not sure about the

[Patch] fix for compilation error, when compiled with "-pedantic" option

2011-10-27 Thread Prabhu Gnana Sundar
Hi all, When compiling the Subversion 1.7 code with the GCC(4.2.1) with compiler option "-pedantic", compilation fails with an error " comma at the end of enumerator list". Here is the snip: In file included from main.cc:1: /opt/local/include/subversion-1/svn_wc.h:1210: error: comma at end