forgot to cc: dev again.
-- Forwarded message --
From: Greg Ames
Date: Fri, May 21, 2010 at 10:28 AM
Subject: Re: [PATCH - v3] readable error messages on non-ASCII systems
To: Stefan Sperling
On Thu, May 20, 2010 at 7:23 PM, Stefan Sperling wrote:
> On Thu, May 20, 2010
On Fri, May 21, 2010 at 01:23:13AM +0200, Stefan Sperling wrote:
> (I don't really see a need for svn to have its own ctype implementation),
The need seems to be that we cannot rely on every locale correctly
handling UTF-8 strings.
But it seems APR would be a better home for this kind of thing.
S
On Thu, May 20, 2010 at 03:10:04PM -0400, Greg Ames wrote:
> I see that the svn ctype functions are hardwired to ASCII. If they called
> the equivalent apr ctype functions instead, they should become portable to
> EBCDIC. Doing that should change the behavior of
> svn_utf__cstring_from_utf8_fuzzy
This isn't going to do the whole job, nor is patch #2. If I grep for
'svn_cmdline_printf.*\"' to find where native literal strings are passed to
svn_cmdline_printf, I get 130 hits in trunk, for example:
./subversion/svn/util.c:SVN_ERR(svn_cmdline_printf(pool, _("\nWarning:
%s\n"),
./subversio
This version hits error.c only, no new APIs. Sending as an attachment per
http://subversion.apache.org/docs/community-guide/general.html#patches
[[[ Produce readable error messages on non-ASCII systems.
* subversion/libsvn_subr/error.c:
print_error(): convert err->message and the message
5 matches
Mail list logo
