Re: [PATCH] v4 #3460

2010-01-28 Thread Stefan Sperling
On Thu, Jan 28, 2010 at 12:53:08PM +, Julian Foad wrote: > Re. the spam email used as test data - nice idea, but it kind of offends > my eyes to see such junk on my screen :-) I'll have to take the blame for this. The text is used by virtually all patch tests. It popped into my inbox while I w

Re: [PATCH] v4 #3460

2010-01-28 Thread Julian Foad
Hi Daniel. Thanks for fixing the doc strings. Re. the spam email used as test data - nice idea, but it kind of offends my eyes to see such junk on my screen :-) > +/* Indicate in *MATCHED whether the original text of HUNK matches the patch > + * TARGET at its current line. Lines at FUZZ offset

Re: [PATCH] v4 #3460

2010-01-28 Thread Stefan Sperling
On Thu, Jan 28, 2010 at 01:55:08PM +0100, Daniel Näslund wrote: > Index: subversion/libsvn_diff/parse-diff.c Can't read the whole diff right now, just a couple of small remarks: >svn_boolean_t lines_matched; > @@ -630,9 +635,21 @@ > eol_str, FALSE,

Re: [PATCH] v4 #3460

2010-01-28 Thread Daniel Näslund
Hi! On Thu, Jan 28, 2010 at 11:31:08AM +0100, Stefan Sperling wrote: > On Thu, Jan 28, 2010 at 10:03:45AM +0100, Daniel Näslund wrote: > > Index: subversion/libsvn_diff/parse-diff.c > > === > > --- subversion/libsvn_diff/parse-diff.c