Re: [PATCH] svnadmin: Print LOCK_PATH's correctly.

2017-06-02 Thread Julian Foad
On 2017-05-31, Daniel Shahaf wrote: Daniel Shahaf wrote on Tue, 30 May 2017 22:07 +: Thanks for the review, Julian. I'll commit the patch as-is when I have a moment, and probably add something to the release notes about the output change as well. (In case people are regex-matching the outp

Re: [PATCH] svnadmin: Print LOCK_PATH's correctly.

2017-05-31 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, 30 May 2017 22:07 +: > Thanks for the review, Julian. I'll commit the patch as-is when I have > a moment, and probably add something to the release notes about the > output change as well. (In case people are regex-matching the output...) Done in r1797222, r179722

Re: [PATCH] svnadmin: Print LOCK_PATH's correctly.

2017-05-30 Thread Daniel Shahaf
Julian Foad wrote on Tue, 30 May 2017 15:19 +0100: > It looks like lots of the argument parsing in 'svnadmin' lacks UTF-8 > conversion. I think this should be done in the function 'parse_args' > instead of everywhere else. +1: transcoding is an aspect of argv parsing, not of the business logic.

Re: [PATCH] svnadmin: Print LOCK_PATH's correctly.

2017-05-30 Thread Julian Foad
On 27/05/17 17:23, Daniel Shahaf wrote: Patch + log message attached. It changes the expected output, and I'm not sure how strictly compatible we want to be about that, hence posting here first. If I don't hear anything I'll go ahead and commit. (It seems that the code being changed is passin

[PATCH] svnadmin: Print LOCK_PATH's correctly.

2017-05-27 Thread Daniel Shahaf
Patch + log message attached. It changes the expected output, and I'm not sure how strictly compatible we want to be about that, hence posting here first. If I don't hear anything I'll go ahead and commit. (It seems that the code being changed is passing an APR-encoded path to a printing functio