Re: [PATCH] support printing changed properties in svnlook

2011-02-26 Thread Gavin Beau Baumanis
Hi Daniel / Erik, I have created a new issue : 3821. You can find it here; http://subversion.tigris.org/issues/show_bug.cgi?id=3821 I have attached the latest submission to this issue. On 23/02/2011, at 12:44 AM, Daniel Shahaf wrote: > Yes, please file an issue, and in the meantime I'll re-a

Re: [PATCH] support printing changed properties in svnlook

2011-02-22 Thread Daniel Shahaf
Yes, please file an issue, and in the meantime I'll re-add it to my list. (There are a few things ahead of it...) Thanks! Daniel Gavin Beau Baumanis wrote on Tue, Feb 22, 2011 at 21:29:27 +1100: > Hi Daniel, > > Just checking as to whether or not you think you'll be able to get to this > subm

Re: [PATCH] support printing changed properties in svnlook

2011-02-22 Thread Gavin Beau Baumanis
Hi Daniel, Just checking as to whether or not you think you'll be able to get to this submission or not, please? I'm more than happy to log it into the Issue Tracker, if you feel that time is getting the better of you. On 08/01/2011, at 5:08 AM, Daniel Shahaf wrote: > I'll add it to my list,

Re: [PATCH] support printing changed properties in svnlook

2011-02-06 Thread Gavin Beau Baumanis
Ping. This patch has received no new comments. On 08/01/2011, at 5:08 AM, Daniel Shahaf wrote: > I'll add it to my list, but as I'll have to read the whole thing before > answering it might take a while until I'll answer. > > If anyone else wants to beat me to it... > > > Erik Johansson wrot

Re: [PATCH] support printing changed properties in svnlook

2011-01-07 Thread Daniel Shahaf
I'll add it to my list, but as I'll have to read the whole thing before answering it might take a while until I'll answer. If anyone else wants to beat me to it... Erik Johansson wrote on Thu, Jan 06, 2011 at 22:43:43 +0100: > On Thu, Jan 6, 2011 at 19:15, Daniel Shahaf wrote: > > I can't find

Re: [PATCH] support printing changed properties in svnlook

2011-01-06 Thread Erik Johansson
On Thu, Jan 6, 2011 at 19:15, Daniel Shahaf wrote: > I can't find a summary anywhere in your mail.  Is the summary "Here is > a work-in-progress patch that revvs the struct and adds a mod_props > member, and below are the specific semantics I'm thinking of for that > member; please review those se

Re: [PATCH] support printing changed properties in svnlook

2011-01-06 Thread Daniel Shahaf
Erik Johansson wrote on Wed, Jan 05, 2011 at 22:43:51 +0100: > Hi, > > I have now redone the patch to fix some of the comments given in this > thread and I'm attaching the current working state of it so that we > can have something real to discuss around. This does not include any > changes to svn

Re: [PATCH] support printing changed properties in svnlook

2011-01-05 Thread Erik Johansson
Hi, I have now redone the patch to fix some of the comments given in this thread and I'm attaching the current working state of it so that we can have something real to discuss around. This does not include any changes to svnlook but have a test case to verify that it works as it should (which it

Re: [PATCH] support printing changed properties in svnlook

2010-12-28 Thread Daniel Shahaf
[ The second hunk below has a discussion regarding the representation in the API of 'svn ps k v iota; svn ci iota; svn cp iota iota2; svn ps k2 v2 iota2; svn ci iota2', which I'd be happy to have further input on. ] Erik Johansson wrote on Wed, Dec 22, 2010 at 23:08:30 +0100: > On Fri, Dec 10, 201

Re: [PATCH] support printing changed properties in svnlook

2010-12-28 Thread Daniel Shahaf
Erik Johansson wrote on Wed, Dec 22, 2010 at 23:00:43 +0100: > On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf wrote: > >> >> +  /** How this property entered the node tree: 'A'dd, 'D'elete, > >> >> 'R'eplace */ > >> >> +  char action; > >> > > >> > This is copied from svn_repos_node_t->action.  The

Re: [PATCH] support printing changed properties in svnlook

2010-12-22 Thread Erik Johansson
On Fri, Dec 10, 2010 at 15:08, Daniel Shahaf wrote: > [ I'm somewhat confused about this issue. ] > > Erik Johansson wrote on Thu, Dec 09, 2010 at 21:41:38 +0100: >> On Wed, Dec 8, 2010 at 23:22, Daniel Shahaf wrote: >> > Erik Johansson wrote on Wed, Dec 08, 2010 at 17:17:47 +0100: >> >> +  /** H

Re: [PATCH] support printing changed properties in svnlook

2010-12-22 Thread Erik Johansson
On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf wrote: >> >> +  /** How this property entered the node tree: 'A'dd, 'D'elete, >> >> 'R'eplace */ >> >> +  char action; >> > >> > This is copied from svn_repos_node_t->action.  There was recently >> > a question about that field: >> > http://mid.gmane.o

Re: [PATCH] support printing changed properties in svnlook

2010-12-14 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Dec 14, 2010 at 10:05:35 +0200: > Erik Johansson wrote on Mon, Dec 13, 2010 at 22:27:04 +0100: > > On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf > > wrote: > > > Could you untangle this mess around driving the editor?  (I might be > > > able to look into this later, but

Re: [PATCH] support printing changed properties in svnlook

2010-12-14 Thread Daniel Shahaf
Erik Johansson wrote on Mon, Dec 13, 2010 at 22:27:04 +0100: > On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf wrote: > > Could you untangle this mess around driving the editor?  (I might be > > able to look into this later, but not right now) > > See attempt in other thread. > Saw the thread, mar

Re: [PATCH] support printing changed properties in svnlook

2010-12-13 Thread Erik Johansson
On Fri, Dec 10, 2010 at 14:29, Daniel Shahaf wrote: > Could you untangle this mess around driving the editor?  (I might be > able to look into this later, but not right now) See attempt in other thread. [snip a discussion I'll have to get back to later] >> >> +} svn_repos_node_prop_t; >> > >> >

Re: [PATCH] support printing changed properties in svnlook

2010-12-10 Thread Daniel Shahaf
[ I'm somewhat confused about this issue. ] Erik Johansson wrote on Thu, Dec 09, 2010 at 21:41:38 +0100: > On Wed, Dec 8, 2010 at 23:22, Daniel Shahaf wrote: > > Erik Johansson wrote on Wed, Dec 08, 2010 at 17:17:47 +0100: > >> +  /** How this property entered the node tree: 'A'dd, 'D'elete, 'R'e

Re: [PATCH] support printing changed properties in svnlook

2010-12-10 Thread Daniel Shahaf
Erik Johansson wrote on Thu, Dec 09, 2010 at 21:41:38 +0100: > On Wed, Dec 8, 2010 at 23:22, Daniel Shahaf wrote: > > Erik Johansson wrote on Wed, Dec 08, 2010 at 17:17:47 +0100: > >> To support this, the editor created by svn_repos_node_editor has been > >> modified > >> to record changes to pro

Re: [PATCH] support printing changed properties in svnlook

2010-12-10 Thread Erik Johansson
On Fri, Dec 10, 2010 at 13:53, Julian Foad wrote: > Great.  Do you feel up to writing some Python tests for this to add to > the regression test suite?  That would be very useful. Sure, will do. // Erik -- Erik Johansson Home Page: http://ejohansson.se/ PGP Key: http://ejohansson.se/erik.asc

Re: [PATCH] support printing changed properties in svnlook

2010-12-10 Thread Julian Foad
On Fri, 2010-12-10 at 13:48 +0100, Erik Johansson wrote: > On Fri, Dec 10, 2010 at 12:55, Julian Foad wrote: > > Just to let you know, I tried your current patch on a trunk build, > > against a repository revision in which files were added, and it crashed: > > Yes, I've also found this when doing

Re: [PATCH] support printing changed properties in svnlook

2010-12-10 Thread Erik Johansson
On Fri, Dec 10, 2010 at 12:55, Julian Foad wrote: > Just to let you know, I tried your current patch on a trunk build, > against a repository revision in which files were added, and it crashed: Yes, I've also found this when doing some more testing after Daniel's mail. I fixed it by calling svn_f

Re: [PATCH] support printing changed properties in svnlook

2010-12-10 Thread Julian Foad
Hi Erik. Just to let you know, I tried your current patch on a trunk build, against a repository revision in which files were added, and it crashed: $ svnlook changed ~/vcs/green -r 16 A [...]/AddrChange/ A [...]/AddrChange/AddrLetters1-6.pdf $ svnlook changed ~/vcs/green -v -r 16 subversion

Re: [PATCH] support printing changed properties in svnlook

2010-12-09 Thread Erik Johansson
On Wed, Dec 8, 2010 at 23:22, Daniel Shahaf wrote: > Erik Johansson wrote on Wed, Dec 08, 2010 at 17:17:47 +0100: >> To support this, the editor created by svn_repos_node_editor has been >> modified >> to record changes to properties (requires the replay to be done with deltas). > > Do you mean:

Re: [PATCH] support printing changed properties in svnlook

2010-12-08 Thread Daniel Shahaf
[ a few observations, but I haven't reviewed all of this yet ] Erik Johansson wrote on Wed, Dec 08, 2010 at 17:17:47 +0100: > Hi, > > Please see attached patch. Comments most welcome, specially if there > is a better/less intrusive way of implementing . > > Please CC me as I'm not subscribed to

[PATCH] support printing changed properties in svnlook

2010-12-08 Thread Erik Johansson
Hi, Please see attached patch. Comments most welcome, specially if there is a better/less intrusive way of implementing . Please CC me as I'm not subscribed to the list. // Erik [[[ Support printing changed properties in svnlook by passing the "-v" parameter to the "svnlook changed" command. Th