On Tue, Jun 12, 2012 at 2:38 PM, Lieven Govaerts wrote:
> Attached patch shows what I suggest. The case you probably encounter
> is when the response is handled by handle_server_error.
> This is untested, I don't have a Windows setup ready and didn't
> install my build tools yet after upgrade to O
On Tue, Jun 12, 2012 at 2:18 PM, Lieven Govaerts wrote:
> On Tue, Jun 12, 2012 at 2:00 PM, Justin Erenkrantz
> wrote:
>> On Tue, Jun 12, 2012 at 1:56 PM, Lieven Govaerts wrote:
How is it supposed to retry? ra_serf needs to let the context_run
loop execute again to pull off the remaini
On Tue, Jun 12, 2012 at 2:00 PM, Justin Erenkrantz
wrote:
> On Tue, Jun 12, 2012 at 1:56 PM, Lieven Govaerts wrote:
>>> How is it supposed to retry? ra_serf needs to let the context_run
>>> loop execute again to pull off the remaining bits from the socket.
>>> Without the patch, we treat EAGAIN
On Tue, Jun 12, 2012 at 1:56 PM, Lieven Govaerts wrote:
>> How is it supposed to retry? ra_serf needs to let the context_run
>> loop execute again to pull off the remaining bits from the socket.
>> Without the patch, we treat EAGAIN as a fatal error and it gets
>> returned all the way to the clie
On Tue, Jun 12, 2012 at 1:50 PM, Johan Corveleyn wrote:
> Justin, here's the patch for the 404 which you made on my machine ...
I'm working on cleaning up this patch...but, with this patch plus the
patch at the beginning of the thread, all of the basic tests now pass
on Johan's machine with the f
On Tue, Jun 12, 2012 at 1:18 PM, Justin Erenkrantz
wrote:
> On Tue, Jun 12, 2012 at 1:01 PM, Lieven Govaerts wrote:
>> That seems strange, serf_context_run is not documented to return
>> APR_EGAIN. While the response handler can return APR_EAGAIN, serf
>> itself will translate this to APR_SUCCESS
On Tue, Jun 12, 2012 at 1:18 PM, Justin Erenkrantz
wrote:
> On Tue, Jun 12, 2012 at 1:01 PM, Lieven Govaerts wrote:
>> That seems strange, serf_context_run is not documented to return
>> APR_EGAIN. While the response handler can return APR_EAGAIN, serf
>> itself will translate this to APR_SUCCESS
Justin Erenkrantz writes:
> How is it supposed to retry? ra_serf needs to let the context_run
> loop execute again to pull off the remaining bits from the socket.
> Without the patch, we treat EAGAIN as a fatal error and it gets
> returned all the way to the client. -- justin
There are 2 other
On Tue, Jun 12, 2012 at 1:01 PM, Lieven Govaerts wrote:
> That seems strange, serf_context_run is not documented to return
> APR_EGAIN. While the response handler can return APR_EAGAIN, serf
> itself will translate this to APR_SUCCESS. As a result, ra_serf
> doesn't expect it and - rightfully IMO
On Tue, Jun 12, 2012 at 10:51 AM, Justin Erenkrantz
wrote:
> It seems we've tweaked how we handle EAGAIN inside of ra_serf and are
> treating it as a critical error.
>
> Right now, what Johan is seeing with his anti-virus software is that
> we very often receive EAGAIN from the sockets. However,
On 12.06.2012 10:51, Justin Erenkrantz wrote:
> It seems we've tweaked how we handle EAGAIN inside of ra_serf and are
> treating it as a critical error.
>
> Right now, what Johan is seeing with his anti-virus software is that
> we very often receive EAGAIN from the sockets. However, we're
> treati
It seems we've tweaked how we handle EAGAIN inside of ra_serf and are
treating it as a critical error.
Right now, what Johan is seeing with his anti-virus software is that
we very often receive EAGAIN from the sockets. However, we're
treating EAGAIN as a fatal error inside of
svn_ra_serf__context
12 matches
Mail list logo
