Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-22 Thread Daniel Shahaf
On Thu, Aug 22, 2013 at 11:22:59PM +0900, Masaru Tsuchiyama wrote: > Daniel Shahaf wrote: > >On Sat, Aug 03, 2013 at 03:52:49PM +0300, Daniel Shahaf wrote: > >>Masaru Tsuchiyama wrote on Sat, Aug 03, 2013 at 16:06:06 +0900: > >>>If I run the these scripts at Release\subversion\tests\cmdline, I don'

Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-22 Thread Masaru Tsuchiyama
Daniel Shahaf wrote: On Sat, Aug 03, 2013 at 03:52:49PM +0300, Daniel Shahaf wrote: Masaru Tsuchiyama wrote on Sat, Aug 03, 2013 at 16:06:06 +0900: If I run the these scripts at Release\subversion\tests\cmdline, I don't get a file-not-found error. So perhaps the right fix is not your patch, b

Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-03 Thread Daniel Shahaf
On Sat, Aug 03, 2013 at 03:52:49PM +0300, Daniel Shahaf wrote: > Masaru Tsuchiyama wrote on Sat, Aug 03, 2013 at 16:06:06 +0900: > > If I run the these scripts at Release\subversion\tests\cmdline, I don't > > get a file-not-found error. > > So perhaps the right fix is not your patch, but to look

Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-03 Thread Daniel Shahaf
Masaru Tsuchiyama wrote on Sat, Aug 03, 2013 at 16:06:06 +0900: > > One of your later patches had a *.txt extension but > application/octet-stream > > MIME type. It would be good if you could get your client to set text/* > > MIME type --- this actually changes the way the patch renders in many

Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-03 Thread Masaru Tsuchiyama
> One of your later patches had a *.txt extension but application/octet-stream > MIME type. It would be good if you could get your client to set text/* > MIME type --- this actually changes the way the patch renders in many > devs' clients, makes it easier for them to read/review/reply the patch

Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-02 Thread Daniel Shahaf
Masaru Tsuchiyama wrote on Sat, Aug 03, 2013 at 11:04:30 +0900: > > Please send patches as text/plain (*.txt extension often does this). > > I understand. > Thanks. One of your later patches had a *.txt extension but application/octet-stream MIME type. It would be good if you could get your cl

Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-02 Thread Masaru Tsuchiyama
> Please send patches as text/plain (*.txt extension often does this). I understand. > Masaru Tsuchiyama wrote on Sun, Jul 28, 2013 at 20:00:27 +0900: > > +++ subversion/tests/cmdline/svntest/main.py(working copy) > > @@ -412,12 +412,19 @@ > >if not stderr: > > stderr = subproces

Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-01 Thread Daniel Shahaf
Please send patches as text/plain (*.txt extension often does this). Masaru Tsuchiyama wrote on Sun, Jul 28, 2013 at 20:00:27 +0900: > +++ subversion/tests/cmdline/svntest/main.py (working copy) > @@ -412,12 +412,19 @@ >if not stderr: > stderr = subprocess.PIPE > > - p = subprocess.Po

[PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-07-28 Thread Masaru Tsuchiyama
Hi. I attach a patch to print debug information when subprocess.Popen raises an exception. If an executable which subprocess.Popen tries to lauch doesn't exist, "Not file found" error ocurrs. But subprocess.Popen doesn't print information which file is not found. So it is difficult to know w