Re: [PATCH] issue 3620: svn add ^/ triggers assertion failure

On 09/16/2010 10:24 AM, Uwe Stuehler wrote: > Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion failure > > * subversion/libsvn_client/cleanup.c (svn_client_upgrade): Check that > path isn't a URL. r99. Thanks again. -- C. Michael Pilato CollabNet <> www.collab.net

Re: [PATCH] issue 3620: svn add ^/ triggers assertion failure

On Thu, Sep 16, 2010 at 3:26 PM, C. Michael Pilato wrote: > On 09/16/2010 08:59 AM, Uwe Stuehler wrote: >> Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion failure >> >> * subversion/svn/upgrade-cmd.c >> (svn_cl__upgrade): Check that target arguments aren't URLs before >> upgr

Re: [PATCH] issue 3620: svn add ^/ triggers assertion failure

On 09/16/2010 08:59 AM, Uwe Stuehler wrote: > Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion failure > > * subversion/svn/upgrade-cmd.c > (svn_cl__upgrade): Check that target arguments aren't URLs before upgrading. > > * subversion/tests/cmdline/input_validation_tests.py: Ne

[PATCH] issue 3620: svn add ^/ triggers assertion failure

This patch adds to the input validation tests a new case to verify that "svn upgrade" rejects URL arguments (instead of crashing) and changes the svn_cl__upgrade() routine to make it so. The change in svn_cl__upgrade() is directly based on Stefan's change to svn_cl__add() in r965551. I've started

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

On Tue, Jul 13, 2010 at 01:00:14PM -0400, C. Michael Pilato wrote: > On 07/13/2010 11:02 AM, Stefan Sperling wrote: > > If we enforce a certain syntax for certain types of arguments, we should > > probably provide a way to relax the checks in case someone really > > wants to version files or direct

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

On 07/13/2010 11:02 AM, Stefan Sperling wrote: > On Fri, Jun 11, 2010 at 05:37:11PM +0200, Uwe Stuehler wrote: >> Meanwhile Michael Pilato and Stefan Sperling gave me even >> more input (thank you) and I was able to prepare a suite of tests >> modeled after others in subversion/tests in order to ch

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

On Fri, Jun 11, 2010 at 05:37:11PM +0200, Uwe Stuehler wrote: > Meanwhile Michael Pilato and Stefan Sperling gave me even > more input (thank you) and I was able to prepare a suite of tests > modeled after others in subversion/tests in order to check most > of the other commands which, like 'add' a

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

On 04/23/2010 11:24 PM, Stefan Sperling wrote: On Fri, Apr 23, 2010 at 12:46:44PM -0400, C. Michael Pilato wrote: As I noted, the check needs to happen inside the client API. The question becomes "Do we patch svn_client_addX() and svn_client_statusX() and svn_client_updateX() and ..." or is

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

On 04/26/10 05:27 PM, C. Michael Pilato wrote: Hyrum K. Wright wrote: On Fri, Apr 23, 2010 at 4:24 PM, Stefan Sperling [...] I think it's best to consistently expand "^/". In my mind the above should be interpreted as: $ svn add http://svn.example.com/repos/ which would then generate whateve

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

Hyrum K. Wright wrote: > > On Fri, Apr 23, 2010 at 4:24 PM, Stefan Sperling > wrote: > > ... > > We should also consider changing the way "^/" is interpreted. > Maybe only commands that expect URLs as arguments should expand "^/" > to a URL? That way the ab

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

On Fri, Apr 23, 2010 at 4:24 PM, Stefan Sperling wrote: > ... > > We should also consider changing the way "^/" is interpreted. > Maybe only commands that expect URLs as arguments should expand "^/" > to a URL? That way the above error would become: > > $ svn add ^/ > svn: warning: '/path/to/work

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

On Fri, Apr 23, 2010 at 12:46:44PM -0400, C. Michael Pilato wrote: > As I noted, the check needs to happen inside the client API. The question > becomes "Do we patch svn_client_addX() and svn_client_statusX() and > svn_client_updateX() and ..." or is there a more general fix to be made > (like per

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

Greg Stein wrote: > On Fri, Apr 23, 2010 at 11:58, C. Michael Pilato wrote: >> Uwe Stuehler wrote: >>> [[[ >>> Fix issue #3620: svn add ^/ triggers assertion failure >>> >>> * subversion/svn/add-cmd.c: >>> (svn_cl__add): Raise an error if a target argument isn't a working >>> copy path before

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

On Fri, Apr 23, 2010 at 11:58, C. Michael Pilato wrote: > Uwe Stuehler wrote: >> [[[ >> Fix issue #3620: svn add ^/ triggers assertion failure >> >> * subversion/svn/add-cmd.c: >>   (svn_cl__add): Raise an error if a target argument isn't a working >>   copy path before calling svn_client_add4(),

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

Uwe Stuehler wrote: > [[[ > Fix issue #3620: svn add ^/ triggers assertion failure > > * subversion/svn/add-cmd.c: > (svn_cl__add): Raise an error if a target argument isn't a working > copy path before calling svn_client_add4(), which would trigger an > assertion. > > Found by: stsp > Patc

Re: [PATCH] issue #3620: svn add ^/ triggers assertion failure

Uwe Stuehler wrote: > [[[ > Fix issue #3620: svn add ^/ triggers assertion failure > > * subversion/svn/add-cmd.c: > (svn_cl__add): Raise an error if a target argument isn't a working > copy path before calling svn_client_add4(), which would trigger an > assertion. > > Found by: stsp > Patc

[PATCH] issue #3620: svn add ^/ triggers assertion failure

[[[ Fix issue #3620: svn add ^/ triggers assertion failure * subversion/svn/add-cmd.c: (svn_cl__add): Raise an error if a target argument isn't a working copy path before calling svn_client_add4(), which would trigger an assertion. Found by: stsp Patch by: Uwe Stuehler (subversion-li...@bsd