Re: [PATCH] fix use-after-free in mod_dav_svn's log_warning()

On Tue, Dec 18, 2018 at 10:15:56AM +0100, Stefan Sperling wrote: > On Tue, Dec 18, 2018 at 03:55:42AM +0100, Stefan Fuhrmann wrote: > > Error handling during tear-down is always a bit messy. > > > > I guess not using the request struct will mean we cannot > > tell what operation cased a problem -

Re: [PATCH] fix use-after-free in mod_dav_svn's log_warning()

On Tue, Dec 18, 2018 at 03:55:42AM +0100, Stefan Fuhrmann wrote: > Error handling during tear-down is always a bit messy. > > I guess not using the request struct will mean we cannot > tell what operation cased a problem - ever (not sure, > though). If true, that's a high cost. > > One way to imp

Re: [PATCH] fix use-after-free in mod_dav_svn's log_warning()

On 17.12.18 10:44, Stefan Sperling wrote: I have hit a use-after-free in mod_dav_svn while running SVN's regression tests on OpenBSD with httpd 2.4. This problem was apparently known to the author; see the comment which is removed in the diff below. In short, the request structure used as loggin

[PATCH] fix use-after-free in mod_dav_svn's log_warning()

I have hit a use-after-free in mod_dav_svn while running SVN's regression tests on OpenBSD with httpd 2.4. This problem was apparently known to the author; see the comment which is removed in the diff below. In short, the request structure used as logging context can already be freed before log_wa