Re: [PATCH] fix for programmer error in path split text logic

2013-12-09 Thread Philip Martin
Martin Furter writes: > I could also argue that it is inconsistent as long as you do not write > *c as *(c+0). > > But this is irrelevant. As you found out the log message is wrong. So > here is a honest one: > > [[[ > What led to at least one bug will probably lead to more bugs so remove > the u

Re: [PATCH] fix for programmer error in path split text logic

2013-12-09 Thread Martin Furter
Wrong button :/ Forwarding to the list too... Original Message Subject: Re: [PATCH] fix for programmer error in path split text logic Date: Mon, 09 Dec 2013 21:30:54 +0530 From: Martin Furter To: Philip Martin On 12/09/13 17:13, Philip Martin wrote: Martin Furter writes

Re: [PATCH] fix for programmer error in path split text logic

2013-12-09 Thread Philip Martin
Martin Furter writes: > On 12/09/13 15:27, Philip Martin wrote: >> Martin Furter writes: >> >>> Wouldn't last_dot[1] be more readable than (*(last_dot + 1) ? >> >> Probably. I approve a patch if you want to commit. > > A quick grep shows 21 of those constructs in the following files: > > ./subve

Re: [PATCH] fix for programmer error in path split text logic

2013-12-09 Thread Martin Furter
On 12/09/13 15:27, Philip Martin wrote: Martin Furter writes: Wouldn't last_dot[1] be more readable than (*(last_dot + 1) ? Probably. I approve a patch if you want to commit. A quick grep shows 21 of those constructs in the following files: ./subversion/libsvn_subr/path.c ./subversion/lib

Re: [PATCH] fix for programmer error in path split text logic

2013-12-09 Thread Philip Martin
Martin Furter writes: > Wouldn't last_dot[1] be more readable than (*(last_dot + 1) ? Probably. I approve a patch if you want to commit. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: [PATCH] fix for programmer error in path split text logic

2013-12-06 Thread Martin Furter
On 12/06/13 15:31, Philip Martin wrote: "Bert Huijben" writes: -Original Message- From: Eric Lubin [mailto:e...@lubin.us] Sent: donderdag 5 december 2013 21:17 To: dev@subversion.apache.org Subject: [PATCH] fix for programmer error in path split text logic [[[ *

Re: [PATCH] fix for programmer error in path split text logic

2013-12-06 Thread Philip Martin
"Bert Huijben" writes: >> -Original Message- >> From: Eric Lubin [mailto:e...@lubin.us] >> Sent: donderdag 5 december 2013 21:17 >> To: dev@subversion.apache.org >> Subject: [PATCH] fix for programmer error in path split text logic >>

RE: [PATCH] fix for programmer error in path split text logic

2013-12-06 Thread Bert Huijben
> -Original Message- > From: Eric Lubin [mailto:e...@lubin.us] > Sent: donderdag 5 december 2013 21:17 > To: dev@subversion.apache.org > Subject: [PATCH] fix for programmer error in path split text logic > > > [[[ > * subversion/libsvn_subr/path.c >

[PATCH] fix for programmer error in path split text logic

2013-12-05 Thread Eric Lubin
Index: subversion/libsvn_subr/path.c === --- subversion/libsvn_subr/path.c (revision 1548158) +++ subversion/libsvn_subr/path.c (working copy) @@ -1252,7 +1252,7 @@ svn_path_splitext(const char **path_root, anything a