AW: [PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-06 Thread Markus Schaber
ys.com] > Gesendet: Freitag, 6. Dezember 2013 16:21 > An: Eric Lubin; dev@subversion.apache.org > Betreff: AW: [PATCH] fix for programmer error in file equality check due to > pointer logic > > Hi, > > I'm the author of said code, and feel ashamed that this bug slipped

AW: [PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-06 Thread Markus Schaber
1:22 > An: dev@subversion.apache.org > Betreff: [PATCH] fix for programmer error in file equality check due to > pointer logic > > > [[[ > * subversion/libsvn_subr/io.c > (contents_three_identical_p): Fixed incorrect pointer check against NULL, > when the purpose was a

Re: [PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-06 Thread Eric Lubin
Yes. I used a static checker developed at MIT called STACK that looks for unstable code due to undefined behavior. http://css.csail.mit.edu/stack/ Compilers pay close attention to the C standard, and are free to optimize out certain logical operations, where possible, in the case of undefined

Re: [PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-06 Thread Philip Martin
Eric Lubin writes: > [[[ > * subversion/libsvn_subr/io.c > (contents_three_identical_p): Fixed incorrect pointer check against NULL, > when the purpose was actually to check the value stored at that pointer for > true or false > ]]] Committed, thanks! I guess you found these via a compiler

[PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-05 Thread Eric Lubin
Index: subversion/libsvn_subr/io.c === --- subversion/libsvn_subr/io.c (revision 1548158) +++ subversion/libsvn_subr/io.c (working copy) @@ -4614,7 +4614,7 @@ contents_three_identical_p(svn_boolean_t *identica /* As long as a