RE: [PATCH] fix for diff optimization bug

> -Original Message- > From: Hideki IWAMOTO [mailto:h-iwam...@kit.hi-ho.ne.jp] > Sent: zaterdag 29 december 2012 17:28 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: [PATCH] fix for diff optimization bug > > Hi. > > > I retraced your

Re: [PATCH] fix for diff optimization bug

2 13:31:21 +0100 "Bert Huijben" wrote: > > > > -Original Message- > > From: Daniel Shahaf [mailto:danie...@elego.de] > > Sent: zaterdag 29 december 2012 01:00 > > To: Hideki IWAMOTO > > Cc: dev@subversion.apache.org; Julian Foad > >

Re: [PATCH] fix for diff optimization bug

On Sat, Dec 29, 2012 at 2:22 PM, Hideki IWAMOTO wrote: > Hi, Daniel. > > Sorry for not understanding using of issue tracker. > >> OK, thanks for this. Could you set a more descriptive 'summary' on the >> issue, please? i.e., describe the bug, not just state that there is >> one. > > I change to

Re: [PATCH] fix for diff optimization bug

Hideki IWAMOTO wrote on Sat, Dec 29, 2012 at 22:22:00 +0900: > Hi, Daniel. > > Sorry for not understanding using of issue tracker. > No worries. Johan has worked on this code before, but I didn't want to assume he would have time: http://www.producingoss.com/en/managing-volunteers.html#delegati

Re: [PATCH] fix for diff optimization bug

Hi, Daniel. Sorry for not understanding using of issue tracker. > OK, thanks for this. Could you set a more descriptive 'summary' on the > issue, please? i.e., describe the bug, not just state that there is > one. I change to summary to 'When the identical suffix starts at chunk boundary,

Re: [PATCH] fix for diff optimization bug

Hideki IWAMOTO wrote on Sat, Dec 29, 2012 at 21:30:32 +0900: > Hi. > > > Hi Hideki, thanks for the patch. I hope Johan or Julian will have > > a look (probably next year), but if you don't get a response please ping > > the thread and I'll have a look. > > I created issue #4283 for diff optimiza

RE: [PATCH] fix for diff optimization bug

> -Original Message- > From: Daniel Shahaf [mailto:danie...@elego.de] > Sent: zaterdag 29 december 2012 01:00 > To: Hideki IWAMOTO > Cc: dev@subversion.apache.org; Julian Foad > Subject: Re: [PATCH] fix for diff optimization bug > > Hi Hideki, thanks for the

Re: [PATCH] fix for diff optimization bug

Hi. > Hi Hideki, thanks for the patch. I hope Johan or Julian will have > a look (probably next year), but if you don't get a response please ping > the thread and I'll have a look. I created issue #4283 for diff optimization bug and assigned to Johan. On Sat, 29 Dec 2012 02:00:02 +0200 Daniel

Re: [PATCH] fix for diff optimization bug

Hi Hideki, thanks for the patch. I hope Johan or Julian will have a look (probably next year), but if you don't get a response please ping the thread and I'll have a look. Hideki IWAMOTO wrote on Sat, Dec 29, 2012 at 08:25:07 +0900: > Hi, Daniel. > > > Because I assumed using svn_diff_mem_* woul

Re: [PATCH] fix for diff optimization bug

Hi, Daniel. > Because I assumed using svn_diff_mem_* would reproduce issue #4133. If > it doesn't, the test should be amended to use an API that will reproduce > the issue. The cause of issue #4133 is a bugs in the calculations of svn_diff__file_token_t::norm_offset. The test that you added is

Re: [PATCH] fix for diff optimization bug

Hi. > It would be very useful to have a regression test for the bug that you have > found.? Would you be able to convert your reproduction recipe into a > regression test written in C like the that one on trunk? > Please let us know if you would be willing to write a test for the bug you > foun

Re: [PATCH] fix for diff optimization bug

Hideki IWAMOTO wrote on Wed, Dec 26, 2012 at 00:31:16 +0900: > Hi, Daniel. > > > You might be interested to know that on the 'trunk', a new test has > > already been added for a similar problem: > > > > $ ./subversion/tests/libsvn_diff/diff-diff3-test --list > > [...] > > ? 13??? XFAIL? differe

Re: [PATCH] fix for diff optimization bug

Hi, Daniel. > You might be interested to know that on the 'trunk', a new test has already > been added for a similar problem: > > $ ./subversion/tests/libsvn_diff/diff-diff3-test --list > [...] > ? 13??? XFAIL? difference at the start of a 128KB window I have some questions about the test whic

Re: [PATCH] fix for diff optimization bug

Hideki IWAMOTO wrote on Tue, Dec 25, 2012 at 07:26:37 +0900: > Hi. > > > It would be very useful to have a regression test for the bug that you have > > found.? Would you be able to convert your reproduction recipe into a > > regression test written in C like the that one on trunk? > > Please le

Re: [PATCH] fix for diff optimization bug

Hi. > It would be very useful to have a regression test for the bug that you have > found.? Would you be able to convert your reproduction recipe into a > regression test written in C like the that one on trunk? > Please let us know if you would be willing to write a test for the bug you > foun

Re: [PATCH] fix for diff optimization bug

Hi, Hideki.  Thank you very much for finding this bug and a fix for it. You might be interested to know that on the 'trunk', a new test has already been added for a similar problem: $ ./subversion/tests/libsvn_diff/diff-diff3-test --list [...]   13    XFAIL  difference at the start of a 128KB wi

[PATCH] fix for diff optimization bug

Hi, Subversion developers. The optimization of diff inclued in version 1.7 has a bug that produces incorrect diff on a certain condition. The attached patch fix it. diffstat: subversion/libsvn_diff/diff_file.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Detail of the bug -