Re: [PATCH] fix a compilation warning

2010-12-09 Thread Philip Martin
Prabhu Gnana Sundar writes: > So I can say my patch holds good. I agree, r1044016. -- Philip

Re: [PATCH] fix a compilation warning

2010-12-09 Thread Prabhu Gnana Sundar
Hi all, I am sorry for the delayed reply and the carelessness. Initially, I did *not* have much context to comment on the patch. Just because the svn_client_relocate() was *deprecated* and it uses svn_client_relocate2() to implement itself in deprecated.c by hardcoding ignore_externals as TRUE,

Re: [PATCH] fix a compilation warning

2010-12-08 Thread Hyrum K. Wright
On Wed, Dec 8, 2010 at 3:29 PM, Daniel Shahaf wrote: > FWIW, my concerns here are: > > * svn_client_relocate{,2} have the same signature.  This might be >  confusing sometimes. (but probably should be left alone) > > * svn_client_relocate2() takes an IGNORE_EXTERNALS parameter.  Should >  we pass

Re: [PATCH] fix a compilation warning

2010-12-08 Thread Philip Martin
Daniel Shahaf writes: > * svn_client_relocate2() takes an IGNORE_EXTERNALS parameter. Should > we pass TRUE always to that parameter, or should we pass the > identically-named parameter of the calling function? (the calling > function *happens* to have an appropriately-named parameter, but

Re: [PATCH] fix a compilation warning

2010-12-08 Thread Daniel Shahaf
FWIW, my concerns here are: * svn_client_relocate{,2} have the same signature. This might be confusing sometimes. (but probably should be left alone) * svn_client_relocate2() takes an IGNORE_EXTERNALS parameter. Should we pass TRUE always to that parameter, or should we pass the identical

Re: [PATCH] fix a compilation warning

2010-12-08 Thread Julian Foad
On Wed, 2010-12-08, Philip Martin wrote: > Julian Foad writes: > > > On Wed, 2010-12-08 at 14:26 +, Julian Foad wrote: > >> Prabhu Gnana Sundar wrote: > >> > I have attached a patch with a minor change which fixes a compiler > >> > warning. > >> > >> Hi Prabhu. How do you know that svn_clie

Re: [PATCH] fix a compilation warning

2010-12-08 Thread Philip Martin
Julian Foad writes: > On Wed, 2010-12-08 at 14:26 +, Julian Foad wrote: >> Prabhu Gnana Sundar wrote: >> > I have attached a patch with a minor change which fixes a compiler >> > warning. >> >> Hi Prabhu. How do you know that svn_client_relocate2() is a drop-in >> replacement for svn_client

Re: [PATCH] fix a compilation warning

2010-12-08 Thread Julian Foad
On Wed, 2010-12-08 at 14:26 +, Julian Foad wrote: > Prabhu Gnana Sundar wrote: > > I have attached a patch with a minor change which fixes a compiler > > warning. > > Hi Prabhu. How do you know that svn_client_relocate2() is a drop-in > replacement for svn_client_relocate() in this case? Wha

Re: [PATCH] fix a compilation warning

2010-12-08 Thread Julian Foad
Prabhu Gnana Sundar wrote: > I have attached a patch with a minor change which fixes a compiler > warning. Hi Prabhu. How do you know that svn_client_relocate2() is a drop-in replacement for svn_client_relocate() in this case? What is difference between svn_client_relocate() and svn_client_reloc

[PATCH] fix a compilation warning

2010-12-08 Thread Prabhu Gnana Sundar
Hi, I have attached a patch with a minor change which fixes a compiler warning. Thanks and regards Prabhu Index: subversion/libsvn_client/update.c === --- subversion/libsvn_client/update.c (revision 1041694) +++ subversion/libsvn_