Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-25 Thread Stefan Sperling
On Tue, Nov 24, 2009 at 03:30:20PM +0100, Stefan Sperling wrote: > Avoid the GNU-specific "mindepth" and "maxdepth" options to "find". > > * Makefile.in: CLEAN_FILES can be a long list, so use an "echo | xargs" >construct which is less likely to cause a "too many arguments" error >since th

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-24 Thread Stefan Sperling
On Tue, Nov 24, 2009 at 02:18:20PM +, Julian Foad wrote: > Remember to mention the reason you are changing this at all: it was to > avoif the GNU-specific "mindepth" and "maxdepth" options to "find", > wasn't it? Ooops, yes, it was, thanks. [[[ Avoid the GNU-specific "mindepth" and "maxdepth"

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-24 Thread Julian Foad
Stefan Sperling wrote: > On Mon, Nov 23, 2009 at 08:11:32AM -0600, Peter Samuelson wrote: > > > > [Stefan Sperling] > > > How? > > > 'echo $(CLEAN_FILES) | xargs' has the same problem (can fail at 'echo') > > > > In theory it can, but echo is almost always a shell builtin. So the > > kernel argu

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-24 Thread Stefan Sperling
On Mon, Nov 23, 2009 at 08:11:32AM -0600, Peter Samuelson wrote: > > [Stefan Sperling] > > How? > > 'echo $(CLEAN_FILES) | xargs' has the same problem (can fail at 'echo') > > In theory it can, but echo is almost always a shell builtin. So the > kernel argument length limit does not apply, only

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-23 Thread Peter Samuelson
[Stefan Sperling] > How? > 'echo $(CLEAN_FILES) | xargs' has the same problem (can fail at 'echo') In theory it can, but echo is almost always a shell builtin. So the kernel argument length limit does not apply, only whatever limit the shell may have. -- Peter Samuelson | org-tld!p12n!peter | h

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-23 Thread Stefan Sperling
On Mon, Nov 23, 2009 at 07:16:49AM -0600, Hyrum K. Wright wrote: > On Nov 23, 2009, at 3:03 AM, Stefan Sperling wrote: > > Speaking of which, rm -f $(CLEAN_FILES) could also end up being too > > long on certain types of UNIX. So maybe put .pycs into a different list. > > Or if we can find out the m

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-23 Thread Hyrum K. Wright
On Nov 23, 2009, at 3:03 AM, Stefan Sperling wrote: > On Mon, Nov 23, 2009 at 12:44:32AM -0600, Peter Samuelson wrote: >> >> [Martin Furter] >>> --- Makefile.in (revision 883010) >>> +++ Makefile.in (working copy) >>> @@ -369,8 +369,8 @@ >>>rm -f $(CLEAN_FILES) >>>find $(CTYPES_P

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-23 Thread Stefan Sperling
On Mon, Nov 23, 2009 at 12:44:32AM -0600, Peter Samuelson wrote: > > [Martin Furter] > > --- Makefile.in (revision 883010) > > +++ Makefile.in (working copy) > > @@ -369,8 +369,8 @@ > > rm -f $(CLEAN_FILES) > > find $(CTYPES_PYTHON_SRC_DIR) $(SWIG_PY_SRC_DIR) $(SWIG_PY_DIR) \ > >

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-22 Thread Peter Samuelson
[Martin Furter] > --- Makefile.in (revision 883010) > +++ Makefile.in (working copy) > @@ -369,8 +369,8 @@ > rm -f $(CLEAN_FILES) > find $(CTYPES_PYTHON_SRC_DIR) $(SWIG_PY_SRC_DIR) $(SWIG_PY_DIR) \ > $(abs_srcdir)/build -name "*.pyc" -exec rm {} ';' > - find $

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-22 Thread Martin Furter
On Mon, 23 Nov 2009, Arfrever Frehtes Taifersar Arahesis wrote: 2009-11-23 02:46:14 Martin Furter napisa??(a): [[[ The options -mindepth and -maxdepth of find are not portable. Since there aren't any other python files in subversion/tests/ except those at depth 2 and 3 just drop those option

Re: [PATCH] find -mindepth/-maxdepth is not portable

2009-11-22 Thread Arfrever Frehtes Taifersar Arahesis
2009-11-23 02:46:14 Martin Furter napisaƂ(a): > > [[[ > The options -mindepth and -maxdepth of find are not portable. > Since there aren't any other python files in subversion/tests/ except > those at depth 2 and 3 just drop those options. Searching for *.pyc files in svn-test-work directory mig

[PATCH] find -mindepth/-maxdepth is not portable

2009-11-22 Thread Martin Furter
[[[ The options -mindepth and -maxdepth of find are not portable. Since there aren't any other python files in subversion/tests/ except those at depth 2 and 3 just drop those options. * Makefile.in (fast-clean): Remove -mindepth and -maxdepth from find command. ]]] [[[ Index: Makefile.in ==