RE: [PATCH] enhance diff to make it behave uniformly

2010-12-09 Thread Julian Foad
Kamesh Jayachandran wrote: > >I've been on this list for several years, and that's the first time > >I hear "he will" and "he would". > > I am one feet away from him geographically and reviewed his work > closely and hence got resonated to answer moment I saw Julian emails. > > Sorry if it meant

RE: [PATCH] enhance diff to make it behave uniformly

2010-12-08 Thread Kamesh Jayachandran
>> Sure he would. Right now he is teaching the 'svn_wc_get_diff_editor6' >> what he has taught for svn_client__get_diff_editor. >> >> He will have tests for that too. >> >I've been on this list for several years, and that's the first time >I hear "he will" and "he would". I am one feet away fro

Re: [PATCH] enhance diff to make it behave uniformly

2010-12-08 Thread Daniel Shahaf
Kamesh Jayachandran wrote on Wed, Dec 08, 2010 at 21:22:05 +0530: > On 12/08/2010 09:21 PM, Julian Foad wrote: >> On Sat, 2010-12-04, Kamesh Jayachandran wrote: I understand your patch fixes the following two cases. 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN Hi Kame

Re: [PATCH] enhance diff to make it behave uniformly

2010-12-08 Thread Kamesh Jayachandran
On 12/08/2010 09:21 PM, Julian Foad wrote: On Sat, 2010-12-04, Kamesh Jayachandran wrote: I understand your patch fixes the following two cases. 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN Hi Kamesh and Prabhu. What you're describing here sounds good - it sounds like a simpler and m

RE: [PATCH] enhance diff to make it behave uniformly

2010-12-08 Thread Julian Foad
On Sat, 2010-12-04, Kamesh Jayachandran wrote: > > I understand your patch fixes the following two cases. > > > > 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN > > >Hi Kamesh and Prabhu. > > >What you're describing here sounds good - it sounds like a simpler and > >more definite chang

RE: [PATCH] enhance diff to make it behave uniformly

2010-12-03 Thread Kamesh Jayachandran
> I understand your patch fixes the following two cases. > > 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN >Hi Kamesh and Prabhu. >What you're describing here sounds good - it sounds like a simpler and >more definite change than what I understood before - but I'm not sure >precisely wh

Re: [PATCH] enhance diff to make it behave uniformly

2010-12-03 Thread Julian Foad
On Wed, 2010-12-01, Kamesh Jayachandran wrote: > Hi Prabhu, > > I understand your patch fixes the following two cases. > > 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN Hi Kamesh and Prabhu. What you're describing here sounds good - it sounds like a simpler and more definite change th

Re: [PATCH] enhance diff to make it behave uniformly

2010-12-01 Thread Kamesh Jayachandran
Hi Prabhu, I understand your patch fixes the following two cases. 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN Without your patch we get a failure "explicitly_reinstated_file_with_mod_at_rN does not exist at rN-1" With your patch we get *modification* alone. 2. svn di -cN Parent_D

[PATCH] enhance diff to make it behave uniformly

2010-11-30 Thread Prabhu Gnana Sundar
Hi, In my previous patch [1] I suggested the addition of the '--diff-copy-from' switch to 'svn diff' to solve the cases where 'svn diff' would do the diff against the copyfrom source file when a file is reinstated or diff target is *not* explicit file. But since there is already a point that diff