Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-23 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 12:19:34PM +, Philip Martin wrote: > >> Stefan Sperling writes: >> >> > Fair enough, but why not write a specific test for this instead of testing >> > it as a side effect of making the code of other tests harder to read? >> >> The assumpti

RE: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: maandag 21 februari 2011 18:40 > To: Noorul Islam K M; Subversion > Cc: Stefan Sperling > Subject: Re: [PATCH] cat_tests.py: Modify expected error string to use only > error codes

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Hyrum K Wright
On Mon, Feb 21, 2011 at 4:19 AM, Stefan Sperling wrote: > On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote: >> >> Modify expected error string to use only error codes and also restrict >> one of the lines to less than 80 characters. >> >> Log >> [[[ >> >> * subversion/tests/cmdline

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 12:19:34PM +, Philip Martin wrote: > Stefan Sperling writes: > > > Fair enough, but why not write a specific test for this instead of testing > > it as a side effect of making the code of other tests harder to read? > > The assumption is that translation only affects

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Philip Martin
Stefan Sperling writes: > Fair enough, but why not write a specific test for this instead of testing > it as a side effect of making the code of other tests harder to read? The assumption is that translation only affects output to the user, not the internal behaviour of the commands. We have so

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 11:57:50AM +, Philip Martin wrote: > Stefan Sperling writes: > > > On Mon, Feb 21, 2011 at 11:21:10AM +, Philip Martin wrote: > >> Stefan Sperling writes: > >> > >> > But I think there is value in seeing the error message in the test code. > >> > It makes it much

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Philip Martin
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 11:21:10AM +, Philip Martin wrote: >> Stefan Sperling writes: >> >> > But I think there is value in seeing the error message in the test code. >> > It makes it much easier for those reading the test code to follow >> > what kind of error the

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 11:21:10AM +, Philip Martin wrote: > Stefan Sperling writes: > > > But I think there is value in seeing the error message in the test code. > > It makes it much easier for those reading the test code to follow > > what kind of error the test is expecting. If all people

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Philip Martin
Stefan Sperling writes: > But I think there is value in seeing the error message in the test code. > It makes it much easier for those reading the test code to follow > what kind of error the test is expecting. If all people can go by > is the error code, then they'll have to keep looking up erro

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 03:58:00PM +0530, Noorul Islam K M wrote: > >> Stefan Sperling writes: >> > But I think there is value in seeing the error message in the test code. >> > It makes it much easier for those reading the test code to follow >> > what kind of error th

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 03:58:00PM +0530, Noorul Islam K M wrote: > Stefan Sperling writes: > > But I think there is value in seeing the error message in the test code. > > It makes it much easier for those reading the test code to follow > > what kind of error the test is expecting. If all people

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote: > >> >> Modify expected error string to use only error codes and also restrict >> one of the lines to less than 80 characters. >> >> Log >> [[[ >> >> * subversion/tests/cmdline/cat_tests.py >> (cat_lo

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote: > > Modify expected error string to use only error codes and also restrict > one of the lines to less than 80 characters. > > Log > [[[ > > * subversion/tests/cmdline/cat_tests.py > (cat_local_directory, cat_remote_directory, ca

[PATCH] cat_tests.py: Modify expected error string to use only error codes.

2011-02-20 Thread Noorul Islam K M
Modify expected error string to use only error codes and also restrict one of the lines to less than 80 characters. Log [[[ * subversion/tests/cmdline/cat_tests.py (cat_local_directory, cat_remote_directory, cat_nonexistent_file, cat_skip_uncattable, cat_unversioned_file, cat_url_special