Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-14 Thread Julian Foad
On Fri, 2011-01-14 at 09:16 -0800, Danny Trebbien wrote: > >>> - SVN_ERR(normalize_string(&value, &was_normalized, pool)); > >>> + SVN_ERR(normalize_string(&value, &was_normalized, > >>> eb->prop_encoding, > >>> + pool, pool)); > >>>if (was_normalize

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-14 Thread Danny Trebbien
>>> -      SVN_ERR(normalize_string(&value, &was_normalized, pool)); >>> +      SVN_ERR(normalize_string(&value, &was_normalized, eb->prop_encoding, >>> +                               pool, pool)); >>>        if (was_normalized) >>> -        (*(eb->normalized_node_props_counter))++; >>> +        (

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-10 Thread Daniel Shahaf
Danny Trebbien wrote on Mon, Jan 10, 2011 at 08:55:35 -0800: > >> Perhaps, though, I should use svn_subst_translate_string2() with the > >> encoding set to "UTF-8". It would greatly simplify normalize_string(), > > > > +1.  Just call it with encoding=NULL; using the same API in both > > branches ma

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-10 Thread Danny Trebbien
>> Perhaps, though, I should use svn_subst_translate_string2() with the >> encoding set to "UTF-8". It would greatly simplify normalize_string(), > > +1.  Just call it with encoding=NULL; using the same API in both > branches makes life easier for the next person to revv that API. One thing that w

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-09 Thread Daniel Shahaf
Danny Trebbien wrote on Fri, Jan 07, 2011 at 13:03:18 -0800: > > Refresh my memory please: did we decide in some thread that the > > recodings should be counted too? > > At one point Stefan asked me if I was interested: > http://article.gmane.org/gmane.comp.version-control.subversion.devel/122540

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-07 Thread Danny Trebbien
> Seems to me it would be good for the name of the command-line option to > include "property", e.g. "--prop-source-encoding".  I note that this > option is not intended to be used frequently so I don't imagine it's a > problem to have a long name. How about "--source-prop-encoding"? >> > Index:

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-07 Thread Danny Trebbien
Hi Daniel and Julian, My apologies for the delay in responding. > Refresh my memory please: did we decide in some thread that the > recodings should be counted too? At one point Stefan asked me if I was interested: http://article.gmane.org/gmane.comp.version-control.subversion.devel/122540 >>  

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-05 Thread Julian Foad
On Sun, 2011-01-02, Daniel Shahaf wrote: > Danny Trebbien wrote on Sun, Dec 26, 2010 at 15:39:05 -0800: > > Attached are version 3 of the patch and corresponding log message. > > Also attached is a TGZ archive of two Subversion repository dumps that > > are used by a new test case. > > [[[ > > Add

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-01 Thread Daniel Shahaf
[ trimming CC ] Danny Trebbien wrote on Sun, Dec 26, 2010 at 15:39:05 -0800: > Attached are version 3 of the patch and corresponding log message. > Also attached is a TGZ archive of two Subversion repository dumps that > are used by a new test case. > [[[ > Add a command line option (--source-enc

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2010-12-26 Thread Danny Trebbien
Attached are version 3 of the patch and corresponding log message. Also attached is a TGZ archive of two Subversion repository dumps that are used by a new test case. Index: subversion/svnsync/sync.h === --- subversion/svnsync/sync.h