Re: [PATCH] add ability to export a specific revision when a working copy path is supplied (v2)

2017-07-18 Thread Philip Martin
Daniel Shahaf writes: > Philip Martin wrote on Tue, 18 Jul 2017 17:01 +0100: >> Committed as r1802316. Thanks! > > What do you think about backporting this to 1.9.7, Philip? While at the API > level this adds a new promise to the docstring, at the CLI level this fixes > an assertion error in a

Re: [PATCH] add ability to export a specific revision when a working copy path is supplied (v2)

2017-07-18 Thread Daniel Shahaf
Philip Martin wrote on Tue, 18 Jul 2017 17:01 +0100: > Doug Brown writes: > > > Thanks for your feedback! That change makes perfect sense. Here is a > > second attempt at this patch that I think addresses everything you > > listed. Patch with log message is attached. > > Committed as r1802316.

Re: [PATCH] add ability to export a specific revision when a working copy path is supplied (v2)

2017-07-18 Thread Philip Martin
Doug Brown writes: > Thanks for your feedback! That change makes perfect sense. Here is a > second attempt at this patch that I think addresses everything you > listed. Patch with log message is attached. Committed as r1802316. Thanks! -- Philip

[PATCH] add ability to export a specific revision when a working copy path is supplied (v2)

2017-07-17 Thread Doug Brown
Hi Philip, On 7/17/2017 4:14 AM, Philip Martin wrote: > - move the conversion from export_directory to svn_client_export5 > - change the parameter names in export_file_ev2, export_file, >export_directory > - remove the path code from those functions as it is never used > - add SVN_ERR_ASSE

Re: [PATCH] add ability to export a specific revision when a working copy path is supplied

2017-07-17 Thread Philip Martin
Doug Brown writes: > * subversion/libsvn_client/export.c > (export_directory): Ensure that from_path_or_url is converted to a URL prior > to passing it to svn_client__export_externals. svn_client_export5 has a top level if conditional: if (location is url) or (revision implies URL) then

[PATCH] add ability to export a specific revision when a working copy path is supplied

2017-07-16 Thread Doug Brown
The attached patch fixes an assertion failure when exporting from a working copy with the -r option when you have svn:externals that use the root-relative ^/ syntax, and updates the export_revision_with_root_relative_external test I recently wrote that checks for this situation. I'm completely new