Re: [PATCH] add SMTP SSL capability to mailer

2017-01-07 Thread Julian Foad
João M. S. Silva wrote: On 01/05/2017 10:35 AM, Julian Foad wrote: [...] so I suggest to remove ".lower()", for consistency. Should I change that or will someone from dev@subversion take care of it? It sounds like you're happy with that being changed. I can do it. OK, done. Committed revis

Re: [PATCH] add SMTP SSL capability to mailer

2017-01-06 Thread João M . S . Silva
Hi Julian, On 01/05/2017 10:35 AM, Julian Foad wrote: Just a minor issue: when processing other "option = yes" kind of config options, the script doesn't convert to lower case before testing its value, so I suggest to remove ".lower()", for consistency. Should I change that or will someone fro

Re: [PATCH] add SMTP SSL capability to mailer

2017-01-05 Thread Julian Foad
On 22/12/16, João M. S. Silva wrote: [I'm not subscribed to the list, please CC me.] I've discussed this patch with Daniel Shahaf in the users mailing list. This patch makes it possible to use e.g. Gmail's SMTP to send post-commit messages (using SSL). Looks good to me, in general; I haven't t

[PATCH] add SMTP SSL capability to mailer

2016-12-27 Thread João M . S . Silva
[I'm not subscribed to the list, please CC me.] Hi, I've discussed this patch with Daniel Shahaf in the users mailing list. This patch makes it possible to use e.g. Gmail's SMTP to send post-commit messages (using SSL). Can it be applied? Thanks. Best regards, -- João M. S. Silva [[[ Fi