Re: [PATCH] Virtual host mode with user name in URL

2018-02-15 Thread Branko Čibej
On 15.02.2018 16:54, Thomas Quinot wrote: > * Philip Martin, 2018-02-15 : > >> That looks correct so far, but it leads me to consider port numbers. >> >> svn ls svn://hostname:3691/repo >> >> Should the server look for the repository under 'hostname:3691' or under >> the plain 'hostname'? I susp

Re: [PATCH] Virtual host mode with user name in URL

2018-02-15 Thread Thomas Quinot
* Philip Martin, 2018-02-15 : > That looks correct so far, but it leads me to consider port numbers. > > svn ls svn://hostname:3691/repo > > Should the server look for the repository under 'hostname:3691' or under > the plain 'hostname'? I suspect the port number should be ignored and > that

Re: [PATCH] Virtual host mode with user name in URL

2018-02-15 Thread Philip Martin
Thomas Quinot writes: > [[[ > Fix failure to find repo in virtual host mode if user name present > > * subversion/svnserve/serve.c > (find_repos): In vhost mode, skip past user name and password, > if present. > ]]] > > Index: subversion/svnserve/serve.c >

[PATCH] Virtual host mode with user name in URL

2018-02-14 Thread Thomas Quinot
Bug reproduced on Debian GNU/Linux 9 with trunk version as of revision 1824204, building with default options. When operating svnserve in virtual host mode (--virtual-host), any attempt to access a repository through a URL that includes a user name will fail: $ mkdir -p /tmp/repos/localhost $ svn