Re: [PATCH] Update to out-of-date code comments

2012-12-28 Thread Daniel Shahaf
Gabriela Gibson wrote on Fri, Dec 28, 2012 at 11:47:08 +: > Corrections attached, thanks for the advice! Applie in r1426480 with minimal tweaks to the log message. Thanks!

Re: [PATCH] Update to out-of-date code comments

2012-12-28 Thread Gabriela Gibson
Corrections attached, thanks for the advice! (please pardon the thread mess, I had mail issues) Index: subversion/tests/svn_test_main.c === --- subversion/tests/svn_test_main.c (revision 1426301) +++ subversion/tests/svn_test_main.c

Re: [PATCH] Update to out-of-date code comments

2012-12-27 Thread Daniel Shahaf
Gabriela Gibson wrote on Thu, Dec 27, 2012 at 22:09:40 +: > On 27/12/12 17:24, Daniel Shahaf wrote:>> /* Acquire a lock (of sorts) > on the repository associated with the > >>* given RA SESSION. This lock is just a revprop change attempt in a > >> - * time-delay loop. This function is d

Re: [PATCH] Update to out-of-date code comments

2012-12-27 Thread Gabriela Gibson
On 27/12/12 17:24, Daniel Shahaf wrote:>> /* Acquire a lock (of sorts) on the repository associated with the >>* given RA SESSION. This lock is just a revprop change attempt in a >> - * time-delay loop. This function is duplicated by svnrdump in >> - * load_editor.c. >> + * time-delay loop.

Re: [PATCH] Update to out-of-date code comments

2012-12-27 Thread Daniel Shahaf
Gabriela Gibson wrote on Thu, Dec 27, 2012 at 14:13:01 +: > [[[ > Update code comments in a number of files which refer to "main.c", where > the file has been renamed. > > Update to comments in subversion/svnsync/svnsync.c and > subversion/svnrdump/load_editor.c which referred to the function >

[PATCH] Update to out-of-date code comments

2012-12-27 Thread Gabriela Gibson
[[[ Update code comments in a number of files which refer to "main.c", where the file has been renamed. Update to comments in subversion/svnsync/svnsync.c and subversion/svnrdump/load_editor.c which referred to the function (get_lock) being duplicated, where the prototypes differ slightly. * sub